Skip to content

RFC virtio fix up started checks

Michael S. Tsirkin qemu-devel virtio-fs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3virtio: distinguish between started and runninghw/virtio/vhost-user-fs.c hw/virtio/vhost-user-i2c.c hw/virtio/vhost-user-rng.c +3 more+16 -70 replies
2/3gpio: use virtio_device_runninghw/virtio/vhost-user-gpio.c+2 -20 replies
3/3virtio: revert changes to virtio_device_startedinclude/hw/virtio/virtio.h+0 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/3] virtio fix up started checks

This is an attempt to fix up device started checks. Unfortunately this causes failures in CI and I could not figure it out.

The simplest way to test is to set QEMU_CI to 2
on gitlab, then push there.

Alternatively, push to gitlab, then
create pipeline while setting QEMU_CI to 1, then run amd64-fedora-container and then clang-system - that slows things down enough to make the failures trigger.

See: https://gitlab.com/mstredhat/qemu/-/jobs/3279537476

Alex, Viresh, need your help here. Thanks!

Alex, pls note that same failures are triggered by your RFC - if we know the root cause we can discuss solutions. So if you prefer pls go ahead and debug that. Thanks!

Michael S. Tsirkin (3):
virtio: distinguish between started and running
gpio: use virtio_device_running
virtio: revert changes to virtio_device_started

 include/hw/virtio/virtio.h   | 7 ++++++-
 hw/virtio/vhost-user-fs.c    | 2 +-
 hw/virtio/vhost-user-gpio.c  | 4 ++--
 hw/virtio/vhost-user-i2c.c   | 4 ++--
 hw/virtio/vhost-user-rng.c   | 4 ++--
 hw/virtio/vhost-user-vsock.c | 2 +-
 hw/virtio/vhost-vsock.c      | 2 +-
 7 files changed, 15 insertions(+), 10 deletions(-)
Signature · 1 line
MST