Skip to content

RDMA/mlx5: Switch MR cache to use RB-tree

Michael Guralnik linux-rdma 5 versions – Applied

Status from this message: Applied to for-next

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 1 replyApplied
  2. v46 patches 5 repliesSuperseded
  3. v36 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches6 repliesSuperseded
v18 patches0 repliesSuperseded

Changes in v5 from the cover letter

- Commit message fix: 'Remove implicit ODP' instead of 'explicit'
- Fix return value of init function in case of no ODP in configuration

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/6RDMA/mlx5: Don't keep umrable 'page_shift' in cache entriesdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+1 -50 replies
2/6RDMA/mlx5: Remove implicit ODP cache entrydrivers/infiniband/hw/mlx5/odp.c include/linux/mlx5/driver.h+5 -160 replies
3/6RDMA/mlx5: Change the cache structure to an RB-treedrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+132 -470 replies
4/6RDMA/mlx5: Introduce mlx5r_cache_rb_keydrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+201 -840 replies
5/6RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flowdrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c+44 -130 replies
6/6RDMA/mlx5: Add work to remove temporary entries from the cachedrivers/infiniband/hw/mlx5/mlx5_ib.h drivers/infiniband/hw/mlx5/mr.c drivers/infiniband/hw/mlx5/odp.c+82 -230 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 rdma-next 0/6] RDMA/mlx5: Switch MR cache to use RB-tree

This series moves the MR cache to use RB tree to store the entries of the cache. By doing so, enabling more flexibility when managing the cache entries.

The MR cache will now cache mkeys returned by the user even if they are not from one of the predefined pools, by that allowing restarting applications to reuse their released mkey and improve restart times.

v4->v5:
- Commit message fix: 'Remove implicit ODP' instead of 'explicit'
- Fix return value of init function in case of no ODP in configuration

v3->v4:
- remove 'change-id' and 'issue' git trailers

v2->v3:
- Refactor MR cache init flow
- Move rb_key decleration to rome unnecessary change in following patches

v1->v2:
- Rearrange patch order to first introduce the RB-tree and only then introduce the caching of previously non-cachable mkeys

v0->v1:
- Fix rb tree search from memcmp to dedicated cmp function
- Rewording of some commit messages

Aharon Landau (2):
RDMA/mlx5: Don't keep umrable 'page_shift' in cache entries RDMA/mlx5: Remove explicit ODP cache entry

Michael Guralnik (4):
RDMA/mlx5: Change the cache structure to an RB-tree RDMA/mlx5: Introduce mlx5r_cache_rb_key
RDMA/mlx5: Cache all user cacheable mkeys on dereg MR flow RDMA/mlx5: Add work to remove temporary entries from the cache

 drivers/infiniband/hw/mlx5/mlx5_ib.h |  38 ++-
 drivers/infiniband/hw/mlx5/mr.c      | 478 +++++++++++++++++++++------
 drivers/infiniband/hw/mlx5/odp.c     |  40 +--
 include/linux/mlx5/driver.h          |   1 -
 4 files changed, 417 insertions(+), 140 deletions(-)
Signature · 1 line
2.17.2