serial: liteuart: add IRQ support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest14 patches 1 replyIn review
- v514 patches 24 repliesSuperseded
- v414 patches 5 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 14 patches | 21 replies | Superseded | |
| v2 | 7 patches | 2 replies | Superseded | |
| v1 | 3 patches | 5 replies | Superseded |
Changes in v6 from the cover letter
- picked up r/b Geert Uytterhoeven on select subset of commits
- 09/14 ("clean up rx loop variables"):
- eliminate status variable altogether as its value is known and constant inside the loop;
- switch ch to u8, to match the call *producing* it (litex_read8()) instead of those consuming its value.
- 12/14 ("add IRQ support for the RX path"):
- s/dev_err()/dev_warn()/ when falling back to polling in liteuart_startup()
- use spin_[lock_irqsave|unlock_irqrestore]() in the interrupt handler, since the same code may also be called in "serving_softirq" context when using a poll timer instead of interrupts
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | serial: liteuart: use KBUILD_MODNAME as driver namedrivers/ | +3 | 0 replies | |
| 2/14 | serial: liteuart: use bit number macrosdrivers/ | +3 | 0 replies | |
| 3/14 | serial: liteuart: remove unused uart_ops stubsdrivers/ | +0 | 0 replies | |
| 4/14 | serial: liteuart: don't set unused port fieldsdrivers/ | +0 | 0 replies | |
| 5/14 | serial: liteuart: minor style fix in liteuart_init()drivers/ | +2 | 0 replies | |
| 6/14 | serial: liteuart: move tty_flip_buffer_push() out of rx loopdrivers/ | +2 | 0 replies | |
| 7/14 | serial: liteuart: rx loop should only ack rx eventsdrivers/ | +1 | 0 replies | |
| 8/14 | serial: liteuart: simplify passing of uart_insert_char() flagdrivers/ | +1 | 0 replies | |
| 9/14 | serial: liteuart: clean up rx loop variablesdrivers/ | +3 | 0 replies | |
| 10/14 | serial: liteuart: separate rx loop from poll timerdrivers/ | +9 | 0 replies | |
| 11/14 | serial: liteuart: move function definitionsdrivers/ | +41 | 0 replies | |
| 12/14 | serial: liteuart: add IRQ support for the RX pathdrivers/ | +74 | 0 replies | |
| 13/14 | serial: liteuart: add IRQ support for the TX pathdrivers/ | +13 | 0 replies | |
| 14/14 | serial: liteuart: move polling putchar() functiondrivers/ | +8 | 0 replies |
Reviews trailers per patch
13 of 14 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Geert Uytterhoeven | Ilpo Järvinen | Jiri Slaby |
|---|---|---|---|
| Series | R-b | ||
| 1/14 | R-b | ||
| 2/14 | R-b | ||
| 3/14 | R-b | R-b | |
| 4/14 | R-b | ||
| 5/14 | R-b | R-b | |
| 6/14 | R-b | R-b | |
| 7/14 | |||
| 8/14 | R-b | R-b | |
| 9/14 | R-b | ||
| 10/14 | R-b | ||
| 11/14 | R-b | R-b | |
| 12/14 | R-b | ||
| 13/14 | R-b | ||
| 14/14 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 00/14] serial: liteuart: add IRQ support
Add IRQ support to the LiteX LiteUART serial interface
Changes from v5:
- picked up r/b Geert Uytterhoeven on select subset of commits
- 09/14 ("clean up rx loop variables"):
- eliminate status variable altogether as its value is known and constant inside the loop;
- switch ch to u8, to match the call *producing* it (litex_read8()) instead of those consuming its value.
- 12/14 ("add IRQ support for the RX path"):
- s/dev_err()/dev_warn()/ when falling back to polling in liteuart_startup()
- use spin_[lock_irqsave|unlock_irqrestore]() in the interrupt handler, since the same code may also be called in "serving_softirq" context when using a poll timer instead of interrupts
Quoted 40 lines
Changes from v4:
- picked up r/b Ilpo Järvinen on 12/14 and 13/14
- 12/14 ("add IRQ support for the RX path"): usingdev_err()insteadof combining pr_err() and pr_fmt(); also, remove superfluous commentChanges from v3:
- picked up r/b Ilpo Järvinen on select subset of commits
- rebased entire series on top of tty-next tree
- 2/14 ("use bit number macros"): explicitly include <linux/bits.h>
- 3/14 ("remove unuseduart_opsstubs"): don't add gratuitous comment removed later on in the series
- 12/14 ("add IRQ support for the RX path"): add shadow irq register to support polling mode and avoid reading hardware mmio irq register to learn which irq flags are enabled
- this also simplifies bothliteuart_interrupt()andliteuart_startup()
- 13/14 ("add IRQ support for the TX path"):
- removed superfluous curly braces fromliteuart_interrupt()
- simplified [start|stop]_tx() by using shadow irq register from 12/14
- simplifiedliteuart_tx_chars()by rebasing on top of tty-next treeChanges from v2:
- further split out "separate RX loop from poll timer" into dedicated patches highlighting additional changes explicitly:
- factoring outtty_flip_buffer_push()(6/14)
- ack only RX events in RX loop (7/14)
- pass constant flag touart_insert_char()directly (8/14)
- fix variable types in rx loop (9/14)
- separating RX loop from poll timer (10/14)
- added patch (11/14) to move function definitions to a more convenient location, making subsequent changes easier to read in diff patch form.
- fixes and clarifications for RX path IRQ support patch (now 12/14):
- only returnIRQ_HANDLEDfor RX events
- usepr_fmt()to improve style of irq setup error message
- remove unnecessary locking from around single-register access
- modify TX path to support both IRQ-mode and polling (13/14)
- move polling-onlyliteuart_putchar()behind same conditional (CONFIG_SERIAL_LITEUART_CONSOLE) as the rest of the code that's still using it.
Quoted 4 lines
Changes from v1:
- split minor cosmetic changes out into individual patches(1/3 became 1..5/7)- patches 6/7 and 7/7 unchanged (used to be 2/3 and 3/3)
Gabriel Somlo (14):
serial: liteuart: use KBUILD_MODNAME as driver name
serial: liteuart: use bit number macros
serial: liteuart: remove unused uart_ops stubs
serial: liteuart: don't set unused port fields
serial: liteuart: minor style fix in liteuart_init()
serial: liteuart: move tty_flip_buffer_push() out of rx loop
serial: liteuart: rx loop should only ack rx events
serial: liteuart: simplify passing of uart_insert_char() flag
serial: liteuart: clean up rx loop variables
serial: liteuart: separate rx loop from poll timer
serial: liteuart: move function definitions
serial: liteuart: add IRQ support for the RX path
serial: liteuart: add IRQ support for the TX path
serial: liteuart: move polling putchar() function
drivers/tty/serial/liteuart.c | 217 +++++++++++++++++++++------------- 1 file changed, 132 insertions(+), 85 deletions(-)
Signature · 1 line
2.38.1