Add guard padding around i915_vma
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 6 repliesIn review
- v35 patches 2 repliesSuperseded
- v24 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 3 patches | 4 replies | Superseded |
Changes in v4 from the cover letter
- change the order of the patches: the 64->32 bit change of the memory alignment goes as first (Tvrtko).
- Use roundup instead of ALIGN to round up the guard padding (Chris).
- Restore the GEM_BUG_ON(2 * guard > end) as a paranoiac check and as mean of documentation (Chris).
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | drm/i915: Limit the display memory alignment to 32 bit instead of 64drivers/ drivers/ drivers/ | +3 | 0 replies | |
| 2/5 | drm/i915: Wrap all access to i915_vma.node.start|sizedrivers/ drivers/ drivers/ +26 more | +180 | 0 replies | |
| 3/5 | drm/i915: Introduce guard pages to i915_vmadrivers/ drivers/ drivers/ +4 more | +57 | 9 replies | |
| 4/5 | drm/i915: Refine VT-d scanout workarounddrivers/ drivers/ | +14 | 1 reply | |
| 5/5 | Revert "drm/i915: Improve on suspend / resume time with VT-d enabled"drivers/ drivers/ drivers/ | +13 | 1 reply |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Tvrtko Ursulin |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | R-b R-b |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] Add guard padding around i915_vma
Hi,
This series adds guards around vma's but setting a pages at the beginning and at the end that work as padding.
The first user of the vma guard are scanout objects which don't need anymore to add scratch to all the unused ggtt's and speeding up up considerably the boot and resume by several hundreds of milliseconds up to over a full second in slower machines.
Because of this we don't need anymore 2ef6efa79fec ("drm/i915:
Improve on suspend / resume time with VT-d enabled") which gets reverted.
Thanks Tvrtko and Chris for the review.
Andi
Changelog
=========
v3 -> v4:
- change the order of the patches: the 64->32 bit change of the memory alignment goes as first (Tvrtko).
- Use roundup instead of ALIGN to round up the guard padding (Chris).
- Restore the GEM_BUG_ON(2 * guard > end) as a paranoiac check and as mean of documentation (Chris).
v2 -> v3:
- fix Tvrtko's comments: explain in a comment why the guard is is alligned as the vma and remove a GEM_BUG_ON() in case the the total padding was exceeding the size of the va.
- the display_alignment is declared as u32 instead of a u64 in a separate patch.
v1 -> v2:
- Revert 2ef6efa79fec ("drm/i915: Improve on suspend / resume time with VT-d enabled")
Andi Shyti (2):
drm/i915: Limit the display memory alignment to 32 bit instead of 64 Revert "drm/i915: Improve on suspend / resume time with VT-d enabled"
Chris Wilson (3):
drm/i915: Wrap all access to i915_vma.node.start|size drm/i915: Introduce guard pages to i915_vma drm/i915: Refine VT-d scanout workaround
drivers/gpu/drm/i915/display/intel_fb_pin.c | 2 +- drivers/gpu/drm/i915/display/intel_fbdev.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 15 ++- .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 33 +++--- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 4 +- .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- .../i915/gem/selftests/i915_gem_client_blt.c | 23 ++-- .../drm/i915/gem/selftests/i915_gem_context.c | 15 ++- .../drm/i915/gem/selftests/i915_gem_mman.c | 2 +- .../drm/i915/gem/selftests/igt_gem_utils.c | 7 +- drivers/gpu/drm/i915/gt/gen7_renderclear.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c | 108 ++++-------------- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 3 +- drivers/gpu/drm/i915/gt/intel_gtt.h | 24 ---- drivers/gpu/drm/i915/gt/intel_renderstate.c | 2 +- .../gpu/drm/i915/gt/intel_ring_submission.c | 2 +- drivers/gpu/drm/i915/gt/selftest_engine_cs.c | 8 +- drivers/gpu/drm/i915/gt/selftest_execlists.c | 18 +-- drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 15 +-- drivers/gpu/drm/i915/gt/selftest_lrc.c | 16 +-- .../drm/i915/gt/selftest_ring_submission.c | 2 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 12 +- .../gpu/drm/i915/gt/selftest_workarounds.c | 8 +- drivers/gpu/drm/i915/i915_cmd_parser.c | 4 +- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 16 --- drivers/gpu/drm/i915/i915_gem_gtt.h | 3 +- drivers/gpu/drm/i915/i915_perf.c | 2 +- drivers/gpu/drm/i915/i915_vma.c | 63 +++++++--- drivers/gpu/drm/i915/i915_vma.h | 52 ++++++++- drivers/gpu/drm/i915/i915_vma_resource.c | 4 +- drivers/gpu/drm/i915/i915_vma_resource.h | 17 ++- drivers/gpu/drm/i915/i915_vma_types.h | 3 +- drivers/gpu/drm/i915/selftests/i915_request.c | 20 ++-- drivers/gpu/drm/i915/selftests/igt_spinner.c | 8 +- 37 files changed, 264 insertions(+), 259 deletions(-)
Signature · 1 line
2.38.1