whitespace after keywords
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest14 patches 6 repliesIn review
- v214 patches 0 repliesSuperseded
- v114 patches 1 replySuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | eal: fix whitespacelib/ lib/ lib/ | +6 | 0 replies | |
| 2/14 | cmdline: fix whitespacelib/ lib/ | +13 | 0 replies | |
| 3/14 | timer: fix whitespacelib/ | +1 | 0 replies | |
| 4/14 | ip_frag: fix whitespacelib/ | +1 | 0 replies | |
| 5/14 | testpmd: fix whitespaceapp/ app/ app/ | +23 | 2 replies | |
| 6/14 | test: fix whitespaceapp/ app/ app/ +5 more | +23 | 0 replies | |
| 7/14 | examples/qos_sched: fix whitespaceexamples/ examples/ examples/ +1 more | +7 | 0 replies | |
| 8/14 | examples/vhost: fix whitespaceexamples/ | +3 | 1 reply | |
| 9/14 | l3fwd: fix whitespaceexamples/ examples/ | +8 | 0 replies | |
| 10/14 | examples: fix whitespaceexamples/ examples/ examples/ | +5 | 0 replies | |
| 11/14 | bus/pci: fix whitespacedrivers/ | +1 | 0 replies | |
| 12/14 | net/e1000: fix whitespacedrivers/ drivers/ drivers/ +1 more | +8 | 0 replies | |
| 13/14 | net/i40e: fix whitespacedrivers/ | +4 | 3 replies | |
| 14/14 | net/bnx2x: fix whitespacedrivers/ | +1 | 0 replies |
Reviews trailers per patch
4 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Cristian Dumitrescu | Chenbo Xia | Yuying Zhang |
|---|---|---|---|
| 1/14 | |||
| 2/14 | |||
| 3/14 | |||
| 4/14 | |||
| 5/14 | Reviewed-off-by R-b | ||
| 6/14 | |||
| 7/14 | A-b | ||
| 8/14 | R-b | ||
| 9/14 | |||
| 10/14 | |||
| 11/14 | |||
| 12/14 | |||
| 13/14 | Reviewed-off-by R-b | ||
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 00/14] whitespace after keywords
The DPDK standard now enforced through checkpatch is to use a space after keywords. Much of the older code that was grandfathered in doesn't follow that, so fix it.
No urgency to this patchset, and it might just be viewed as churn. But I prefer to read code that looks all the same.
“A foolish consistency is the hobgoblin of little minds, adored by little statesmen and philosophers and divines. With consistency a great soul has simply nothing to do. He may as well concern himself with his shadow on the wall." -- Ralph Waldo Emerson
v3 - fix typo in previous version (forgot to remove one brace)
and find a few more leftover uses of "for(" and "while("
Stephen Hemminger (14):
eal: fix whitespace
cmdline: fix whitespace
timer: fix whitespace
ip_frag: fix whitespace
testpmd: fix whitespace
test: fix whitespace
examples/qos_sched: fix whitespace
examples/vhost: fix whitespace
l3fwd: fix whitespace
examples: fix whitespace
bus/pci: fix whitespace
net/e1000: fix whitespace
net/i40e: fix whitespace
net/bnx2x: fix whitespace
app/test-pmd/cmdline.c | 31 +++++++++++----------- app/test-pmd/parameters.c | 10 ++++--- app/test-pmd/testpmd.c | 2 +- app/test/test_cmdline_cirbuf.c | 4 +-- app/test/test_debug.c | 4 +-- app/test/test_hash.c | 6 ++--- app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++++----- app/test/test_mbuf.c | 14 +++++----- app/test/test_ring_perf.c | 2 +- app/test/test_spinlock.c | 2 +- drivers/bus/pci/bsd/pci.c | 2 +- drivers/net/bnx2x/bnx2x.h | 2 +- drivers/net/e1000/em_ethdev.c | 4 +-- drivers/net/e1000/igb_ethdev.c | 8 +++--- drivers/net/e1000/igb_pf.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- drivers/net/i40e/i40e_pf.c | 8 +++--- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/l3fwd-power/main.c | 7 ++--- examples/l3fwd/main.c | 7 ++--- examples/multi_process/symmetric_mp/main.c | 6 ++--- examples/qos_sched/app_thread.c | 6 ++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 +-- examples/vhost/main.c | 7 +++-- lib/cmdline/cmdline_parse_string.c | 17 +++++------- lib/cmdline/cmdline_rdline.c | 12 ++++----- lib/eal/include/generic/rte_cycles.h | 4 +-- lib/eal/linux/eal_hugepage_info.c | 6 ++--- lib/eal/linux/eal_interrupts.c | 2 +- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- lib/timer/rte_timer.c | 2 +- 35 files changed, 104 insertions(+), 105 deletions(-)
Signature · 1 line
2.35.1