Skip to content

ASoC: Intel: avs: DSP recovery and resume fixes

Cezary Rojewski alsa-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 8 repliesSuperseded
  3. v12 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- added a comment why non-_irq() locking is used around snd_pcm_stop()

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: Intel: avs: Lock substream before snd_pcm_stop()sound/soc/intel/avs/ipc.c+3 -00 replies
2/2ASoC: Intel: avs: Disconnect substream if suspend or resume failssound/soc/intel/avs/pcm.c+8 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] ASoC: Intel: avs: DSP recovery and resume fixes

Two fixes that are result of the recent discussions [1][2].

First adds missing locking around snd_pcm_stop() while the second fix sets substream state to DISCONNECTED if any suspend/resume related operation fails so that userspace has means to be aware that something went wrong during said operation.

Changes in v3:
- added a comment why non-_irq() locking is used around snd_pcm_stop()

Changes in v2:
- __snd_pcm_set_state() replaced direct assignments of PCM state

[1]: https://lore.kernel.org/alsa-devel/[email protected]/
[2]: https://lore.kernel.org/alsa-devel/[email protected]/

Cezary Rojewski (2):
ASoC: Intel: avs: Lock substream before snd_pcm_stop()
ASoC: Intel: avs: Disconnect substream if suspend or resume fails

 sound/soc/intel/avs/ipc.c |  3 +++
 sound/soc/intel/avs/pcm.c | 10 ++++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1