btrfs: fix sleep from invalid context bug in update_qgroup_limit_item()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest2 patches 2 repliesIn review
- v52 patches 1 replySuperseded
- v43 patches 9 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 1 patch | 1 reply | Superseded | |
| v2 | 1 patch | 2 replies | Superseded | |
| v1 | 1 patch | 8 replies | Superseded |
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | btrfs: add might_sleep() to some places in update_qgroup_limit_item()fs/ | +4 | 0 replies | |
| 2/2 | btrfs: qgroup: fix sleep from invalid context bug in update_qgroup_limit_item()fs/ | +1 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Qu Wenruo |
|---|---|
| 1/2 | |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 0/2] btrfs: fix sleep from invalid context bug in update_qgroup_limit_item()
At least 3 places might sleep in update_qgroup_limit_item(), as shown below:
update_qgroup_limit_item
btrfs_alloc_path
/* allocate memory non-atomically, might sleep */
kmem_cache_zalloc(btrfs_path_cachep, GFP_NOFS)
btrfs_search_slot
setup_nodes_for_search
reada_for_balance
btrfs_readahead_node_child
btrfs_readahead_tree_block
btrfs_find_create_tree_block
alloc_extent_buffer
kmem_cache_zalloc
/* allocate memory non-atomically, might sleep */
kmem_cache_alloc(GFP_NOFS|__GFP_NOFAIL|__GFP_ZERO)
read_extent_buffer_pages
submit_extent_page
/* disk IO, might sleep */
submit_one_bioFix this by calling qgroup_dirty() on @dstqgroup, and update limit item in btrfs_run_qgroups() later.
By the way, add might_sleep() to some places.
ChenXiaoSong (2):
btrfs: add might_sleep() to some places in update_qgroup_limit_item()
btrfs: qgroup: fix sleep from invalid context bug in
update_qgroup_limit_item()
fs/btrfs/ctree.c | 4 ++++ fs/btrfs/qgroup.c | 9 +-------- 2 files changed, 5 insertions(+), 8 deletions(-)
Signature · 1 line
2.31.1