Rust core additions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest28 patches 17 repliesIn review
- v128 patches 39 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/28 | rust: prelude: split re-exports into groupsrust/ | +9 | 0 replies | |
| 2/28 | rust: print: add more `pr_*!` levelsrust/ rust/ | +155 | 0 replies | |
| 3/28 | rust: print: add `pr_cont!` macrorust/ | +63 | 0 replies | |
| 4/28 | rust: samples: add `rust_print` examplesamples/ samples/ samples/ | +65 | 0 replies | |
| 5/28 | rust: macros: add `concat_idents!` proc macrorust/ rust/ | +67 | 1 reply | |
| 6/28 | rust: macros: add `#[vtable]` proc macrorust/ rust/ rust/ | +148 | 2 replies | |
| 7/28 | rust: macros: take string literals in `module!`rust/ rust/ rust/ +2 more | +37 | 0 replies | |
| 8/28 | rust: error: declare errors using macrorust/ | +10 | 0 replies | |
| 9/28 | rust: error: add codes from `errno-base.h`rust/ | +33 | 1 reply | |
| 10/28 | rust: error: add `From` implementations for `Error`rust/ rust/ | +45 | 0 replies | |
| 11/28 | rust: prelude: add `error::code::*` constant itemsrust/ | +1 | 0 replies | |
| 12/28 | rust: alloc: add `RawVec::try_with_capacity_in()` constructorrust/ | +33 | 0 replies | |
| 13/28 | rust: alloc: add `Vec::try_with_capacity{,_in}()` constructorsrust/ rust/ | +89 | 1 reply | |
| 14/28 | rust: str: add `BStr` typerust/ | +5 | 0 replies | |
| 15/28 | rust: str: add `b_str!` macrorust/ | +21 | 0 replies | |
| 16/28 | rust: str: add `CStr` typerust/ rust/ | +170 | 0 replies | |
| 17/28 | rust: str: implement several traits for `CStr`rust/ | +123 | 0 replies | |
| 18/28 | rust: str: add `CStr` unit testsrust/ | +29 | 0 replies | |
| 19/28 | rust: str: add `c_str!` macrorust/ | +23 | 0 replies | |
| 20/28 | rust: str: add `Formatter` typerust/ | +57 | 3 replies | |
| 21/28 | rust: str: add `CString` typerust/ | +89 | 0 replies | |
| 22/28 | rust: str: add `fmt!` macrorust/ | +6 | 0 replies | |
| 23/28 | rust: std_vendor: add `dbg!` macro based on `std`'s onerust/ rust/ rust/ | +166 | 0 replies | |
| 24/28 | rust: static_assert: add `static_assert!` macrorust/ rust/ rust/ | +37 | 0 replies | |
| 25/28 | rust: add `build_error` cratelib/ rust/ rust/ +2 more | +76 | 1 reply | |
| 26/28 | rust: build_assert: add `build_{error,assert}!` macrosrust/ rust/ rust/ | +88 | 1 reply | |
| 27/28 | rust: types: add `Either` typerust/ rust/ | +13 | 6 replies | |
| 28/28 | rust: types: add `Opaque` typerust/ | +25 | 0 replies |
Reviews trailers per patch
17 of 28 patches have a Reviewed-by or Acked-by.
| Patch | Boqun Feng | Wei Liu | Sergio Gonzalez Collado | Finn Behrens | Gary Guo |
|---|---|---|---|---|---|
| 1/28 | R-b | R-b | |||
| 2/28 | R-b | R-b | R-b | ||
| 3/28 | R-b | R-b | |||
| 4/28 | R-b | T-b | R-b | ||
| 5/28 | R-b | R-b | |||
| 6/28 | R-b | R-b | |||
| 7/28 | |||||
| 8/28 | R-b | ||||
| 9/28 | R-b | R-b | |||
| 10/28 | R-b | ||||
| 11/28 | R-b | ||||
| 12/28 | R-b | ||||
| 13/28 | R-b | R-b | |||
| 14/28 | |||||
| 15/28 | |||||
| 16/28 | |||||
| 17/28 | |||||
| 18/28 | |||||
| 19/28 | |||||
| 20/28 | R-b | ||||
| 21/28 | |||||
| 22/28 | R-b | ||||
| 23/28 | |||||
| 24/28 | |||||
| 25/28 | R-b | ||||
| 26/28 | R-b | ||||
| 27/28 | R-b | ||||
| 28/28 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v2 00/28] Rust core additions
From: Miguel Ojeda <[email protected]>
This is v2 of the first batch of changes to upstream the rest of the Rust support. v1 is at:
https://lore.kernel.org/rust-for-linux/[email protected]/
I collected the tags and applied the agreed changes. The full diff follows (with respect to v1), since they are minor enough.
I will be applying the patches tomorrow, since v1 has had more than three weeks of review time.
rust/build_error.rs +13 -6
@@ -2,19 +2,26 @@//! Build-time error. //! -//! This crate provides a function `build_error`, which will panic in -//! compile-time if executed in const context, and will cause a build error -//! if not executed at compile time and the optimizer does not optimise away the -//! call. +//! This crate provides a [const function][const-functions] `build_error`, which will panic in +//! compile-time if executed in [const context][const-context], and will cause a build error +//! if not executed at compile time and the optimizer does not optimise away the call. //! //! It is used by `build_assert!` in the kernel crate, allowing checking of //! conditions that could be checked statically, but could not be enforced in -//! Rust yet (e.g. perform some checks in const functions, but those +//! Rust yet (e.g. perform some checks in [const functions][const-functions], but those //! functions could still be called in the runtime). +//! +//! For details on constant evaluation in Rust, please see the [Reference][const-eval]. +//! +//! [const-eval]: https://doc.rust-lang.org/reference/const_eval.html +//! [const-functions]: https://doc.rust-lang.org/reference/const_eval.html#const-functions +//! [const-context]: https://doc.rust-lang.org/reference/const_eval.html#const-context #![no_std] -/// Panics if executed in const context, or triggers a build error if not. +/// Panics if executed in [const context][const-context], or triggers a build error if not. +/// +/// [const-context]: https://doc.rust-lang.org/reference/const_eval.html#const-context #[inline(never)] #[cold] #[export_name = "rust_build_error" ]
rust/kernel/std_vendor.rs +6 -3
@@ -35,9 +35,12 @@/// This is useful when debugging issues that only occur in release /// builds or when debugging in release mode is significantly faster. /// -/// Note that the macro is intended as a debugging tool and therefore you -/// should avoid having uses of it in version control for long periods -/// (other than in tests and similar). +/// Note that the macro is intended as a temporary debugging tool to be +/// used during development. Therefore, avoid committing `dbg!` macro +/// invocations into the kernel tree. +/// +/// For debug output that is intended to be kept in the kernel tree, +/// use [`pr_debug`] and similar facilities instead. /// /// # Stability ///
rust/kernel/str.rs +4 -13
@@ -129,18 +129,6 @@ impl CStr {Ok (unsafe {Self ::from_bytes_with_nul_unchecked (bytes) }) } -/// Creates a [`CStr`] from a `[u8]`, panic if input is not valid. -/// -/// This function is only meant to be used by `c_str!` macro, so -/// crates using `c_str!` macro don't have to enable `const_panic` feature. -#[doc(hidden)] -pub const fn from_bytes_with_nul_unwrap (bytes: &[u8 ]) -> &Self { -match Self ::from_bytes_with_nul (bytes) { -Ok (v) => v, -Err (_) =>panic! ("string contains interior NUL" ), - } - } -/// Creates a [`CStr`] from a `[u8]` without performing any additional /// checks. ///
@@ -349,7 +337,10 @@ wheremacro_rules! c_str { ($str:expr) => {{const S : &str =concat! ($str ,"\0" ); -const C : &$crate::str ::CStr = $crate::str ::CStr ::from_bytes_with_nul_unwrap (S .as_bytes ()); +const C : &$crate::str ::CStr =match $crate::str ::CStr ::from_bytes_with_nul (S .as_bytes ()) { +Ok (v) => v, +Err (_) =>panic! ("string contains interior NUL" ), + };C }}; }
rust/macros/concat_idents.rs +1 -1
@@ -18,6 +18,6 @@ pub(crate) fn concat_idents(ts: TokenStream) -> TokenStream {assert_eq! (expect_punct (&mut it),',' );let b =expect_ident (&mut it);assert! (it.next ().is_none (),"only two idents can be concatenated" ); -let res =Ident ::new (&(a.to_string () + &b.to_string ()), b.span ()); +let res =Ident ::new (&format! ("{a}{b}" ), b.span ());TokenStream ::from_iter ([TokenTree ::Ident (res)]) }
Björn Roy Baron (1):
rust: macros: add concat_idents! proc macro
Finn Behrens (1):
rust: error: declare errors using macro
Gary Guo (9):
rust: macros: add #[vtable] proc macro
rust: macros: take string literals in module!
rust: str: add BStr type
rust: str: add b_str! macro
rust: str: add CStr type
rust: str: implement several traits for CStr
rust: str: add c_str! macro
rust: add build_error crate
rust: build_assert: add build_{error,assert}! macros
Miguel Ojeda (7):
rust: prelude: split re-exports into groups
rust: print: add more pr_*! levels
rust: print: add pr_cont! macro
rust: samples: add rust_print example
rust: alloc: add RawVec::try_with_capacity_in() constructor
rust: alloc: add Vec::try_with_capacity{,_in}() constructors
rust: static_assert: add static_assert! macro
Milan Landaverde (1):
rust: str: add CStr unit tests
Niklas Mohrin (1):
rust: std_vendor: add dbg! macro based on std's one
Viktor Garske (1):
rust: error: add codes from errno-base.h
Wedson Almeida Filho (7):
rust: error: add From implementations for Error
rust: prelude: add error::code::* constant items
rust: str: add Formatter type
rust: str: add CString type
rust: str: add fmt! macro
rust: types: add Either type
rust: types: add Opaque type
lib/Kconfig.debug | 16 + rust/Makefile | 22 +- rust/alloc/raw_vec.rs | 33 +- rust/alloc/vec/mod.rs | 89 +++++ rust/build_error.rs | 31 ++ rust/exports.c | 5 + rust/kernel/build_assert.rs | 82 +++++ rust/kernel/error.rs | 90 ++++- rust/kernel/lib.rs | 9 + rust/kernel/prelude.rs | 20 +- rust/kernel/print.rs | 214 +++++++++++- rust/kernel/static_assert.rs | 34 ++ rust/kernel/std_vendor.rs | 163 ++++++++++ rust/kernel/str.rs | 523 +++++++++++++++++++++++++++++- rust/kernel/types.rs | 37 +++ rust/macros/concat_idents.rs | 23 ++ rust/macros/helpers.rs | 24 +- rust/macros/lib.rs | 108 +++++- rust/macros/module.rs | 10 +- rust/macros/vtable.rs | 95 ++++++ samples/rust/Kconfig | 10 + samples/rust/Makefile | 1 + samples/rust/rust_minimal.rs | 8 +- samples/rust/rust_print.rs | 54 +++ scripts/generate_rust_analyzer.py | 8 +- 25 files changed, 1667 insertions(+), 42 deletions(-) create mode 100644 rust/build_error.rs create mode 100644 rust/kernel/build_assert.rs create mode 100644 rust/kernel/static_assert.rs create mode 100644 rust/kernel/std_vendor.rs create mode 100644 rust/kernel/types.rs create mode 100644 rust/macros/concat_idents.rs create mode 100644 rust/macros/vtable.rs create mode 100644 samples/rust/rust_print.rs
base-commit: f0c4d9fc9cc9462659728d168387191387e903cc
Signature · 1 line
2.38.1