Skip to content

x86: Fix racy accesses to MSI-X Control register

David Vrabel xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86/msi: consistently handle BAR mapping failures in MSI-X setupxen/arch/x86/msi.c+1 -111 reply
2/3x86/msi: remove return value from msi_set_mask_bit()xen/arch/x86/msi.c+9 -253 replies
3/3x86/pci: Fix racy accesses to MSI-X Control registerxen/arch/x86/include/asm/msi.h xen/arch/x86/msi.c xen/drivers/passthrough/msi.c+114 -1054 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] x86: Fix racy accesses to MSI-X Control register

The main patch in this series is 3/3 with some preparatory patches to simplify the implementation. To summarize:

Concurrent access the the MSI-X control register are not serialized with a suitable lock. For example, in msix_capability_init() access use the pcidevs_lock() but some calls to msi_set_mask_bit() use the interrupt descriptor lock.

This can lead to MSI-X being incorrectly disabled and subsequent failures due to msix_memory_decoded() calls that check for MSI-X being enabled.

David