CXL: Process event logs
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 38 repliesIn review
Changes from RFC v2 from the cover letter
Integrated Davidlohr's irq patch, allocate up to 16 vectors, and base
my irq support on modifications to that patch.
Smita
Check event status before reading each log.
Jonathan
Process more than 1 record at a time
Remove reserved fields
Steven
Prefix trace points with 'cxl_'
Davidlohr
PUll in his patch
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | cxl/pci: Add generic MSI-X/MSI irq supportdrivers/ drivers/ drivers/ | +41 | 4 replies | |
| 2/11 | cxl/mem: Implement Get Event Records commandMAINTAINERS drivers/ drivers/ +3 more | +280 | 10 replies | |
| 3/11 | cxl/mem: Implement Clear Event Records commanddrivers/ drivers/ include/ | +55 | 5 replies | |
| 4/11 | cxl/mem: Clear events on driver loaddrivers/ tools/ | +4 | 1 reply | |
| 5/11 | cxl/mem: Trace General Media Event Recorddrivers/ drivers/ include/ | +179 | 3 replies | |
| 6/11 | cxl/mem: Trace DRAM Event Recorddrivers/ drivers/ include/ | +130 | 1 reply | |
| 7/11 | cxl/mem: Trace Memory Module Event Recorddrivers/ drivers/ include/ | +186 | 6 replies | |
| 8/11 | cxl/mem: Wire up event interruptsdrivers/ drivers/ drivers/ +1 more | +217 | 4 replies | |
| 9/11 | cxl/test: Add generic mock eventsdrivers/ drivers/ tools/ +3 more | +286 | 2 replies | |
| 10/11 | cxl/test: Add specific eventstools/ | +70 | 1 reply | |
| 11/11 | cxl/test: Simulate event log overflowtools/ | +37 | 1 reply |
Reviews trailers per patch
9 of 11 patches have a Reviewed-by or Acked-by.
| Patch | Jonathan Cameron | Dave Jiang | Steven Rostedt (Google) |
|---|---|---|---|
| 1/11 | R-b | ||
| 2/11 | R-b | ||
| 3/11 | R-b | R-b | |
| 4/11 | R-b | R-b | |
| 5/11 | R-b | R-b | |
| 6/11 | R-b | R-b | |
| 7/11 | R-b | R-b | R-b |
| 8/11 | |||
| 9/11 | |||
| 10/11 | R-b | ||
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/11] CXL: Process event logs
From: Ira Weiny <[email protected]>
This code is well tested with the changes to Qemu I've made (See Below).
The series is in 5 parts:
0) Davidlohrs irq patch modified for 16 vectors
1) Base functionality
2) Parsing specific events (Dynamic Capacity Event Record is defered)
3) Event interrupt support
4) cxl-test infrastructure for basic tests
While I believe this entire series is ready to be merged I realize that the interrupt support may still have some discussion around it. Therefor parts 1, 2, and 4 could be merged without irq support as cxl-test provides testing for that. Interrupt testing requires Qemu but it too is fully tested and ready to go.
Changes from RFC v2
Integrated Davidlohr's irq patch, allocate up to 16 vectors, and base
my irq support on modifications to that patch.
Smita
Check event status before reading each log.
Jonathan
Process more than 1 record at a time
Remove reserved fields
Steven
Prefix trace points with 'cxl_'
Davidlohr
PUll in his patch
Changes from RFC v1
Add event irqs
General simplification of the code. Resolve field alignment questions Update to rev 3.0 for comments and structures Add reserved fields and output them
Event records inform the OS of various device events. Events are not needed for any kernel operation but various user level software will want to track events.
Add event reporting through the trace event mechanism. On driver load read and clear all device events.
Enable all event logs for interrupts and process each log on interrupt.
TESTING:
Testing of this was performed with additions to QEMU in the following repo:
https://github.com/weiny2/qemu/tree/ira-cxl-events-latest
Changes to this repo are not finalized yet so I'm not posting those patches right away. But there is enough functionality added to further test this.
1) event status register
2) additional event injection capabilities
3) Process more than 1 record at a time in Get/Clear mailbox commands
Davidlohr Bueso (1):
cxl/pci: Add generic MSI-X/MSI irq support
Ira Weiny (10):
cxl/mem: Implement Get Event Records command
cxl/mem: Implement Clear Event Records command
cxl/mem: Clear events on driver load
cxl/mem: Trace General Media Event Record
cxl/mem: Trace DRAM Event Record
cxl/mem: Trace Memory Module Event Record
cxl/mem: Wire up event interrupts
cxl/test: Add generic mock events
cxl/test: Add specific events
cxl/test: Simulate event log overflow
MAINTAINERS | 1 + drivers/cxl/core/mbox.c | 219 ++++++++++++++ drivers/cxl/cxl.h | 8 + drivers/cxl/cxlmem.h | 191 +++++++++++++ drivers/cxl/cxlpci.h | 6 + drivers/cxl/pci.c | 167 +++++++++++ include/trace/events/cxl.h | 487 ++++++++++++++++++++++++++++++++ include/uapi/linux/cxl_mem.h | 4 + tools/testing/cxl/test/Kbuild | 2 +- tools/testing/cxl/test/events.c | 329 +++++++++++++++++++++ tools/testing/cxl/test/events.h | 9 + tools/testing/cxl/test/mem.c | 35 +++ 12 files changed, 1457 insertions(+), 1 deletion(-) create mode 100644 include/trace/events/cxl.h create mode 100644 tools/testing/cxl/test/events.c create mode 100644 tools/testing/cxl/test/events.h
base-commit: aae703b02f92bde9264366c545e87cec451de471
Signature · 1 line
2.37.2