Skip to content

seccomp: add the synchronous mode for seccomp_unotify

Andrei Vagin io-uring lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/26 patches 20 repliesIn review
  2. v5 posting 1/26 patches 1 replySuperseded
  3. v46 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v3 posting 2/25 patches12 repliesSuperseded
v3 posting 1/25 patches3 repliesSuperseded

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6seccomp: don't use semaphore and wait_queue togetherkernel/seccomp.c+36 -50 replies
2/6sched: add WF_CURRENT_CPU and externise ttwukernel/sched/core.c kernel/sched/fair.c kernel/sched/sched.h+13 -77 replies
3/6sched: add a few helpers to wake up tasks on the current cpuinclude/linux/completion.h include/linux/swait.h include/linux/wait.h +4 more+33 -143 replies
4/6seccomp: add the synchronous mode for seccomp_unotifyinclude/uapi/linux/seccomp.h kernel/seccomp.c+33 -23 replies
5/6selftest/seccomp: add a new test for the sync mode of seccomp_user_notifytools/testing/selftests/seccomp/seccomp_bpf.c+55 -00 replies
6/6perf/benchmark: add a new benchmark for seccom_unotifytools/arch/x86/include/uapi/asm/unistd_32.h tools/arch/x86/include/uapi/asm/unistd_64.h tools/perf/bench/Build +3 more+177 -04 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPeter Zijlstra (Intel)Andrei VaginTycho Andersen
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v5 thread

Cover letter [PATCH 0/6 v5 RESEND] seccomp: add the synchronous mode for seccomp_unotify

seccomp_unotify allows more privileged processes do actions on behalf of less privileged processes.

In many cases, the workflow is fully synchronous. It means a target process triggers a system call and passes controls to a supervisor process that handles the system call and returns controls back to the target process. In this context, "synchronous" means that only one process is running and another one is waiting.

The new WF_CURRENT_CPU flag advises the scheduler to move the wakee to the current CPU. For such synchronous workflows, it makes context switches a few times faster.

Right now, each interaction takes 12µs. With this patch, it takes about 3µs.

v2: clean up the first patch and add the test.
v3: update commit messages and a few fixes suggested by Kees Cook.
v4: update the third patch to avoid code duplications (suggested by
Peter Zijlstra)
Add the benchmark to the perf bench set.
v5: Update the author email. No code changes.

Kees is ready to take this patch set, but wants to get Acks from the sched folks.

Cc Andy Lutomirski <[email protected]>
Cc Christian Brauner <[email protected]>
Cc Dietmar Eggemann <[email protected]>
Cc Kees Cook <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Juri Lelli <[email protected]>
Cc Peter Oskolkov <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Tycho Andersen <[email protected]>
Cc Will Drewry <[email protected]>
Cc Vincent Guittot <[email protected]>

Andrei Vagin (4):
seccomp: don't use semaphore and wait_queue together
sched: add a few helpers to wake up tasks on the current cpu
seccomp: add the synchronous mode for seccomp_unotify selftest/seccomp: add a new test for the sync mode of
seccomp_user_notify

Peter Oskolkov (1):
sched: add WF_CURRENT_CPU and externise ttwu

 include/linux/completion.h                    |   1 +
 include/linux/swait.h                         |   2 +-
 include/linux/wait.h                          |   3 +
 include/uapi/linux/seccomp.h                  |   4 +
 kernel/sched/completion.c                     |  26 ++-
 kernel/sched/core.c                           |   5 +-
 kernel/sched/fair.c                           |   4 +
 kernel/sched/sched.h                          |  13 +-
 kernel/sched/swait.c                          |   8 +-
 kernel/sched/wait.c                           |   5 +
 kernel/seccomp.c                              |  72 +++++++-
 tools/arch/x86/include/uapi/asm/unistd_32.h   |   3 +
 tools/arch/x86/include/uapi/asm/unistd_64.h   |   3 +
 tools/perf/bench/Build                        |   1 +
 tools/perf/bench/bench.h                      |   1 +
 tools/perf/bench/sched-seccomp-notify.c       | 167 ++++++++++++++++++
 tools/perf/builtin-bench.c                    |   1 +
 tools/testing/selftests/seccomp/seccomp_bpf.c |  55 ++++++
 18 files changed, 346 insertions(+), 28 deletions(-)
 create mode 100644 tools/perf/bench/sched-seccomp-notify.c
Signature · 1 line
2.37.2