filelock: WARN when @filp and fl_file don't match
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | lockd: set missing fl_flags field when retrieving argsfs/ fs/ | +2 | 0 replies | |
| 2/4 | lockd: ensure we use the correct file description when unlockingfs/ | +6 | 0 replies | |
| 3/4 | lockd: fix file selection in nlmsvc_cancel_blockedfs/ | +4 | 0 replies | |
| 4/4 | filelock: WARN_ON_ONCE when ->fl_file and filp don't matchfs/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] filelock: WARN when @filp and fl_file don't match
Eventually, I'd like to reduce the redundant arguments to the locking APIs, but to get there we need to ensure the callers all set their file locks sanely.
Adding the WARN_ON_ONCEs helped to find a couple of warts in lockd's file handling. The first 3 patches fix those.
I'd like to see these included in v6.2, with an eye toward a locking API cleanup in v6.3.
Thanks,
Jeff Layton (4):
lockd: set missing fl_flags field when retrieving args
lockd: ensure we use the correct file description when unlocking
lockd: fix file selection in nlmsvc_cancel_blocked
filelock: WARN_ON_ONCE when ->fl_file and filp don't match
fs/lockd/svc4proc.c | 1 + fs/lockd/svclock.c | 17 ++++++++++------- fs/lockd/svcproc.c | 1 + fs/locks.c | 3 +++ 4 files changed, 15 insertions(+), 7 deletions(-)
Signature · 1 line
2.38.1