Skip to content

DYNAMIC_DEBUG fixups for rc

Jim Cromie amd-gfx dri-devel intel-gfx lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm: mark drm.debug-on-dyndbg as BROKEN for nowdrivers/gpu/drm/Kconfig+1 -02 replies
2/7drm_print: fixup improve stale commentinclude/drm/drm_print.h+4 -10 replies
3/7test-dyndbg: fixup CLASSMAP usage errorlib/test_dynamic_debug.c+1 -10 replies
4/7test-dyndbg: show that DEBUG enables prdbgs at compiletimelib/test_dynamic_debug.c+2 -00 replies
5/7dyndbg: fix readback value on LEVEL_NAMES interfaceslib/dynamic_debug.c+2 -00 replies
6/7dyndbg: clone DECLARE_DYNDBG_CLASSMAP to REFERENCE_DYNDBG_CLASSMAPdrivers/gpu/drm/amd/amdgpu/amdgpu_drv.c drivers/gpu/drm/display/drm_dp_helper.c drivers/gpu/drm/drm_crtc_helper.c +3 more+15 -50 replies
7/7dyndbg: replace classmap list with a vectorlib/dynamic_debug.c+32 -290 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchGreg Kroah-Hartman
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] DYNAMIC_DEBUG fixups for rc

hi Jason, Greg, DRM-folk,

drm.debug-on-dyndbg has a regression due to a chicken-&-egg problem; drm.debug is applied to enable dyndbg callsites before the dependent modules' callsites are available to be enabled.

My "fixes" are unready, so lets just mark it BROKEN for now.

Meanwhile, heres some other fixes, a comment tweak, a proof of non-bug, an internal simplification, and a cleanup/improvement to the main macro (API):

Split DECLARE_DYNDBG_CLASSMAP in 1/2; REFERENCE_DYNDBG_CLASSMAP now refers to a classmap DECLARE'd just once. I think this gives a path away from the coordination-by-identical-classmaps "feature" that Jani and others thought was "weird" (my term).

Jim Cromie (7):
drm: mark drm.debug-on-dyndbg as BROKEN for now
drm_print: fixup improve stale comment
test-dyndbg: fixup CLASSMAP usage error
test-dyndbg: show that DEBUG enables prdbgs at compiletime
dyndbg: fix readback value on LEVEL_NAMES interfaces
dyndbg: clone DECLARE_DYNDBG_CLASSMAP to REFERENCE_DYNDBG_CLASSMAP
dyndbg: replace classmap list with a vector

 drivers/gpu/drm/Kconfig                 |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |  2 +-
 drivers/gpu/drm/display/drm_dp_helper.c |  2 +-
 drivers/gpu/drm/drm_crtc_helper.c       |  2 +-
 drivers/gpu/drm/i915/i915_params.c      |  2 +-
 drivers/gpu/drm/nouveau/nouveau_drm.c   |  2 +-
 include/drm/drm_print.h                 |  5 +-
 include/linux/dynamic_debug.h           | 10 ++++
 lib/dynamic_debug.c                     | 63 +++++++++++++------------
 lib/test_dynamic_debug.c                |  4 +-
 10 files changed, 57 insertions(+), 36 deletions(-)
Signature · 1 line
2.38.1