Skip to content

vdpa/mlx5: Add debugfs subtree and fixes

Eli Cohen lkml virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 8 repliesIn review
  2. v17 patches 17 repliesSuperseded

Changes in v2 from the cover letter

1. Reorder patches so fixes are first
2. Break "Fix rule forwarding VLAN to TIR" into two patches
3. Squash fix for bug in first patch from "Add RX counters to debugfs"
4. Move clearing of nb_registered before calling mlx5_notifier_unregister() in mlx5_vdpa_dev_del()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8vdpa/mlx5: Fix rule forwarding VLAN to TIRdrivers/vdpa/mlx5/net/mlx5_vnet.c+5 -30 replies
2/8vdpa/mlx5: Return error on vlan ctrl commands if not supporteddrivers/vdpa/mlx5/net/mlx5_vnet.c+3 -02 replies
3/8vdpa/mlx5: Fix wrong mac address deletiondrivers/vdpa/mlx5/net/mlx5_vnet.c+1 -10 replies
4/8vdpa/mlx5: Avoid using reslock in event_handlerdrivers/vdpa/mlx5/net/mlx5_vnet.c+4 -120 replies
5/8vdpa/mlx5: Avoid overwriting CVQ iotlbdrivers/vdpa/mlx5/core/mlx5_vdpa.h drivers/vdpa/mlx5/core/mr.c drivers/vdpa/mlx5/net/mlx5_vnet.c+39 -592 replies
6/8vdpa/mlx5: Move some definitions to a new header filedrivers/vdpa/mlx5/net/mlx5_vnet.c drivers/vdpa/mlx5/net/mlx5_vnet.h+56 -440 replies
7/8vdpa/mlx5: Add debugfs subtreedrivers/vdpa/mlx5/Makefile drivers/vdpa/mlx5/net/debug.c drivers/vdpa/mlx5/net/mlx5_vnet.c +1 more+87 -10 replies
8/8vdpa/mlx5: Add RX counters to debugfsdrivers/vdpa/Kconfig drivers/vdpa/mlx5/net/debug.c drivers/vdpa/mlx5/net/mlx5_vnet.c +1 more+217 -271 reply

Reviews trailers per patch

7 of 8 patches have a Reviewed-by or Acked-by.

PatchJason WangSi-Wei LiuEugenio Pérez
1/8A-b
2/8A-b A-b
3/8A-b
4/8
5/8A-b A-b
6/8A-b R-b
7/8A-b R-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATH v2 0/8] vdpa/mlx5: Add debugfs subtree and fixes

This series is a resend of previously sent patch list. It adds a few fixes so I treat as a v0 of a new series.

It adds a kernel config param CONFIG_MLX5_VDPA_STEERING_DEBUG that when eabled allows to read rx unicast and multicast counters per tagged or untagged traffic.

Examples:

$ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/mcast/packets
$ cat /sys/kernel/debug/mlx5/mlx5_core.sf.1/vdpa-0/rx/untagged/ucast/bytes

v1->v2:
1. Reorder patches so fixes are first
2. Break "Fix rule forwarding VLAN to TIR" into two patches
3. Squash fix for bug in first patch from "Add RX counters to debugfs"
4. Move clearing of nb_registered before calling mlx5_notifier_unregister() in mlx5_vdpa_dev_del()

Eli Cohen (8):
vdpa/mlx5: Fix rule forwarding VLAN to TIR vdpa/mlx5: Return error on vlan ctrl commands if not supported vdpa/mlx5: Fix wrong mac address deletion
vdpa/mlx5: Avoid using reslock in event_handler vdpa/mlx5: Avoid overwriting CVQ iotlb
vdpa/mlx5: Move some definitions to a new header file vdpa/mlx5: Add debugfs subtree
vdpa/mlx5: Add RX counters to debugfs

 drivers/vdpa/Kconfig               |  12 ++
 drivers/vdpa/mlx5/Makefile         |   2 +-
 drivers/vdpa/mlx5/core/mlx5_vdpa.h |   5 +-
 drivers/vdpa/mlx5/core/mr.c        |  44 ++---
 drivers/vdpa/mlx5/net/debug.c      | 152 ++++++++++++++++++
 drivers/vdpa/mlx5/net/mlx5_vnet.c  | 250 ++++++++++++++---------------
 drivers/vdpa/mlx5/net/mlx5_vnet.h  |  94 +++++++++++
 7 files changed, 412 insertions(+), 147 deletions(-)
 create mode 100644 drivers/vdpa/mlx5/net/debug.c
 create mode 100644 drivers/vdpa/mlx5/net/mlx5_vnet.h
Signature · 1 line
2.38.1