Skip to content

resource management using devlink reload

Michal Swiatkowski intel-wired-lan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 35 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13ice: move RDMA init to ice_idc.cdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_idc.c drivers/net/ethernet/intel/ice/ice_main.c+57 -250 replies
2/13ice: alloc id for RDMA using xa_arraydrivers/net/ethernet/intel/ice/ice_idc.c+6 -50 replies
3/13ice: cleanup in VSI config/deconfig codedrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_ethtool.c drivers/net/ethernet/intel/ice/ice_lib.c +2 more+26 -440 replies
4/13ice: split ice_vsi_setup into smaller functionsdrivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_lib.h drivers/net/ethernet/intel/ice/ice_main.c +1 more+301 -3682 replies
5/13ice: stop hard coding the ICE_VSI_CTRL locationdrivers/net/ethernet/intel/ice/ice_lib.c+15 -190 replies
6/13ice: split probe into smaller functionsdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_main.c+562 -3470 replies
7/13ice: sync netdev filters after clearing VSIdrivers/net/ethernet/intel/ice/ice_fltr.c+5 -00 replies
8/13ice: move VSI delete outside deconfigdrivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_lib.h drivers/net/ethernet/intel/ice/ice_main.c+14 -200 replies
9/13ice: update VSI instead of init in some casedrivers/net/ethernet/intel/ice/ice_lib.c drivers/net/ethernet/intel/ice/ice_lib.h drivers/net/ethernet/intel/ice/ice_main.c+13 -90 replies
10/13ice: implement devlink reinit actiondrivers/net/ethernet/intel/ice/ice_devlink.c+81 -220 replies
11/13ice: introduce eswitch capable flagdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_eswitch.c drivers/net/ethernet/intel/ice/ice_main.c+11 -10 replies
12/13ice, irdma: prepare reservation of MSI-X to reloaddrivers/infiniband/hw/irdma/main.c drivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_ethtool.c +3 more+189 -1312 replies
13/13devlink, ice: add MSIX vectors as devlink resourceDocumentation/networking/devlink/devlink-resource.rst drivers/net/ethernet/intel/ice/ice_devlink.c drivers/net/ethernet/intel/ice/ice_devlink.h +3 more+192 -24 replies

Reviews trailers per patch

2 of 13 patches have a Reviewed-by or Acked-by.

PatchDave ErtmanPrzemek Kitszel
1/13A-b
2/13
3/13
4/13
5/13
6/13R-b
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 00/13] resource management using devlink reload

Currently the default value for number of PF vectors is number of CPUs. Because of that there are cases when all vectors are used for PF and user can't create more VFs. It is hard to set default number of CPUs right for all different use cases. Instead allow user to choose how many vectors should be used for various features. After implementing subdevices this mechanism will be also used to set number of vectors for subfunctions.

The idea is to set vectors for eth or VFs using devlink resource API. New value of vectors will be used after devlink reinit. Example commands:

$ sudo devlink resource set pci/0000:31:00.0 path msix/msix_eth size 16
$ sudo devlink dev reload pci/0000:31:00.0
After reload driver will work with 16 vectors used for eth instead of
num_cpus.

The default number of queues is implicitly derived from interrupt vectors and can be later changed by ethtool.
To decrease queues used on eth user can decrease vectors on eth. The result will be the same. Still user can change number of queues using ethtool:

$ sudo ethtool -L enp24s0f0 tx 72 rx 72
but maximum queues amount is equal to amount of vectors.

Most of this patchset is about implementing driver reload mechanism. Part of code from probe and rebuild is used to not duplicate code. To allow this reuse probe and rebuild path are split into smaller functions.

Patch "ice: split ice_vsi_setup into smaller functions" changes boolean variable in function call to integer and adds define for it. Instead of having the function called with true/false now it can be called with readable defines ICE_VSI_FLAG_INIT or ICE_VSI_FLAG_NO_INIT. It was suggested by Jacob Keller and probably this mechanism will be implemented across ice driver in follow up patchset.

Patch 1 - 10 -> cleanup code to reuse most of the already
implemented function in reload path
Patch 11 -> implement devlink reload API
Patch 12 -> prepare interrupts reservation, make irdma see
changeable vectors count
Patch 13 -> changing number of vectors

Jacob Keller (1):
ice: stop hard coding the ICE_VSI_CTRL location

Michal Kubiak (1):
devlink, ice: add MSIX vectors as devlink resource

Michal Swiatkowski (11):
ice: move RDMA init to ice_idc.c
ice: alloc id for RDMA using xa_array
ice: cleanup in VSI config/deconfig code
ice: split ice_vsi_setup into smaller functions
ice: split probe into smaller functions
ice: sync netdev filters after clearing VSI
ice: move VSI delete outside deconfig
ice: update VSI instead of init in some case
ice: implement devlink reinit action
ice: introduce eswitch capable flag
ice, irdma: prepare reservation of MSI-X to reload

 .../networking/devlink/devlink-resource.rst   |   10 +
 drivers/infiniband/hw/irdma/main.c            |    2 +-
 drivers/net/ethernet/intel/ice/ice.h          |   23 +-
 drivers/net/ethernet/intel/ice/ice_common.c   |   11 +-
 drivers/net/ethernet/intel/ice/ice_devlink.c  |  263 +++-
 drivers/net/ethernet/intel/ice/ice_devlink.h  |    2 +
 drivers/net/ethernet/intel/ice/ice_eswitch.c  |    6 +
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |    6 +-
 drivers/net/ethernet/intel/ice/ice_fltr.c     |    5 +
 drivers/net/ethernet/intel/ice/ice_idc.c      |   57 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      |  789 +++++-----
 drivers/net/ethernet/intel/ice/ice_lib.h      |    8 +-
 drivers/net/ethernet/intel/ice/ice_main.c     | 1354 ++++++++++-------
 drivers/net/ethernet/intel/ice/ice_sriov.c    |    3 +-
 drivers/net/ethernet/intel/ice/ice_vf_lib.c   |    2 +-
 include/net/devlink.h                         |   14 +
 16 files changed, 1517 insertions(+), 1038 deletions(-)
Signature · 6 lines
2.36.1

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan