Skip to content

default driver params and phonetic spelling while arrowing

Mushahid Hussain lkml 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/22 patches 0 repliesNew
  2. v2 posting 1/22 patches 1 replySuperseded

Changes in v2 from the cover letter

- removed unnecessary lines

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2accessibility: speakup: Specify spk_vars among module parametersdrivers/accessibility/speakup/main.c+47 -130 replies
2/2accessibility: speakup: phonetic spelling while arrowing letter by letterDocumentation/ABI/stable/sysfs-driver-speakup drivers/accessibility/speakup/kobjects.c drivers/accessibility/speakup/main.c +3 more+26 -40 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSamuel Thibault
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 0/2] default driver params and phonetic spelling while arrowing

This patch series allows specifying default driver parameters for speakup as module parameters, and includes an additional parameter, cur_phonetic.

cur_phonetic is necessary to introduce an enhancement which allows speakup to speak letters phonetically, when a user arrows a word letter by letter. This functionality can be enabled by setting /sys/speakup/cur_phonetic to 1.

When cur_phonetic is set to 1, speakup will speak letters as phonetically when arrowing over a word.

This does not affect when a user is typing but only affects when a user is arrowing over a word.

When cur_phonetic is set to 0, speakup will work as before, it will speak letters normally when arrowing over them.

When a user does not set /sys/speakup/cur_phonetic to any value, the default value is 0.

Only accepted values for /sys/speakup/cur_phonetic are 1 and 0.

1. It indexes spk_vars by an enum and allows specifying spk_vars as module parameters.

2. It introduces a new variable cur_phonetic in spk_vars, allows specifying it as a module parameter as well. It also makes cur_phonetic accessible in sysfs at /sys/speakup/ as all other spk_vars. cur_phonetic can be used by users to enable phonetic annuncement of letters when navigated by the cursor.
It also documents the cur_phonetic in
/Documentation/ABI/stable/sysfs-driver-speakup.

since V1:
- removed unnecessary lines

Mushahid Hussain (2):
accessibility: speakup: Specify spk_vars among module parameters
accessibility: speakup: phonetic spelling while arrowing letter by
letter

 Documentation/ABI/stable/sysfs-driver-speakup |  9 +++
 drivers/accessibility/speakup/kobjects.c      |  3 +
 drivers/accessibility/speakup/main.c          | 72 +++++++++++++++----
 drivers/accessibility/speakup/speakup.h       |  1 +
 drivers/accessibility/speakup/spk_types.h     |  2 +-
 drivers/accessibility/speakup/varhandlers.c   |  1 +
 6 files changed, 72 insertions(+), 16 deletions(-)

--
2.38.1