Skip to content

x86/resctrl: Implement rename to help move containers' tasks

Peter Newman lkml 6 versions – Applied

Status from this message: The following commit has been merged into the x86/cache branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesApplied
  2. v53 patches 7 repliesSuperseded
  3. v43 patches 6 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches6 repliesSuperseded
v22 patches1 replySuperseded
v12 patches0 repliesSuperseded

Changes in v6 from the cover letter

- rebase to v6.3-rc7
- clarify changelog wording
- clarify error message for non-directory move
- remove unneeded parenthesis for checkpatch.pl --strict
- add Reviewed-By's from Reinette

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/3x86/resctrl: Factor rdtgroup lock for multi-file opsarch/x86/kernel/cpu/resctrl/rdtgroup.c+22 -130 replies
2/3x86/resctrl: Implement rename op for mon groupsarch/x86/kernel/cpu/resctrl/rdtgroup.c+128 -00 replies
3/3Documentation/x86: Documentation for MON group move featureDocumentation/x86/resctrl.rst+7 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchReinette ChatreBabu Moger
SeriesT-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] x86/resctrl: Implement rename to help move containers' tasks

Hi Reinette, Fenghua,

This patch series implements the solution Reinette suggested in the earlier RFD thread[1] for the problem of moving a container's tasks to a different control group on systems that don't provide enough CLOSIDs to give every container its own control group.

This patch series assumes that a MON group's CLOSID can simply be changed to that of a new parent CTRL_MON group. This is allowed on Intel and AMD, but not MPAM implementations. While we (Google) only foresee needing this functionality on Intel and AMD systems, this series should hopefully be a good starting point for supporting MPAM.

Thanks!
-Peter

Updates:

v6:
- rebase to v6.3-rc7
- clarify changelog wording
- clarify error message for non-directory move
- remove unneeded parenthesis for checkpatch.pl --strict
- add Reviewed-By's from Reinette

v5:
- rebase to v6.3-rc4
- dropped rdt_move_group_tasks() task filter patch
- code/comment clarifications and errno updates requested by Reinette
- added Documentation patch

v4:
- rebase to v6.2
- commit message updates suggested by Reinette
- replace rdt_move_one_task() patch with rdt_move_group_tasks() filter function patch
- prevent rename on files or renaming to "mon_groups"
- optimize simple rename case
- disallow renaming groups with non-empty cpumask
- ensure source is a proper MON group directory
- fix missing rdtgrp->closid update
- add more last_command_status output

v3: use revised task CLOSID/RMID update IPI sync method from [3]
v2: reworded change logs based on what I've learned from review comments
in another patch series[2]

[v1] https://lore.kernel.org/lkml/[email protected]/
[v2] https://lore.kernel.org/lkml/[email protected]/
[v3] https://lore.kernel.org/lkml/[email protected]/
[v4] https://lore.kernel.org/lkml/[email protected]/
[v5] https://lore.kernel.org/lkml/[email protected]/

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/
[3] https://lore.kernel.org/lkml/[email protected]/

Peter Newman (3):
x86/resctrl: Factor rdtgroup lock for multi-file ops x86/resctrl: Implement rename op for mon groups Documentation/x86: Documentation for MON group move feature

 Documentation/x86/resctrl.rst          |   7 ++
 arch/x86/kernel/cpu/resctrl/rdtgroup.c | 163 +++++++++++++++++++++++--
 2 files changed, 157 insertions(+), 13 deletions(-)

base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026

Signature · 1 line
2.40.0.634.g4ca3ef3211-goog