Skip to content

fs: fix inode->i_flctx accesses

Jeff Layton ceph-devel linux-cifs linux-fsdevel linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7filelock: add a new locks_inode_context accessor functionfs/locks.c include/linux/fs.h+24 -102 replies
2/7ceph: use locks_inode_context helperfs/ceph/locks.c+2 -22 replies
3/7cifs: use locks_inode_context helperfs/cifs/file.c+1 -11 reply
4/7ksmbd: use locks_inode_context helperfs/ksmbd/vfs.c+1 -12 replies
5/7lockd: use locks_inode_context helperfs/lockd/svcsubs.c+2 -21 reply
6/7nfs: use locks_inode_context helperfs/nfs/delegation.c fs/nfs/nfs4state.c fs/nfs/pagelist.c +1 more+5 -51 reply
7/7nfsd: use locks_inode_context helperfs/nfsd/nfs4state.c+3 -33 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchChuck LeverChristoph HellwigNamjae JeonXiubo Li
1/7R-b
2/7R-b R-b
3/7R-b
4/7R-b A-b
5/7R-b
6/7R-b
7/7A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] fs: fix inode->i_flctx accesses

The inode->i_flctx field is set via a cmpxchg operation, which is a release op. This means that most callers need to use an acquire to access it.

This series adds a new helper function for that, and replaces the existing accesses of i_flctx with that. The later patches then convert the various subsystems that access i_flctx directly to use the new helper.

Assuming there are no objectsions, I'll plan to merge this for v6.2 via my tree. If any maintainers want to take the subsystem patches in via their trees, let me know and we'll work it out.

Jeff Layton (7):
filelock: add a new locks_inode_context accessor function
ceph: use locks_inode_context helper
cifs: use locks_inode_context helper
ksmbd: use locks_inode_context helper
lockd: use locks_inode_context helper
nfs: use locks_inode_context helper
nfsd: use locks_inode_context helper

 fs/ceph/locks.c     |  4 ++--
 fs/cifs/file.c      |  2 +-
 fs/ksmbd/vfs.c      |  2 +-
 fs/lockd/svcsubs.c  |  4 ++--
 fs/locks.c          | 20 ++++++++++----------
 fs/nfs/delegation.c |  2 +-
 fs/nfs/nfs4state.c  |  2 +-
 fs/nfs/pagelist.c   |  2 +-
 fs/nfs/write.c      |  4 ++--
 fs/nfsd/nfs4state.c |  6 +++---
 include/linux/fs.h  | 14 ++++++++++++++
 11 files changed, 38 insertions(+), 24 deletions(-)
Signature · 1 line
2.38.1