drm: Fix the color-depth/bpp confusion
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 0 repliesNew
- v17 patches 14 repliesSuperseded
Changes in v2 from the cover letter
* leave out 15-bit color in logicvc (Javier)
* minor typos (Javier)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | drm/hisilicon/hibmc: Fix preferred depth and bppdrivers/ | +2 | 0 replies | |
| 2/7 | drm/logicvc: Fix preferred fbdev cppdrivers/ | +12 | 0 replies | |
| 3/7 | drm/cirrus: Decouple fbdev bpp value from color depthdrivers/ | +1 | 0 replies | |
| 4/7 | drm/ofdrm: Set preferred depth from format of scanout bufferdrivers/ | +1 | 0 replies | |
| 5/7 | drm/simpledrm: Set preferred depth from format of scanout bufferdrivers/ | +2 | 0 replies | |
| 6/7 | drm/solomon: Set preferred color depth and bpp to the correct valuesdrivers/ | +2 | 0 replies | |
| 7/7 | drm/fb-helper: Don't use the preferred depth for the BPP defaultdrivers/ | +9 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Javier Martinez Canillas | Daniel Vetter |
|---|---|---|
| 1/7 | R-b | A-b |
| 2/7 | R-b | A-b |
| 3/7 | R-b | A-b |
| 4/7 | R-b | A-b |
| 5/7 | R-b | A-b |
| 6/7 | R-b | A-b |
| 7/7 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] drm: Fix the color-depth/bpp confusion
A number of drivers mix up the meaning of bits-per-pixel and color depth. For each of them, set the correct values. As a rule of thumb, the color depth is the number of color and alpha bits that affect image composition. The bpp value is the color depth in the pixel plus the filler bits.
The color depth is exported to userspace, while the bpp value only affects fbdev emulation. Currently, fbdev fails if it selects a color format that is unsupported by the driver. The fix would be to fall back to a driver default value for the bpp. Getting the default fixed in drivers will then allow us to fix the fbdev format selection.
v2:
* leave out 15-bit color in logicvc (Javier)
* minor typos (Javier)
Thomas Zimmermann (7):
drm/hisilicon/hibmc: Fix preferred depth and bpp drm/logicvc: Fix preferred fbdev cpp
drm/cirrus: Decouple fbdev bpp value from color depth drm/ofdrm: Set preferred depth from format of scanout buffer drm/simpledrm: Set preferred depth from format of scanout buffer drm/solomon: Set preferred color depth and bpp to the correct values drm/fb-helper: Don't use the preferred depth for the BPP default
drivers/gpu/drm/drm_fbdev_generic.c | 15 +++++++++------ drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- drivers/gpu/drm/logicvc/logicvc_drm.c | 13 ++++++++++++- drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- drivers/gpu/drm/tiny/cirrus.c | 2 +- drivers/gpu/drm/tiny/ofdrm.c | 13 +------------ drivers/gpu/drm/tiny/simpledrm.c | 4 ++-- 7 files changed, 29 insertions(+), 26 deletions(-)
Signature · 6 lines
2.38.1 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization