Skip to content

AMD Pstate driver Urgent Change

Perry Yuan linux-pm lkml stable 3 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 4 repliesIn review
  2. v25 patches 0 repliesSuperseded
  3. v15 patches 12 repliesSuperseded

Changes in v3 from the cover letter

* pick up Acked-by flag of Huang Rui
* fix typo in the cover letter

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cpufreq: amd-pstate: cpufreq: amd-pstate: reset MSR_AMD_PERF_CTL register at initdrivers/cpufreq/amd-pstate.c+10 -00 replies
2/5cpufreq: amd-pstate: change amd-pstate driver to be built-in typedrivers/cpufreq/Kconfig.x86 drivers/cpufreq/amd-pstate.c+2 -110 replies
3/5cpufreq: amd-pstate: add amd-pstate driver parameter for mode selectiondrivers/cpufreq/amd-pstate.c+27 -90 replies
4/5Documentation: amd-pstate: add driver working mode introductionDocumentation/admin-guide/pm/amd-pstate.rst+13 -172 replies
5/5Documentation: add amd-pstate kernel command line optionsDocumentation/admin-guide/kernel-parameters.txt+11 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchHuang RuiGautham R. ShenoyWyes Karny
1/5A-b R-b T-b
2/5A-b R-b T-b
3/5A-b R-b T-b
4/5A-b R-b T-b
5/5A-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] AMD Pstate driver Urgent Change

The patchset changed amd-pstate driver as built-in type to resolve the driver loading sequence problem, otherwise the acpi-cpufreq driver will be loaded as the default cpufreq scaling driver instead of amd-pstate.

Some new kernel parameters are added to allow user to disable pstate driver and load driver with passive mode which use governors to do the frequency scaling control.

* amd_pstate=disabled or no parameters will not load pstate driver.
* amd_pstate=passive will load pstate driver with passive mode.

Set the amd_pstate driver disabled by default because of performance degradation on a number of AMD ASICs in the passive mode driver, especially the shared memory support processors.

EPP support for the amd_pstate driver is under review. With EPP support, the said performance issue is resolved. Once that gets upstream, the active mode amd_pstate_epp driver may be enabled by default.

Changes from v2:
* pick up Acked-by flag of Huang Rui
* fix typo in the cover letter

Changes from v1:
* fix commit info in v1 patch PATCH 4/5
* pick up Reviewed-by flag of Gautham R. Shenoy
* pick up Tested-by flag of Wyes Karny

v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/

Perry Yuan (4):
cpufreq: amd-pstate: change amd-pstate driver to be built-in type
cpufreq: amd-pstate: add amd-pstate driver parameter for mode
selection
Documentation: amd-pstate: add driver working mode introduction
Documentation: add amd-pstate kernel command line options

Wyes Karny (1):
cpufreq: amd-pstate: cpufreq: amd-pstate: reset MSR_AMD_PERF_CTL
register at init

 .../admin-guide/kernel-parameters.txt         | 11 +++++
 Documentation/admin-guide/pm/amd-pstate.rst   | 30 +++++-------
 drivers/cpufreq/Kconfig.x86                   |  2 +-
 drivers/cpufreq/amd-pstate.c                  | 49 +++++++++++++------
 4 files changed, 59 insertions(+), 33 deletions(-)
Signature · 1 line
2.25.1