Skip to content

Enclosure interface cleanups

Mariusz Tkaczyk lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v13 patches 8 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2misc: enclosure: remove get_active callbackdrivers/misc/enclosure.c include/linux/enclosure.h+1 -52 replies
2/2misc: enclosure: use DEVICE_ATTR_RW* macrosdrivers/misc/enclosure.c+38 -420 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDan WilliamsChristoph Hellwig
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] Enclosure interface cleanups

Hi Arnd,
While looking into adding Native PCIE Enclosure Management (NPEM) support behind the existing enclosure ABI, I noticed a few opportunities for cleanups.

Changes since v1[1] + internal review:
- Keep reporting the cached version of ecomp->active (Dan).
- Preserve cached values in ecomp, drop patch 2 (Dan).
- Add comment documenting cached ecomp->active (Dan).
- Move ATTRS macros close to appropriate _show and _store functions (Andy).
- Make comment shorter (Christoph).
- Update patch2 title (Christoph).

[1] https://lore.kernel.org/linux-pci/[email protected]/
[2] https://lore.kernel.org/linux-kernel/[email protected]/
Mariusz Tkaczyk (2):
misc: enclosure: remove get_active callback
misc: enclosure: update sysfs api

 drivers/misc/enclosure.c  | 84 ++++++++++++++++++---------------------
 include/linux/enclosure.h |  2 -
 2 files changed, 39 insertions(+), 47 deletions(-)
Signature · 1 line
2.26.2