Skip to content

tsnep: Throttle irq, rotten pkts, RX buffer alloc and ethtool_get_channels()

Gerhard Engleder netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tsnep: Throttle interruptsdrivers/net/ethernet/engleder/tsnep_hw.h drivers/net/ethernet/engleder/tsnep_main.c+13 -04 replies
2/4tsnep: Fix rotten packetsdrivers/net/ethernet/engleder/tsnep_main.c+58 -14 replies
3/4tsnep: Add ethtool get_channels supportdrivers/net/ethernet/engleder/tsnep_ethtool.c+12 -00 replies
4/4tsnep: Rework RX buffer allocationdrivers/net/ethernet/engleder/tsnep.h drivers/net/ethernet/engleder/tsnep_ethtool.c drivers/net/ethernet/engleder/tsnep_main.c+133 -690 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] tsnep: Throttle irq, rotten pkts, RX buffer alloc and ethtool_get_channels()

Collection of improvements found during development of XDP support. Hopefully the last patch series before the XDP support.

Fix of rotten packets increased CPU load and caused slight drop of iperf performance, because CPU load was already at 100% before. This performance drop is compensated with interrupt throttling, which makes sense anyway.

ethtool_get_channels() is needed for automatic TAPRIO configuration in combination with multiple queues.

Rework of RX buffer allocation is prework of XDP. It ensures that packets are only dropped if RX queue would otherwise run empty because of failed allocations. So it should reduce the number of dropped packets under low memory conditions.

Gerhard Engleder (4):
tsnep: Throttle interrupts
tsnep: Fix rotten packets
tsnep: Add ethtool get_channels support
tsnep: Rework RX buffer allocation

 drivers/net/ethernet/engleder/tsnep.h         |   4 +
 drivers/net/ethernet/engleder/tsnep_ethtool.c |  19 ++
 drivers/net/ethernet/engleder/tsnep_hw.h      |   7 +
 drivers/net/ethernet/engleder/tsnep_main.c    | 252 +++++++++++++-----
 4 files changed, 214 insertions(+), 68 deletions(-)
Signature · 1 line
2.30.2