Skip to content

Basic clock and reset support for StarFive JH7110 RISC-V SoC

Hal Feng linux-clk linux-devicetree linux-riscv lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest14 patches 41 repliesIn review

Changes in v2 from the cover letter · 17 lines

- Rebased on tag v6.1-rc5.
- Rewrote the clock and reset drivers using auxiliary bus framework, so patch 8, 9, 15 were dropped and all patches changed a lot. (by Stephen)
- Split Patch 14 into two patches. One is for factoring out the common JH71X0 code, the another one is for renaming. (by Stephen)
- Created a subdirectory for StarFive reset drivers.
- Factored out common JH71X0 reset code.
- Renamed the common clock and reset code from "*starfive*" or "*STARFIVE*" to "*jh71x0*" or "*JH71X0*".
- Combined JH7110 system and always-on clock DT binding headers in one file named "include/dt-bindings/clock/starfive-jh7110.h".
- Renamed clock definitions "JH7110_SYSCLK_PCLK2_MUX_FUNC_PCLK" and "JH7110_SYSCLK_U2_PCLK_MUX_PCLK" to "JH7110_SYSCLK_PCLK2_MUX_FUNC" and "JH7110_SYSCLK_PCLK2_MUX".
- Rewrote the DT bindings of clock and reset for using auxiliary bus.
- Registered an auxiliary device for reset controller in clock drivers.
- Changed clock names "CODAJ*" and "WAVE*" to "codaj*" and "wave*". Changed clock names "u2_pclk_mux_func_pclk" and "u2_pclk_mux_pclk" to "pclk2_mux_func" and "pclk2_mux".
- Changed the flags of clock apb0 and noc_bus_isp_axi to CLK_IS_CRITICAL as suggested by StarFive SDK group.
- Registered clock gmac0_gtxc as a gate clock instead of a div clock as suggested by StarFive SDK group.
- Changed the frequency of clock pll2_out to 1188MHz as suggested by StarFive SDK group.
- Fixed the bug that the clock JH7110_AONCLK_GMAC0_GTXCLK was not handled in JH7110 always-on clock driver.
- Registered the reset driver as an auxiliary driver.
- Reworded the commit messages.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14clk: starfive: Factor out common JH7100 and JH7110 codeMAINTAINERS drivers/clk/starfive/Kconfig drivers/clk/starfive/Makefile +3 more+343 -3272 replies
2/14clk: starfive: Rename "jh7100" to "jh71x0" for the common codedrivers/clk/starfive/clk-starfive-jh7100-audio.c drivers/clk/starfive/clk-starfive-jh7100.c drivers/clk/starfive/clk-starfive-jh7100.h +2 more+487 -4874 replies
3/14reset: Create subdirectory for StarFive driversMAINTAINERS drivers/reset/Kconfig drivers/reset/Makefile +3 more+14 -101 reply
4/14reset: starfive: Factor out common JH71X0 reset codedrivers/reset/starfive/Kconfig drivers/reset/starfive/Makefile drivers/reset/starfive/reset-starfive-jh7100.c +2 more+56 -1773 replies
5/14reset: starfive: Rename "jh7100" to "jh71x0" for the common codedrivers/reset/starfive/reset-starfive-jh7100.c drivers/reset/starfive/reset-starfive-jh71x0.c drivers/reset/starfive/reset-starfive-jh71x0.h+27 -270 replies
6/14reset: starfive: jh71x0: Use 32bit I/O on 32bit registersdrivers/reset/starfive/reset-starfive-jh7100.c drivers/reset/starfive/reset-starfive-jh71x0.c drivers/reset/starfive/reset-starfive-jh71x0.h+23 -240 replies
7/14dt-bindings: clock: Add StarFive JH7110 system and always-on clock definitionsMAINTAINERS include/dt-bindings/clock/starfive-jh7110.h+237 -25 replies
8/14dt-bindings: reset: Add StarFive JH7110 system and always-on reset definitionsMAINTAINERS include/dt-bindings/reset/starfive-jh7110.h+157 -25 replies
9/14dt-bindings: clock: Add StarFive JH7110 system clock and reset generatorDocumentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml MAINTAINERS+81 -112 replies
10/14dt-bindings: clock: Add StarFive JH7110 always-on clock and reset generatorDocumentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml+76 -03 replies
11/14clk: starfive: Add StarFive JH7110 system clock driverdrivers/clk/starfive/Kconfig drivers/clk/starfive/Makefile drivers/clk/starfive/clk-starfive-jh7110-sys.c +2 more+725 -12 replies
12/14clk: starfive: Add StarFive JH7110 always-on clock driverdrivers/clk/starfive/Kconfig drivers/clk/starfive/Makefile drivers/clk/starfive/clk-starfive-jh7110-aon.c+176 -00 replies
13/14reset: starfive: Add StarFive JH7110 reset driverdrivers/reset/starfive/Kconfig drivers/reset/starfive/Makefile drivers/reset/starfive/reset-starfive-jh7110.c +1 more+83 -02 replies
14/14clk: starfive: jh71x0: Don't register aux devices if JH7110 reset is disableddrivers/clk/starfive/clk-starfive-jh71x0.c+10 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/14] Basic clock and reset support for StarFive JH7110 RISC-V SoC

The original patch series "Basic StarFive JH7110 RISC-V SoC support" [1] is split into 3 patch series. They respectively add basic clock&reset, pinctrl and device tree support for StarFive JH7110 SoC. These patch series are independent, but the Visionfive2 board can boot up successfully only if all these patches series applied. This one adds basic clock&reset support. This patch series is pulled out from the patch 7~21 of v1 [1]. You can simply get or review the patches at the link [2].

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://github.com/hal-feng/linux/commits/visionfive2-minimal

Changes since v1:
- Rebased on tag v6.1-rc5.
- Rewrote the clock and reset drivers using auxiliary bus framework, so patch 8, 9, 15 were dropped and all patches changed a lot. (by Stephen)
- Split Patch 14 into two patches. One is for factoring out the common JH71X0 code, the another one is for renaming. (by Stephen)
- Created a subdirectory for StarFive reset drivers.
- Factored out common JH71X0 reset code.
- Renamed the common clock and reset code from "*starfive*" or "*STARFIVE*" to "*jh71x0*" or "*JH71X0*".
- Combined JH7110 system and always-on clock DT binding headers in one file named "include/dt-bindings/clock/starfive-jh7110.h".
- Renamed clock definitions "JH7110_SYSCLK_PCLK2_MUX_FUNC_PCLK" and "JH7110_SYSCLK_U2_PCLK_MUX_PCLK" to "JH7110_SYSCLK_PCLK2_MUX_FUNC" and "JH7110_SYSCLK_PCLK2_MUX".
- Rewrote the DT bindings of clock and reset for using auxiliary bus.
- Registered an auxiliary device for reset controller in clock drivers.
- Changed clock names "CODAJ*" and "WAVE*" to "codaj*" and "wave*". Changed clock names "u2_pclk_mux_func_pclk" and "u2_pclk_mux_pclk" to "pclk2_mux_func" and "pclk2_mux".
- Changed the flags of clock apb0 and noc_bus_isp_axi to CLK_IS_CRITICAL as suggested by StarFive SDK group.
- Registered clock gmac0_gtxc as a gate clock instead of a div clock as suggested by StarFive SDK group.
- Changed the frequency of clock pll2_out to 1188MHz as suggested by StarFive SDK group.
- Fixed the bug that the clock JH7110_AONCLK_GMAC0_GTXCLK was not handled in JH7110 always-on clock driver.
- Registered the reset driver as an auxiliary driver.
- Reworded the commit messages.

v1: https://lore.kernel.org/all/[email protected]/

Emil Renner Berthing (10):
clk: starfive: Factor out common JH7100 and JH7110 code
reset: Create subdirectory for StarFive drivers
reset: starfive: Factor out common JH71X0 reset code
reset: starfive: jh71x0: Use 32bit I/O on 32bit registers
dt-bindings: clock: Add StarFive JH7110 system and always-on clock
definitions
dt-bindings: reset: Add StarFive JH7110 system and always-on reset
definitions
dt-bindings: clock: Add StarFive JH7110 system clock and reset
generator
dt-bindings: clock: Add StarFive JH7110 always-on clock and reset
generator
clk: starfive: Add StarFive JH7110 system clock driver
clk: starfive: Add StarFive JH7110 always-on clock driver

Hal Feng (4):
clk: starfive: Rename "jh7100" to "jh71x0" for the common code
reset: starfive: Rename "jh7100" to "jh71x0" for the common code
reset: starfive: Add StarFive JH7110 reset driver
clk: starfive: jh71x0: Don't register aux devices if JH7110 reset is
disabled

 .../clock/starfive,jh7110-aoncrg.yaml         |  76 ++
 .../clock/starfive,jh7110-syscrg.yaml         |  80 ++
 MAINTAINERS                                   |  16 +-
 drivers/clk/starfive/Kconfig                  |  25 +
 drivers/clk/starfive/Makefile                 |   6 +-
 .../clk/starfive/clk-starfive-jh7100-audio.c  |  74 +-
 drivers/clk/starfive/clk-starfive-jh7100.c    | 713 +++++-------------
 drivers/clk/starfive/clk-starfive-jh7100.h    | 112 ---
 .../clk/starfive/clk-starfive-jh7110-aon.c    | 165 ++++
 .../clk/starfive/clk-starfive-jh7110-sys.c    | 650 ++++++++++++++++
 drivers/clk/starfive/clk-starfive-jh71x0.c    | 396 ++++++++++
 drivers/clk/starfive/clk-starfive-jh71x0.h    | 122 +++
 drivers/reset/Kconfig                         |   8 +-
 drivers/reset/Makefile                        |   2 +-
 drivers/reset/reset-starfive-jh7100.c         | 173 -----
 drivers/reset/starfive/Kconfig                |  20 +
 drivers/reset/starfive/Makefile               |   5 +
 .../reset/starfive/reset-starfive-jh7100.c    |  74 ++
 .../reset/starfive/reset-starfive-jh7110.c    |  67 ++
 .../reset/starfive/reset-starfive-jh71x0.c    | 130 ++++
 .../reset/starfive/reset-starfive-jh71x0.h    |  21 +
 include/dt-bindings/clock/starfive-jh7110.h   | 234 ++++++
 include/dt-bindings/reset/starfive-jh7110.h   | 154 ++++
 23 files changed, 2466 insertions(+), 857 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-aoncrg.yaml
 create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml
 delete mode 100644 drivers/clk/starfive/clk-starfive-jh7100.h
 create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-aon.c
 create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-sys.c
 create mode 100644 drivers/clk/starfive/clk-starfive-jh71x0.c
 create mode 100644 drivers/clk/starfive/clk-starfive-jh71x0.h
 delete mode 100644 drivers/reset/reset-starfive-jh7100.c
 create mode 100644 drivers/reset/starfive/Kconfig
 create mode 100644 drivers/reset/starfive/Makefile
 create mode 100644 drivers/reset/starfive/reset-starfive-jh7100.c
 create mode 100644 drivers/reset/starfive/reset-starfive-jh7110.c
 create mode 100644 drivers/reset/starfive/reset-starfive-jh71x0.c
 create mode 100644 drivers/reset/starfive/reset-starfive-jh71x0.h
 create mode 100644 include/dt-bindings/clock/starfive-jh7110.h
 create mode 100644 include/dt-bindings/reset/starfive-jh7110.h

base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa

Signature · 7 lines
2.38.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv