serial: qcom-geni-serial: implement support for SE DMA
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest14 patches 2 repliesIn review
- v514 patches 1 replySuperseded
- v413 patches 3 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 13 patches | 5 replies | Superseded | |
| v2 | 15 patches | 2 replies | Superseded | |
| v1 | 15 patches | 16 replies | Superseded |
Changes in v6 from the cover letter
- move patch 12/14 to the front of the series and mark it as a fix
- rebase on top of v6.2-rc1 (there were some updates to the driver)
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/14 | tty: serial: qcom-geni-serial: stop operations in progress at shutdowndrivers/ | +2 | 0 replies | |
| 2/14 | tty: serial: qcom-geni-serial: drop unneeded forward definitionsdrivers/ | +37 | 0 replies | |
| 3/14 | tty: serial: qcom-geni-serial: remove unused symbolsdrivers/ | +0 | 0 replies | |
| 4/14 | tty: serial: qcom-geni-serial: align #define valuesdrivers/ | +31 | 0 replies | |
| 5/14 | tty: serial: qcom-geni-serial: improve the to_dev_port() macrodrivers/ | +19 | 0 replies | |
| 6/14 | tty: serial: qcom-geni-serial: remove stray newlinesdrivers/ | +0 | 0 replies | |
| 7/14 | tty: serial: qcom-geni-serial: refactor qcom_geni_serial_isr()drivers/ | +4 | 0 replies | |
| 8/14 | tty: serial: qcom-geni-serial: remove unneeded tabsdrivers/ | +12 | 0 replies | |
| 9/14 | tty: serial: qcom-geni-serial: split out the FIFO tx codedrivers/ | +33 | 0 replies | |
| 10/14 | tty: serial: qcom-geni-serial: refactor qcom_geni_serial_send_chunk_fifo()drivers/ | +10 | 0 replies | |
| 11/14 | tty: serial: qcom-geni-serial: drop the return value from handle_rxdrivers/ | +6 | 0 replies | |
| 12/14 | tty: serial: qcom-geni-serial: use of_device_id datadrivers/ | +34 | 0 replies | |
| 13/14 | soc: qcom-geni-se: add more symbol definitionsinclude/ | +3 | 0 replies | |
| 14/14 | tty: serial: qcom-geni-serial: add support for serial engine DMAdrivers/ | +255 | 0 replies |
Reviews trailers per patch
11 of 14 patches have a Reviewed-by or Acked-by.
| Patch | Konrad Dybcio | Ilpo Järvinen |
|---|---|---|
| 1/14 | R-b | |
| 2/14 | R-b | |
| 3/14 | R-b | |
| 4/14 | R-b | |
| 5/14 | R-b | |
| 6/14 | R-b | |
| 7/14 | R-b | R-b |
| 8/14 | R-b | |
| 9/14 | ||
| 10/14 | ||
| 11/14 | R-b | |
| 12/14 | R-b | |
| 13/14 | R-b | |
| 14/14 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v6 00/14] serial: qcom-geni-serial: implement support for SE DMA
From: Bartosz Golaszewski <[email protected]>
The goal of this series is to update the qcom-geni-serial driver to use the DMA mode of the QUPv3 serial engine. This is accomplished by the last patch in the series. The previous ones contain either various tweaks, reworks and refactoring or prepare the driver for adding DMA support.
More work will follow on the serial engine in order to reduce code redundancy among its users and add support for SE DMA to the qcom GENI SPI driver.
v5 -> v6:
- move patch 12/14 to the front of the series and mark it as a fix
- rebase on top of v6.2-rc1 (there were some updates to the driver)
v4 -> v5:
- split patch 8/13 into two: one for splitting out the chunk sending code and one for refactoring it (for easier review)
- when stopping uart: disable the irq first before stopping transfers in progress, otherwise we rist rescheduling additional transfers after interrupt
- make types even nore consistent in qcom_geni_serial_send_chunk_fifo()
v3 -> v4:
- don't assign NULL (even cast) to variables of type dma_addr_t
- refactor checking the SE_GENI_STATUS into two inline functions
- drop min_t() in favor of regular min() after adding some consistency to types
- check if the abort command was successful and emit a message if not when stopping TX in DMA mode
v2 -> v3:
- drop devres patches from the series
v1 -> v2:
- turn to_dev_uport() macro into a static inline function
- use CIRC_CNT_TO_END() and uart_xmit_advance() where applicable and don't handle xmit->tail directly
- drop sizeof() where BYTES_PER_FIFO_WORD can be used
- further refactor qcom_geni_serial_handle_tx_fifo()
- collect review tags
Bartosz Golaszewski (14):
tty: serial: qcom-geni-serial: stop operations in progress at shutdown
tty: serial: qcom-geni-serial: drop unneeded forward definitions
tty: serial: qcom-geni-serial: remove unused symbols
tty: serial: qcom-geni-serial: align #define values
tty: serial: qcom-geni-serial: improve the to_dev_port() macro
tty: serial: qcom-geni-serial: remove stray newlines
tty: serial: qcom-geni-serial: refactor qcom_geni_serial_isr()
tty: serial: qcom-geni-serial: remove unneeded tabs
tty: serial: qcom-geni-serial: split out the FIFO tx code
tty: serial: qcom-geni-serial: refactor
qcom_geni_serial_send_chunk_fifo()
tty: serial: qcom-geni-serial: drop the return value from handle_rx
tty: serial: qcom-geni-serial: use of_device_id data
soc: qcom-geni-se: add more symbol definitions
tty: serial: qcom-geni-serial: add support for serial engine DMA
drivers/tty/serial/qcom_geni_serial.c | 626 +++++++++++++++++--------- include/linux/qcom-geni-se.h | 3 + 2 files changed, 413 insertions(+), 216 deletions(-)
Signature · 1 line
2.37.2