Skip to content

serial: qcom-geni-serial: implement support for SE DMA

Bartosz Golaszewski linux-arm-msm linux-serial lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest14 patches 2 repliesIn review
  2. v514 patches 1 replySuperseded
  3. v413 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v313 patches5 repliesSuperseded
v215 patches2 repliesSuperseded
v115 patches16 repliesSuperseded

Changes in v6 from the cover letter

- move patch 12/14 to the front of the series and mark it as a fix
- rebase on top of v6.2-rc1 (there were some updates to the driver)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14tty: serial: qcom-geni-serial: stop operations in progress at shutdowndrivers/tty/serial/qcom_geni_serial.c+2 -00 replies
2/14tty: serial: qcom-geni-serial: drop unneeded forward definitionsdrivers/tty/serial/qcom_geni_serial.c+37 -420 replies
3/14tty: serial: qcom-geni-serial: remove unused symbolsdrivers/tty/serial/qcom_geni_serial.c+0 -150 replies
4/14tty: serial: qcom-geni-serial: align #define valuesdrivers/tty/serial/qcom_geni_serial.c+31 -310 replies
5/14tty: serial: qcom-geni-serial: improve the to_dev_port() macrodrivers/tty/serial/qcom_geni_serial.c+19 -170 replies
6/14tty: serial: qcom-geni-serial: remove stray newlinesdrivers/tty/serial/qcom_geni_serial.c+0 -20 replies
7/14tty: serial: qcom-geni-serial: refactor qcom_geni_serial_isr()drivers/tty/serial/qcom_geni_serial.c+4 -60 replies
8/14tty: serial: qcom-geni-serial: remove unneeded tabsdrivers/tty/serial/qcom_geni_serial.c+12 -120 replies
9/14tty: serial: qcom-geni-serial: split out the FIFO tx codedrivers/tty/serial/qcom_geni_serial.c+33 -270 replies
10/14tty: serial: qcom-geni-serial: refactor qcom_geni_serial_send_chunk_fifo()drivers/tty/serial/qcom_geni_serial.c+10 -180 replies
11/14tty: serial: qcom-geni-serial: drop the return value from handle_rxdrivers/tty/serial/qcom_geni_serial.c+6 -80 replies
12/14tty: serial: qcom-geni-serial: use of_device_id datadrivers/tty/serial/qcom_geni_serial.c+34 -120 replies
13/14soc: qcom-geni-se: add more symbol definitionsinclude/linux/qcom-geni-se.h+3 -00 replies
14/14tty: serial: qcom-geni-serial: add support for serial engine DMAdrivers/tty/serial/qcom_geni_serial.c+255 -590 replies

Reviews trailers per patch

11 of 14 patches have a Reviewed-by or Acked-by.

PatchKonrad DybcioIlpo Järvinen
1/14R-b
2/14R-b
3/14R-b
4/14R-b
5/14R-b
6/14R-b
7/14R-b R-b
8/14R-b
9/14
10/14
11/14R-b
12/14R-b
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 00/14] serial: qcom-geni-serial: implement support for SE DMA

From: Bartosz Golaszewski <[email protected]>

The goal of this series is to update the qcom-geni-serial driver to use the DMA mode of the QUPv3 serial engine. This is accomplished by the last patch in the series. The previous ones contain either various tweaks, reworks and refactoring or prepare the driver for adding DMA support.

More work will follow on the serial engine in order to reduce code redundancy among its users and add support for SE DMA to the qcom GENI SPI driver.

v5 -> v6:
- move patch 12/14 to the front of the series and mark it as a fix
- rebase on top of v6.2-rc1 (there were some updates to the driver)

v4 -> v5:
- split patch 8/13 into two: one for splitting out the chunk sending code and one for refactoring it (for easier review)
- when stopping uart: disable the irq first before stopping transfers in progress, otherwise we rist rescheduling additional transfers after interrupt
- make types even nore consistent in qcom_geni_serial_send_chunk_fifo()

v3 -> v4:
- don't assign NULL (even cast) to variables of type dma_addr_t
- refactor checking the SE_GENI_STATUS into two inline functions
- drop min_t() in favor of regular min() after adding some consistency to types
- check if the abort command was successful and emit a message if not when stopping TX in DMA mode

v2 -> v3:
- drop devres patches from the series

v1 -> v2:
- turn to_dev_uport() macro into a static inline function
- use CIRC_CNT_TO_END() and uart_xmit_advance() where applicable and don't handle xmit->tail directly
- drop sizeof() where BYTES_PER_FIFO_WORD can be used
- further refactor qcom_geni_serial_handle_tx_fifo()
- collect review tags

Bartosz Golaszewski (14):
tty: serial: qcom-geni-serial: stop operations in progress at shutdown
tty: serial: qcom-geni-serial: drop unneeded forward definitions
tty: serial: qcom-geni-serial: remove unused symbols
tty: serial: qcom-geni-serial: align #define values
tty: serial: qcom-geni-serial: improve the to_dev_port() macro
tty: serial: qcom-geni-serial: remove stray newlines
tty: serial: qcom-geni-serial: refactor qcom_geni_serial_isr()
tty: serial: qcom-geni-serial: remove unneeded tabs
tty: serial: qcom-geni-serial: split out the FIFO tx code
tty: serial: qcom-geni-serial: refactor
qcom_geni_serial_send_chunk_fifo()
tty: serial: qcom-geni-serial: drop the return value from handle_rx
tty: serial: qcom-geni-serial: use of_device_id data
soc: qcom-geni-se: add more symbol definitions
tty: serial: qcom-geni-serial: add support for serial engine DMA

 drivers/tty/serial/qcom_geni_serial.c | 626 +++++++++++++++++---------
 include/linux/qcom-geni-se.h          |   3 +
 2 files changed, 413 insertions(+), 216 deletions(-)
Signature · 1 line
2.37.2