Skip to content

DC Patches November 19, 2022

brichang amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest22 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22drm/amd/display: new ABM config 2drivers/gpu/drm/amd/display/modules/power/power_helpers.c+9 -00 replies
2/22drm/amd/display: Add margin on DRR vblank start for subvpdrivers/gpu/drm/amd/display/dc/core/dc.c drivers/gpu/drm/amd/display/dc/dc.h drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c +4 more+24 -30 replies
3/22drm/amd/display: No display after resume from WB/CBdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+36 -00 replies
4/22drm/amd/display: Limit HW cursor size of >= 4kdrivers/gpu/drm/amd/display/dc/core/dc_stream.c drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c+16 -40 replies
5/22drm/amd/display: Update Z8 watermarks for DCN314drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c+2 -20 replies
6/22drm/amd/display: Add Z8 allow states to z-state support listdrivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_smu.c drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c drivers/gpu/drm/amd/display/dc/dc.h +1 more+23 -70 replies
7/22drm/amd/display: Update soc bounding box for dcn32/dcn321drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c drivers/gpu/drm/amd/display/dc/dml/dcn321/dcn321_fpu.c+7 -70 replies
8/22drm/amd/display: Use dummy pstate latency for subvp when needed on dcn32drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c+49 -120 replies
9/22drm/amd/display: Add check for DET fetch latency hiding for dcn32drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.h +1 more+128 -00 replies
10/22drm/amd/display: Check if PSR enabled when entering MALLdrivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c+13 -30 replies
11/22drm/amd/display: Use viewport height for subvp mall allocation sizedrivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource_helpers.c+1 -10 replies
12/22drm/amd/display: Add YCBCR2020 coefficients to CSC matrixdrivers/gpu/drm/amd/display/dc/inc/hw/dpp.h+7 -20 replies
13/22drm/amd/display: Phase 1 Add Bw Allocation source and header filesdrivers/gpu/drm/amd/display/dc/dc_link.h drivers/gpu/drm/amd/display/dc/link/link_dp_dpia_bw.c drivers/gpu/drm/amd/display/dc/link/link_dp_dpia_bw.h+111 -00 replies
14/22drm/amd/display: No display after resume from WB/CB[modify]drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c+5 -40 replies
15/22drm/amd/display: Add debug options for increasing phantom linesdrivers/gpu/drm/amd/display/dc/dc.h drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c+4 -00 replies
16/22drm/amd/display: Retain phantom plane/stream if validation failsdrivers/gpu/drm/amd/display/dc/core/dc.c drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.h +2 more+40 -00 replies
17/22drm/amd/display: Fix display corruption w/ VSR enabledrivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c+1 -10 replies
18/22drm/amd/display: Avoid setting pixel rate divider to N/Adrivers/gpu/drm/amd/display/dc/dcn314/dcn314_dccg.c drivers/gpu/drm/amd/display/dc/dcn314/dcn314_hwseq.c drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c +1 more+13 -80 replies
19/22drm/amd/display: Use new num clk levels struct for max mclk indexdrivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c+1 -10 replies
20/22drm/amd/display: Revert check for phantom BPPdrivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c+1 -10 replies
21/22drm/amd/display: Fix rotated cursor offset calculationdrivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c drivers/gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c+64 -300 replies
22/22SWDEV-1 - dc: 3.2.213drivers/gpu/drm/amd/display/dc/dc.h+1 -12 replies

Reviews trailers per patch

21 of 22 patches have a Reviewed-by or Acked-by.

PatchJosip PavicBrian ChangJun LeiJerry ZuoAlvin LeeNawwar AliWenjing LiuMartin LeungDillon VaroneNevenko StuparNicholas Kazlauskas
1/22R-b A-b
2/22A-b R-b
3/22A-b R-b
4/22A-b R-b
5/22A-b R-b
6/22A-b R-b
7/22A-b R-b
8/22A-b R-b
9/22A-b R-b R-b
10/22A-b R-b
11/22A-b R-b R-b
12/22A-b R-b
13/22A-b R-b R-b
14/22A-b R-b
15/22A-b R-b R-b
16/22A-b R-b
17/22A-b R-b
18/22A-b R-b
19/22A-b R-b
20/22A-b R-b R-b
21/22A-b R-b
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v1 thread

Cover letter [PATCH 00/22] DC Patches November 19, 2022

This DC patchset brings improvements in multiple areas. In summary, we highlight:

*Add configuration 2 for ABM 2.3/2.4.
*Add margin for HUBP for SubVp + DRR.
*Fix no display after resume from WB/CB.
*Limit HW cursor size to be less than 64 x 64 bytes when the stream is >= 4K. *Lower watermarks for enter/enter+exit latency.
*Update support types for DCN314 to include z8 only and z8_z10 only state. *Add new value for soc bounding box and dummy pstate.
*Override fclk chang latency when calculating prefetch schedule for subvp with low uclk. *Add check for DET fetch latency for dcn32.
*Add check if PSR enabled when entering MALL.
*Use base MALL allocation size calculations off vewport height.
*Add YCBCR2020 to CSC matrix.
*Implement DP-Tx portion to interact with DPIA.
*Add debug option for increasing phantom lines.
*Fix phantom plane/stream retain after fail validation.
*Fix display corruption with VSR enable.
*Set valid divider value for virtual and FRL/DP2.
*Add new num clk levels struct for max mclk index.
*Fix check for phantom BPP.

Cc Daniel Wheeler <[email protected]>

Alvin Lee (5):
drm/amd/display: Limit HW cursor size of >= 4k drm/amd/display: Check if PSR enabled when entering MALL drm/amd/display: Add debug options for increasing phantom lines drm/amd/display: Retain phantom plane/stream if validation fails drm/amd/display: Revert check for phantom BPP

Aric Cyr (1):
SWDEV-1 - dc: 3.2.213

Camille Cho (1):
drm/amd/display: new ABM config 2

David Galiffi (1):
drm/amd/display: Fix rotated cursor offset calculation

Dillon Varone (5):
drm/amd/display: Update soc bounding box for dcn32/dcn321 drm/amd/display: Use dummy pstate latency for subvp when needed on

    dcn32

drm/amd/display: Add check for DET fetch latency hiding for dcn32 drm/amd/display: Use viewport height for subvp mall allocation size drm/amd/display: Use new num clk levels struct for max mclk index

Ilya Bakoulin (1):
drm/amd/display: Fix display corruption w/ VSR enable

Lee, Alvin (1):
drm/amd/display: Add margin on DRR vblank start for subvp

Mustapha Ghaddar (1):
drm/amd/display: Phase 1 Add Bw Allocation source and header files

Nicholas Kazlauskas (2):
drm/amd/display: Update Z8 watermarks for DCN314 drm/amd/display: Add Z8 allow states to z-state support list

Rodrigo Siqueira (1):
drm/amd/display: Add YCBCR2020 coefficients to CSC matrix

Taimur Hassan (1):
drm/amd/display: Avoid setting pixel rate divider to N/A

Tsung-hua Lin (2):
drm/amd/display: No display after resume from WB/CB drm/amd/display: No display after resume from WB/CB[modify]

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 37 ++++++++++
 .../amd/display/dc/clk_mgr/dcn31/dcn31_smu.c  |  4 +-
 .../display/dc/clk_mgr/dcn314/dcn314_smu.c    | 12 +++-
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 31 +++++++-
 .../gpu/drm/amd/display/dc/core/dc_stream.c   | 16 ++++-
 drivers/gpu/drm/amd/display/dc/dc.h           |  6 +-
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c  |  1 +
 drivers/gpu/drm/amd/display/dc/dc_link.h      | 14 ++++
 drivers/gpu/drm/amd/display/dc/dc_stream.h    |  2 +-
 .../display/dc/dce110/dce110_hw_sequencer.c   |  9 ++-
 .../gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c  | 34 ++++++---
 .../gpu/drm/amd/display/dc/dcn10/dcn10_hubp.c | 28 +++++---
 .../gpu/drm/amd/display/dc/dcn20/dcn20_hubp.c | 32 ++++++---
 .../drm/amd/display/dc/dcn314/dcn314_dccg.c   |  7 ++
 .../drm/amd/display/dc/dcn314/dcn314_hwseq.c  |  6 +-
 .../gpu/drm/amd/display/dc/dcn32/dcn32_dccg.c |  4 +-
 .../drm/amd/display/dc/dcn32/dcn32_hwseq.c    | 11 +--
 .../drm/amd/display/dc/dcn32/dcn32_resource.c | 27 ++++++-
 .../drm/amd/display/dc/dcn32/dcn32_resource.h |  3 +
 .../display/dc/dcn32/dcn32_resource_helpers.c |  2 +-
 .../amd/display/dc/dcn321/dcn321_resource.c   |  4 +-
 .../drm/amd/display/dc/dml/dcn20/dcn20_fpu.c  | 12 +++-
 .../amd/display/dc/dml/dcn314/dcn314_fpu.c    |  4 +-
 .../drm/amd/display/dc/dml/dcn32/dcn32_fpu.c  | 72 ++++++++++++++-----
 .../dc/dml/dcn32/display_mode_vba_32.c        | 41 ++++++++++-
 .../dc/dml/dcn32/display_mode_vba_util_32.c   | 69 ++++++++++++++++++
 .../dc/dml/dcn32/display_mode_vba_util_32.h   | 18 +++++
 .../amd/display/dc/dml/dcn321/dcn321_fpu.c    |  8 +--
 .../drm/amd/display/dc/dml/display_mode_vba.h |  2 +
 .../gpu/drm/amd/display/dc/inc/core_types.h   |  1 +
 drivers/gpu/drm/amd/display/dc/inc/hw/dpp.h   |  9 ++-
 .../drm/amd/display/dc/link/link_dp_dpia_bw.c | 28 ++++++++
 .../drm/amd/display/dc/link/link_dp_dpia_bw.h | 69 ++++++++++++++++++
 .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h   |  3 +-
 .../amd/display/modules/power/power_helpers.c |  9 +++
 35 files changed, 552 insertions(+), 83 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/display/dc/link/link_dp_dpia_bw.c
 create mode 100644 drivers/gpu/drm/amd/display/dc/link/link_dp_dpia_bw.h
Signature · 1 line
2.25.1