Skip to content

drm/fb-helper: Restore damage worker

Thomas Zimmermann dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Revert "drm/fb-helper: Remove damage worker"drivers/gpu/drm/drm_fb_helper.c include/drm/drm_fb_helper.h+11 -00 replies
2/3Revert "drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer"drivers/gpu/drm/drm_fb_helper.c drivers/video/fbdev/core/fb_defio.c include/linux/fb.h+1 -250 replies
3/3Revert "drm/fb-helper: Perform damage handling in deferred-I/O helper"drivers/gpu/drm/drm_fb_helper.c+3 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] drm/fb-helper: Restore damage worker

It turns out that the removal of the damage worker can lead to locking cycles. The display update now runs while holding the fbdefio lock, which conflicts with locks in the modesetting code that updates the display. There's no easy fix for this, so let's restore the damage worker. The display update will then again run outside of the fbdefio lock.

See [1] for bug reports.

[1] https://intel-gfx-ci.01.org/tree/drm-tip/fi-kbl-8809g.html

Thomas Zimmermann (3):
Revert "drm/fb-helper: Remove damage worker"
Revert "drm/fb-helper: Schedule deferred-I/O worker after writing to
framebuffer"
Revert "drm/fb-helper: Perform damage handling in deferred-I/O helper"

 drivers/gpu/drm/drm_fb_helper.c     | 30 +++++++++++++----------------
 drivers/video/fbdev/core/fb_defio.c | 16 ---------------
 include/drm/drm_fb_helper.h         |  2 ++
 include/linux/fb.h                  |  1 -
 4 files changed, 15 insertions(+), 34 deletions(-)
Signature · 1 line
2.38.1