Skip to content

mpfs: fix handling failed service requests

Conor Dooley linux-riscv lkml 3 versions – Applied

Status from this message: Applied to riscv-soc-fixes, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesApplied
  2. v22 patches 1 replySuperseded
  3. v12 patches 1 replySuperseded

Changes in v3 from the cover letter

- Stop redefining the already existing #defines for status register.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2soc: microchip: mpfs: handle failed system service requestsdrivers/soc/microchip/mpfs-sys-controller.c+6 -01 reply
2/2mailbox: mpfs: read the system controller's statusdrivers/mailbox/mailbox-mpfs.c+28 -31 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPalmer Dabbelt
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] mpfs: fix handling failed service requests

From: Conor Dooley <[email protected]>

As things stand, if a service request fails, we never know about it as the status register is not read. This is quite obviously far from ideal, as we would be reading garbage from the mailbox if a service was to fail.

This pair of patches adds handling of the service status to both sides of the mailbox implementation.

@Jassi, there should be no build, or really functional, dependency here between patches. In the failing case, the buffer is allocated by the service driver, so things will "work" just as badly as they did before if only one of the patches is present. As a result, should be safe to do the mailbox patch via your tree & the client via the soc tree.

Thanks,
Conor.

Changes since v2:
- Stop redefining the already existing #defines for status register.

Changes since v1:
- Send the patches I meant to send, with an extraneous ; removed.

Conor Dooley (2):
soc: microchip: mpfs: handle failed system service requests
mailbox: mpfs: read the system controller's status

 drivers/mailbox/mailbox-mpfs.c              | 31 +++++++++++++++++++--
 drivers/soc/microchip/mpfs-sys-controller.c |  6 ++++
 2 files changed, 34 insertions(+), 3 deletions(-)
Signature · 7 lines
2.38.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv