Skip to content

Cleanups around error_propagate() and ERRP_GUARD()

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10error: Drop some obviously superfluous error_propagate()hw/arm/virt.c hw/hyperv/vmbus.c qga/commands-win32.c+11 -191 reply
2/10error: Drop a few superfluous ERRP_GUARD()block/copy-before-write.c dump/dump.c hw/core/qdev.c +3 more+0 -80 replies
3/10error: Move ERRP_GUARD() to the beginning of the functionhw/arm/armsse.c hw/core/machine.c hw/virtio/vhost-vdpa.c +2 more+6 -81 reply
4/10monitor: Simplify monitor_fd_param()'s error handlingmonitor/misc.c+4 -100 replies
5/10monitor: Use ERRP_GUARD() in monitor_init()monitor/monitor.c+4 -80 replies
6/10qemu-config: Make config_parse_qdict() return boolblock/blkdebug.c include/qemu/config-file.h util/qemu-config.c+20 -250 replies
7/10qemu-config: Use ERRP_GUARD() where obviously appropriateutil/qemu-config.c+3 -40 replies
8/10sockets: Use ERRP_GUARD() where obviously appropriateutil/qemu-sockets.c+10 -160 replies
9/10qapi: Use returned bool to check for failure (again)accel/kvm/kvm-all.c hw/core/qdev-properties-system.c hw/i386/pc.c +5 more+21 -521 reply
10/10io: Tidy up fat-fingered parameter nameinclude/io/channel.h+1 -11 reply

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/10R-b
2/10
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] Cleanups around error_propagate() and ERRP_GUARD()

Markus Armbruster (10):
error: Drop some obviously superfluous error_propagate()
error: Drop a few superfluous ERRP_GUARD()
error: Move ERRP_GUARD() to the beginning of the function
monitor: Simplify monitor_fd_param()'s error handling
monitor: Use ERRP_GUARD() in monitor_init()
qemu-config: Make config_parse_qdict() return bool
qemu-config: Use ERRP_GUARD() where obviously appropriate
sockets: Use ERRP_GUARD() where obviously appropriate
qapi: Use returned bool to check for failure (again)
io: Tidy up fat-fingered parameter name

 include/io/channel.h             |  2 +-
 include/qemu/config-file.h       |  2 +-
 accel/kvm/kvm-all.c              |  5 +---
 block/blkdebug.c                 |  4 +--
 block/copy-before-write.c        |  1 -
 dump/dump.c                      |  2 --
 hw/arm/armsse.c                  |  3 +--
 hw/arm/virt.c                    | 14 ++++------
 hw/core/machine.c                |  3 +--
 hw/core/qdev-properties-system.c |  5 +---
 hw/core/qdev.c                   |  2 --
 hw/hyperv/vmbus.c                |  8 +++---
 hw/i386/pc.c                     |  5 +---
 hw/pci/msi.c                     |  1 -
 hw/remote/vfio-user-obj.c        |  1 -
 hw/virtio/vhost-vdpa.c           |  2 +-
 hw/virtio/virtio-balloon.c       | 20 +++++++-------
 hw/virtio/virtio-mem.c           | 10 ++-----
 iothread.c                       |  2 +-
 monitor/misc.c                   | 14 +++-------
 monitor/monitor.c                | 12 +++------
 monitor/qmp-cmds.c               |  4 +--
 net/colo-compare.c               | 13 +++------
 qga/commands-win32.c             |  8 +++---
 target/i386/kvm/kvm.c            |  5 +---
 ui/util.c                        |  1 -
 util/qemu-config.c               | 46 +++++++++++++++-----------------
 util/qemu-sockets.c              | 26 +++++++-----------
 util/thread-context.c            | 10 ++-----
 29 files changed, 80 insertions(+), 151 deletions(-)
Signature · 1 line
2.37.3