Skip to content

migration patches for VFIO

Juan Quintela qemu-arm qemu-devel qemu-trivial virtio-fs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest51 patches 1 replyIn review
  2. v119 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/51update seabios source from 1.16.0 to 1.16.1roms/seabios+1 -10 replies
2/51update seabios binaries to 1.16.1pc-bios/bios-256k.bin pc-bios/bios-microvm.bin pc-bios/bios.bin +9 more+0 -00 replies
3/51replay: Fix declaration of replay_read_next_clockreplay/replay-internal.h+1 -10 replies
4/51hw/display/qxl: Have qxl_log_command Return early if no log_cmd handlerhw/display/qxl-logger.c+11 -00 replies
5/51hw/display/qxl: Document qxl_phys2virt()hw/display/qxl.h+19 -00 replies
6/51hw/display/qxl: Pass requested buffer size to qxl_phys2virt()hw/display/qxl-logger.c hw/display/qxl-render.c hw/display/qxl.c +1 more+36 -130 replies
7/51hw/display/qxl: Avoid buffer overrun in qxl_phys2virt (CVE-2022-4144)hw/display/qxl.c hw/display/qxl.h+24 -50 replies
8/51hw/display/qxl: Assert memory slot fits in preallocated MemoryRegionhw/display/qxl.c+1 -00 replies
9/51block-backend: avoid bdrv_unregister_buf() NULL pointer derefblock/block-backend.c+13 -20 replies
10/51target/arm: Set TCGCPUOps.restore_state_to_opc for v7mtarget/arm/cpu.c target/arm/cpu_tcg.c target/arm/internals.h+8 -30 replies
11/51Update VERSION for v7.2.0-rc3VERSION+1 -10 replies
12/51tests/qtests: override "force-legacy" for gpio virtio-mmio teststests/qtest/libqos/virtio-gpio.c+2 -10 replies
13/51vhost: enable vrings in vhost_dev_start() for vhost-user devicesbackends/cryptodev-vhost.c backends/vhost-user.c hw/block/vhost-user-blk.c +10 more+67 -310 replies
14/51hw/virtio: add started_vu status field to vhost-user-gpiohw/virtio/vhost-user-gpio.c include/hw/virtio/vhost-user-gpio.h+14 -70 replies
15/51hw/virtio: generalise CHR_EVENT_CLOSED handlinghw/block/vhost-user-blk.c hw/virtio/vhost-user-gpio.c hw/virtio/vhost-user.c +1 more+104 -370 replies
16/51include/hw: VM state takes precedence in virtio_device_should_startinclude/hw/virtio/virtio.h+18 -50 replies
17/51hw/nvme: fix aio cancel in formathw/nvme/ctrl.c+12 -160 replies
18/51hw/nvme: fix aio cancel in flushhw/nvme/ctrl.c+6 -150 replies
19/51hw/nvme: fix aio cancel in zone resethw/nvme/ctrl.c+11 -250 replies
20/51hw/nvme: fix aio cancel in dsmhw/nvme/ctrl.c+8 -260 replies
21/51hw/nvme: remove copy bh schedulinghw/nvme/ctrl.c+14 -490 replies
22/51target/i386: allow MMX instructions with CR4.OSFXSR=0target/i386/tcg/decode-new.c.inc+2 -10 replies
23/51target/i386: Always completely initialize TranslateFaulttarget/i386/tcg/sysemu/excp_helper.c+19 -150 replies
24/51hw/loongarch/virt: Add cfi01 pflash devicehw/loongarch/Kconfig hw/loongarch/acpi-build.c hw/loongarch/virt.c +1 more+86 -00 replies
25/51tests/qtest/migration-test: Fix unlink error and memory leakstests/qtest/migration-test.c+16 -40 replies
26/51target/s390x/tcg: Fix and improve the SACF instructiontarget/s390x/tcg/cc_helper.c target/s390x/tcg/insn-data.h.inc+8 -10 replies
27/51hw/display/next-fb: Fix comment typohw/display/next-fb.c+1 -10 replies
28/51multifd: Create page_size fields into both MultiFD{Recv,Send}Paramsmigration/multifd-zlib.c migration/multifd-zstd.c migration/multifd.c +1 more+23 -250 replies
29/51multifd: Create page_count fields into both MultiFD{Recv,Send}Paramsmigration/multifd.c migration/multifd.h+8 -30 replies
30/51migration: Export ram_transferred_ram()migration/ram.c migration/ram.h+3 -10 replies
31/51migration: Export ram_release_page()migration/ram.c migration/ram.h+2 -10 replies
32/51migration: Take bitmap mutex when completing ram migrationmigration/ram.c+2 -00 replies
33/51migration: Add postcopy_preempt_active()migration/ram.c+7 -20 replies
34/51migration: Cleanup xbzrle zero page cache update logicmigration/ram.c+1 -50 replies
35/51migration: Trivial cleanup save_page_header() on same block checkmigration/ram.c+3 -20 replies
36/51migration: Remove RAMState.f references in compression codemigration/ram.c+7 -50 replies
37/51migration: Yield bitmap_mutex properly when sending/sleepingmigration/ram.c+35 -110 replies
38/51migration: Use atomic ops properly for page accountingsmigration/migration.c migration/multifd.c migration/ram.c +1 more+51 -230 replies
39/51migration: Teach PSS about host pagemigration/ram.c+76 -190 replies
40/51migration: Introduce pss_channelmigration/ram.c+38 -320 replies
41/51migration: Add pss_init()migration/ram.c+9 -30 replies
42/51migration: Make PageSearchStatus part of RAMStatemigration/ram.c+61 -510 replies
43/51migration: Move last_sent_block into PageSearchStatusmigration/ram.c+41 -300 replies
44/51migration: Send requested page directly in rp-return threadmigration/migration.c migration/ram.c+131 -160 replies
45/51migration: Remove old preempt code around state maintainancemigration/migration.c migration/migration.h migration/ram.c+3 -2970 replies
46/51migration: Drop rs->fmigration/ram.c+4 -80 replies
47/51migration: Remove res_compatible parameterhw/s390x/s390-stattrib.c hw/vfio/migration.c hw/vfio/trace-events +8 more+37 -520 replies
48/51migration: No save_live_pending() method uses the QEMUFile parameterhw/s390x/s390-stattrib.c hw/vfio/migration.c include/migration/register.h +6 more+13 -200 replies
49/51migration: Split save_live_pending() into state_pending_*docs/devel/migration.rst docs/devel/vfio-migration.rst hw/s390x/s390-stattrib.c +10 more+114 -530 replies
50/51migration: Remove unused threshold_size parameterhw/vfio/migration.c include/migration/register.h migration/block-dirty-bitmap.c +5 more+18 -290 replies
51/51migration: simplify migration_iteration_run()migration/migration.c+12 -120 replies

Reviews trailers per patch

42 of 51 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéWilfred MallawaPavel DovgalyukMarc-André LureauGerd HoffmannJonathan CameronKevin WolfMichael S. TsirkinThomas HuthGerman MaglioneRaphael NorwitzChristian BorntraegerKeith BuschRichard HendersonBin MengDaniel P. BerrangéJuan QuintelaIlya LeoshkevichDavid HildenbrandPeter MaydellLeonardo BrasDr. David Alan GilbertDavid Edmondson
1/51
2/51
3/51R-b R-b R-b
4/51R-b
5/51R-b
6/51A-b
7/51
8/51
9/51R-b Co-authored-by R-b
10/51
11/51
12/51R-b A-b
13/51R-b T-b A-b
14/51R-b
15/51R-b R-b
16/51R-b T-b
17/51R-b
18/51R-b
19/51R-b
20/51R-b
21/51R-b
22/51R-b
23/51
24/51R-b
25/51T-b R-b R-b
26/51R-b R-b R-b
27/51R-b R-b
28/51R-b
29/51R-b
30/51R-b R-b R-b
31/51R-b
32/51R-b R-b
33/51R-b R-b
34/51R-b R-b
35/51R-b R-b
36/51R-b
37/51R-b R-b
38/51R-b R-b
39/51R-b R-b
40/51R-b R-b
41/51R-b R-b
42/51R-b R-b
43/51R-b R-b
44/51R-b R-b
45/51R-b R-b
46/51R-b R-b
47/51
48/51R-b
49/51R-b
50/51
51/51R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 23 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/51] migration patches for VFIO

Hi

On this v2:

- Remove the stop of the guest to calculate the size
- Rebase on latest upstream.

Please review.

[v1/RFC]
VFIO migration has several requirements:
- the size of the state is only known when the guest is stopped
- they need to send possible lots of data.

this series only address the 1st set of problems.

What they do:
- res_compatible parameter was not used anywhere, just add that information to res_postcopy.
- Remove QEMUFILE parameter from save_live_pending
- Split save_live_pending into
* save_pending_estimate(): the pending state size without trying too hard
* save_pending_exact(): the real pending state size, it is called with the guest stopped.
- Now save_pending_* don't need the threshold parameter
- HACK a way to stop the guest before moving there.

ToDo:
- autoconverge test is broken, no real clue why, but it is possible that the test is wrong.

- Make an artifact to be able to send massive amount of data in the save state stage (probably more multifd channels).

- Be able to not having to start the guest between cheking the state pending size and migration_completion().

Please review.

Thanks, Juan.

Alex Bennée (4):
tests/qtests: override "force-legacy" for gpio virtio-mmio tests hw/virtio: add started_vu status field to vhost-user-gpio hw/virtio: generalise CHR_EVENT_CLOSED handling include/hw: VM state takes precedence in virtio_device_should_start

Evgeny Ermakov (2):
target/arm: Set TCGCPUOps.restore_state_to_opc for v7m hw/display/next-fb: Fix comment typo

Gerd Hoffmann (2):
update seabios source from 1.16.0 to 1.16.1
update seabios binaries to 1.16.1

Juan Quintela (9):
multifd: Create page_size fields into both MultiFD{Recv,Send}Params
multifd: Create page_count fields into both MultiFD{Recv,Send}Params
migration: Export ram_transferred_ram()
migration: Export ram_release_page()
migration: Remove res_compatible parameter
migration: No save_live_pending() method uses the QEMUFile parameter
migration: Split save_live_pending() into state_pending_*
migration: Remove unused threshold_size parameter
migration: simplify migration_iteration_run()

Klaus Jensen (5):
hw/nvme: fix aio cancel in format
hw/nvme: fix aio cancel in flush
hw/nvme: fix aio cancel in zone reset
hw/nvme: fix aio cancel in dsm
hw/nvme: remove copy bh scheduling

Paolo Bonzini (1):
target/i386: allow MMX instructions with CR4.OSFXSR=0

Peter Xu (15):
migration: Take bitmap mutex when completing ram migration
migration: Add postcopy_preempt_active()
migration: Cleanup xbzrle zero page cache update logic
migration: Trivial cleanup save_page_header() on same block check
migration: Remove RAMState.f references in compression code
migration: Yield bitmap_mutex properly when sending/sleeping
migration: Use atomic ops properly for page accountings
migration: Teach PSS about host page
migration: Introduce pss_channel
migration: Add pss_init()
migration: Make PageSearchStatus part of RAMState
migration: Move last_sent_block into PageSearchStatus
migration: Send requested page directly in rp-return thread
migration: Remove old preempt code around state maintainance
migration: Drop rs->f

Philippe Mathieu-Daudé (5):
hw/display/qxl: Have qxl_log_command Return early if no log_cmd
handler
hw/display/qxl: Document qxl_phys2virt()
hw/display/qxl: Pass requested buffer size to qxl_phys2virt() hw/display/qxl: Avoid buffer overrun in qxl_phys2virt (CVE-2022-4144) hw/display/qxl: Assert memory slot fits in preallocated MemoryRegion

Richard Henderson (2):
replay: Fix declaration of replay_read_next_clock target/i386: Always completely initialize TranslateFault

Stefan Hajnoczi (2):
block-backend: avoid bdrv_unregister_buf() NULL pointer deref Update VERSION for v7.2.0-rc3

Stefano Garzarella (1):
vhost: enable vrings in vhost_dev_start() for vhost-user devices

Thomas Huth (2):
tests/qtest/migration-test: Fix unlink error and memory leaks target/s390x/tcg: Fix and improve the SACF instruction

Xiaojuan Yang (1):
hw/loongarch/virt: Add cfi01 pflash device

Signature · 1 line
2.38.1