Skip to content

genirq, irqchip: Convert ARM MSI handling to per device MSI domains

Thomas Gleixner imx linux-arm-kernel linux-pci lkml 1 version Applied

Status from this message: The following commit has been merged into the irq/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest40 patches 16 repliesApplied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/40irqchip/irq-mvebu-icu: Fix works by chance pointer assignmentdrivers/irqchip/irq-mvebu-icu.c+2 -21 reply
2/40ACPI/IORT: Make prototype of iort_pmsi_get_dev_id() always availableinclude/linux/acpi_iort.h+3 -11 reply
3/40irqchip/gic-v2m: Include arm-gic-common.hdrivers/irqchip/irq-gic-v2m.c+1 -01 reply
4/40irqchip/gic-v2m: Mark a few functions __initdrivers/irqchip/irq-gic-v2m.c+5 -51 reply
5/40irqchip/ti-sci-inta: Fix kernel docdrivers/irqchip/irq-ti-sci-inta.c+1 -11 reply
6/40PCI/MSI: Provide static key for parent mask/unmaskdrivers/pci/msi/irqdomain.c include/linux/msi.h+32 -08 replies
7/40irqchip/gic-v3: Make gic_irq_domain_select() robust for zero parameter countdrivers/irqchip/irq-gic-v3.c+5 -10 replies
8/40genirq/irqdomain: Remove the param count restriction from select()kernel/irq/irqdomain.c+1 -10 replies
9/40genirq/msi: Extend msi_parent_opsinclude/linux/msi.h+11 -00 replies
10/40irqchip: Provide irq-gic-libdrivers/irqchip/Kconfig drivers/irqchip/Makefile drivers/irqchip/irq-gic-msi-lib.c +1 more+135 -00 replies
11/40irqchip/gic-v3-its: Provide MSI parent infrastructuredrivers/irqchip/Kconfig drivers/irqchip/Makefile drivers/irqchip/irq-gic-common.h +2 more+39 -10 replies
12/40irqchip/gic-msi-lib: Prepare for PCI MSI/MSIXdrivers/irqchip/irq-gic-msi-lib.c drivers/irqchip/irq-gic-msi-lib.h+13 -00 replies
13/40irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X]drivers/irqchip/Makefile drivers/irqchip/irq-gic-v3-its-msi-parent.c drivers/irqchip/irq-gic-v3-its-pci-msi.c+106 -2030 replies
14/40genirq/irqdomain: Add BUS_DOMAIN_DEVICE_MSIinclude/linux/irqdomain_defs.h+1 -00 replies
15/40irqchip/gic-msi-lib: Prepare for DEVICE MSI to replace platform MSIdrivers/irqchip/irq-gic-msi-lib.c drivers/irqchip/irq-gic-msi-lib.h+15 -00 replies
16/40platform-msi: Prepare for real per device domainsdrivers/base/platform-msi.c include/linux/msi.h+102 -00 replies
17/40irqchip: Convert all platform MSI users to the new APIdrivers/dma/mv_xor_v2.c drivers/dma/qcom/hidma.c drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +2 more+16 -150 replies
18/40genirq/msi: Provide optional translation opinclude/linux/msi.h kernel/irq/msi.c+20 -00 replies
19/40genirq/msi: Split msi_domain_alloc_irq_at()kernel/irq/msi.c+43 -330 replies
20/40genirq/msi: Provide BUS DEVICE_MSI_WIREDinclude/linux/irqdomain_defs.h+1 -00 replies
21/40genirq/msi: Optionally use dev->fwnode for device domaininclude/linux/msi.h kernel/irq/msi.c+18 -40 replies
22/40genirq/msi: Provide allocation/free functions for "wired" MSI interruptsinclude/linux/irqdomain.h kernel/irq/msi.c+85 -00 replies
23/40genirq/irqdomain: Reroute device MSI create_mappingkernel/irq/irqdomain.c+18 -60 replies
24/40irqchip/mbigen: Prepare for real per device MSIdrivers/irqchip/irq-mbigen.c+71 -290 replies
25/40irqchip/gic-msi-lib: Prepare for DOMAIN_BUS_WIRED_TO_MSIdrivers/irqchip/irq-gic-msi-lib.c+2 -00 replies
26/40irqchip/gic-v3-its: Switch platform MSI to MSI parentdrivers/irqchip/Makefile drivers/irqchip/irq-gic-v3-its-msi-parent.c drivers/irqchip/irq-gic-v3-its-platform-msi.c+73 -1650 replies
27/40irqchip/mbigen: Remove platform_msi_create_device_domain() fallbackdrivers/irqchip/irq-mbigen.c+4 -700 replies
28/40genirq/msi: Remove platform_msi_create_device_domain()include/linux/msi.h+0 -20 replies
29/40genirq/gic-v3-mbi: Remove unused wired MSI mechanicsdrivers/irqchip/irq-gic-v3-mbi.c+1 -160 replies
30/40genirq/gic-v3-mbi: Switch to MSI parentdrivers/irqchip/irq-gic-v3-mbi.c+32 -900 replies
31/40irqchip/gic-v2m: Switch to device MSIdrivers/irqchip/Kconfig drivers/irqchip/irq-gic-v2m.c+25 -580 replies
32/40genirq/msi: Provide MSI_FLAG_PARENT_PM_DEVinclude/linux/msi.h kernel/irq/msi.c+4 -00 replies
33/40irqchip/imx-mu-msi: Switch to MSI parentdrivers/irqchip/Kconfig drivers/irqchip/irq-gic-msi-lib.c drivers/irqchip/irq-imx-mu-msi.c+25 -312 replies
34/40irqchip/irq-mvebu-icu: Prepare for real per device MSIdrivers/irqchip/irq-mvebu-icu.c+170 -110 replies
35/40irqchip/mvebu-gicp: Switch to MSI parentdrivers/irqchip/Kconfig drivers/irqchip/irq-mvebu-gicp.c+20 -250 replies
36/40irqchip/mvebu-odmi: Switch to parent MSIdrivers/irqchip/Kconfig drivers/irqchip/irq-mvebu-odmi.c+19 -210 replies
37/40irqchip/irq-mvebu-sei: Switch to MSI parentdrivers/irqchip/irq-mvebu-sei.c+20 -320 replies
38/40irqchip/irq-mvebu-icu: Remove platform MSI leftoversdrivers/irqchip/irq-mvebu-icu.c+6 -2070 replies
39/40genirq/msi: Remove platform MSI leftoversdrivers/base/platform-msi.c include/linux/msi.h kernel/irq/msi.c+3 -4280 replies
40/40genirq/msi: Move msi_device_data to coreinclude/linux/msi.h kernel/irq/msi.c+22 -240 replies

Reviews trailers per patch

4 of 40 patches have a Reviewed-by or Acked-by.

PatchMarc Zyngier
1/40A-b
2/40
3/40A-b
4/40A-b
5/40A-b
6/40
7/40
8/40
9/40
10/40
11/40
12/40
13/40
14/40
15/40
16/40
17/40
18/40
19/40
20/40
21/40
22/40
23/40
24/40
25/40
26/40
27/40
28/40
29/40
30/40
31/40
32/40
33/40
34/40
35/40
36/40
37/40
38/40
39/40
40/40

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [patch V2 00/40] genirq, irqchip: Convert ARM MSI handling to per device MSI domains

This builds on top of the per device MSI work which can be found here:

https://lore.kernel.org/all/[email protected]

and is available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-part3

This series converts the ARM MSI handling, especially the platform MSI mechanics, to use per device MSI domains instead of the weird indirection through platform MSI domains.

This also takes a different and less convoluted approach to the 'wire to MSI' bridges by providing special MSI allocation/free functions which are invoked from irq_create_fwspec_mapping() and irq_dispose_mapping() which avoids the extra entry point msi_domain_populate_irqs() and its layering violations.

The series has been tested on various systems (Ampere, Hisilicon HIP05, ThunderX2, MVEBU MCBIN) but there is no full coverage yet.

Thanks to Marc, Mark and Robin for running this on their machines and aiding with decoding the initial wreckage. Special thanks go to Marc for patiently guiding me through the insanity of OF/ACPI related to this.

The series is also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git devmsi-v2-arm

The work was done to validate that the design decisions for per device MSI domains and the related data structures are up to the task to handle the ARM oddities. The design held up, it was just necessary to extend some of the data structures to handle the ARM specifics in a sane way, but there was no fundamental shortcoming.

Thanks,

tglx

---
 b/drivers/base/platform-msi.c                 |  354 +++-----------------------
 b/drivers/dma/mv_xor_v2.c                     |    8 
 b/drivers/dma/qcom/hidma.c                    |    6 
 b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c |    5 
 b/drivers/irqchip/Kconfig                     |    8 
 b/drivers/irqchip/Makefile                    |    4 
 b/drivers/irqchip/irq-gic-common.h            |    3 
 b/drivers/irqchip/irq-gic-msi-lib.c           |  136 +++++++++
 b/drivers/irqchip/irq-gic-msi-lib.h           |   27 +
 b/drivers/irqchip/irq-gic-v2m.c               |   93 ++----
 b/drivers/irqchip/irq-gic-v3-its-msi-parent.c |  207 +++++++++++++++
 b/drivers/irqchip/irq-gic-v3-its.c            |    4 
 b/drivers/irqchip/irq-gic-v3-mbi.c            |  137 ++--------
 b/drivers/irqchip/irq-gic-v3.c                |    6 
 b/drivers/irqchip/irq-imx-mu-msi.c            |   53 +--
 b/drivers/irqchip/irq-mbigen.c                |   98 ++-----
 b/drivers/irqchip/irq-mvebu-gicp.c            |   44 +--
 b/drivers/irqchip/irq-mvebu-icu.c             |  278 ++++++++------------
 b/drivers/irqchip/irq-mvebu-odmi.c            |   39 +-
 b/drivers/irqchip/irq-mvebu-sei.c             |   52 +--
 b/drivers/irqchip/irq-ti-sci-inta.c           |    2 
 b/drivers/mailbox/bcm-flexrm-mailbox.c        |    8 
 b/drivers/pci/msi/irqdomain.c                 |   30 ++
 b/drivers/perf/arm_smmuv3_pmu.c               |    4 
 b/include/linux/acpi_iort.h                   |    4 
 b/include/linux/irqdomain.h                   |   17 +
 b/include/linux/irqdomain_defs.h              |    2 
 b/include/linux/msi.h                         |   81 +----
 b/kernel/irq/irqdomain.c                      |   26 +
 b/kernel/irq/msi.c                            |  253 ++++++++++++------
 drivers/irqchip/irq-gic-v3-its-pci-msi.c      |  202 --------------
 drivers/irqchip/irq-gic-v3-its-platform-msi.c |  163 -----------
 32 files changed, 1021 insertions(+), 1333 deletions(-)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel