Skip to content

codeql fixes for various subsystems

[email protected] dpdk-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 8 repliesIn review
  2. v2 posting 2/211 patches 9 repliesSuperseded
  3. v2 posting 1/29 of 11 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v19 of 11 patches3 repliesSuperseded

Changes in v3 from the cover letter

- Remove braces around single line statements
- use NULL comparisons

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ethdev: check return result of rte_eth_dev_info_getlib/ethdev/rte_class_eth.c+3 -11 reply
2/10memzone: check result of rte_fbarray_getlib/eal/common/eal_common_memzone.c+5 -10 replies
3/10memzone: check result of malloc_elem_from_datalib/eal/common/eal_common_memzone.c+4 -00 replies
4/10malloc: malloc_elem_join_adjacent_free can return nulllib/eal/common/malloc_heap.c+2 -00 replies
5/10malloc: check result of rte_mem_virt2memseg_listlib/eal/common/malloc_heap.c+2 -00 replies
6/10malloc: check result of rte_fbarray_getlib/eal/common/eal_common_memalloc.c+4 -10 replies
7/10malloc: check result of rte_mem_virt2memseglib/eal/common/malloc_elem.c lib/eal/common/malloc_heap.c+9 -40 replies
8/10malloc: check result of malloc_elem_freelib/eal/common/malloc_heap.c+3 -00 replies
9/10malloc: check result of elem_start_ptlib/eal/common/malloc_elem.c+3 -00 replies
10/10bus/vdev: check result of rte_vdev_device_namelib/ethdev/ethdev_vdev.h+2 -04 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMorten BrørupStephen HemmingerChengwen FengAndrew Rybchenko
SeriesR-b A-b Series-acked-by R-b R-b
1/10R-b
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/10] codeql fixes for various subsystems

From: Sinan Kaya <[email protected]>

Following up the codeql reported problems first submitted by Stephen Hemminger here:

https://lore.kernel.org/all/[email protected]/t/

Posting a series of fixes about potential null pointer accesses.

Changes from v3:
- Dropped net/tap: check if name is null
- Moved the comment to the appropriate position in ethdev: check return result of rte_eth_dev_info_get

Changes from v2:
- Remove braces around single line statements
- use NULL comparisons

Sinan Kaya (10):
ethdev: check return result of rte_eth_dev_info_get
memzone: check result of rte_fbarray_get
memzone: check result of malloc_elem_from_data
malloc: malloc_elem_join_adjacent_free can return null
malloc: check result of rte_mem_virt2memseg_list
malloc: check result of rte_fbarray_get
malloc: check result of rte_mem_virt2memseg
malloc: check result of malloc_elem_free
malloc: check result of elem_start_pt bus/vdev: check result of rte_vdev_device_name

 lib/eal/common/eal_common_memalloc.c |  5 ++++-
 lib/eal/common/eal_common_memzone.c  | 10 +++++++++-
 lib/eal/common/malloc_elem.c         | 14 +++++++++++---
 lib/eal/common/malloc_heap.c         |  9 ++++++++-
 lib/ethdev/ethdev_vdev.h             |  2 ++
 lib/ethdev/rte_class_eth.c           |  4 +++-
 6 files changed, 37 insertions(+), 7 deletions(-)
Signature · 1 line
2.25.1