Skip to content

Implement SECCOMP based userland

[email protected] linux-um 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest28 patches 0 repliesNew

Changes in v2 from the cover letter

* Fixed FP register store/restore
* Plenty of other fixes and improvements

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28um: Switch printk calls to adhere to correct coding stylearch/um/kernel/exec.c arch/um/os-Linux/skas/mem.c arch/um/os-Linux/skas/process.c+69 -750 replies
2/28um: Declare fix_range_common as a static functionarch/um/kernel/tlb.c+2 -20 replies
3/28um: Drop support for hosts without SYSEMU_SINGLESTEP supportarch/um/include/asm/processor-generic.h arch/um/include/shared/kern_util.h arch/um/include/shared/ptrace_user.h +9 more+24 -2430 replies
4/28um: Drop NULL check from start_userspacearch/um/os-Linux/skas/process.c+24 -290 replies
5/28um: Make errors to stop ptraced child fatal during startuparch/um/os-Linux/start_up.c+12 -290 replies
6/28um: Don't use vfprintf() for os_info()arch/um/os-Linux/util.c+17 -20 replies
7/28um: Do not use printk in SIGWINCH helper threadarch/um/drivers/chan_user.c+13 -130 replies
8/28um: Reap winch thread if it failsarch/um/drivers/chan_user.c arch/um/drivers/line.c+19 -100 replies
9/28um: Do not use printk in userspace trampolinearch/um/os-Linux/skas/process.c+6 -60 replies
10/28um: Always inline stub functionsarch/x86/um/shared/sysdep/stub_32.h arch/x86/um/shared/sysdep/stub_64.h+19 -170 replies
11/28um: Rely on PTRACE_SETREGSET to set FS/GS base registersarch/um/include/shared/os.h arch/x86/um/asm/elf.h arch/x86/um/asm/processor_64.h +4 more+16 -710 replies
12/28um: Remove unused register save/restore functionsarch/um/include/shared/registers.h arch/um/os-Linux/registers.c+0 -220 replies
13/28um: Mark 32bit syscall helpers as clobbering memoryarch/x86/um/shared/sysdep/stub_32.h+12 -60 replies
14/28um: Remove stub-data.h include from common-offsets.harch/um/include/shared/common-offsets.h arch/x86/um/shared/sysdep/stub_32.h arch/x86/um/shared/sysdep/stub_64.h+8 -110 replies
15/28um: Create signal stack memory assignment in stub_dataarch/um/include/shared/as-layout.h arch/um/include/shared/skas/stub-data.h arch/um/kernel/skas/clone.c +4 more+36 -160 replies
16/28um: Add generic stub_syscall6 functionarch/x86/um/shared/sysdep/stub_32.h arch/x86/um/shared/sysdep/stub_64.h+38 -00 replies
17/28um: Rework syscall handlingarch/um/include/shared/os.h arch/um/include/shared/skas/mm_id.h arch/um/include/shared/skas/stub-data.h +13 more+259 -2940 replies
18/28um: Store full CSGSFS and SS register from mcontextarch/x86/um/os-Linux/mcontext.c+1 -20 replies
19/28um: Pass full mm_id to functions creating helper processesarch/um/include/shared/os.h arch/um/kernel/skas/mmu.c arch/um/os-Linux/skas/process.c+34 -370 replies
20/28um: Move faultinfo extraction into userspace routinearch/um/os-Linux/skas/process.c+7 -110 replies
21/28um: Use struct uml_pt_regs for copy_context_skas0arch/um/os-Linux/skas/process.c+11 -120 replies
22/28um: Add UML_SECCOMP configuration optionarch/um/Kconfig+19 -00 replies
23/28um: Add stub side of SECCOMP/futex based process handlingarch/um/include/shared/skas/stub-data.h arch/um/kernel/skas/clone.c arch/um/kernel/skas/stub.c +4 more+129 -00 replies
24/28um: Add helper functions to get/set state for SECCOMParch/um/include/shared/common-offsets.h arch/x86/um/os-Linux/mcontext.c arch/x86/um/shared/sysdep/mcontext.h+166 -20 replies
25/28um: Add SECCOMP support detection and initializationarch/um/include/shared/skas/skas.h arch/um/os-Linux/registers.c arch/um/os-Linux/skas/process.c +1 more+145 -40 replies
26/28um: Die if a child dies unexpectedly in seccomp modearch/um/include/shared/os.h arch/um/os-Linux/process.c arch/um/os-Linux/signal.c+48 -00 replies
27/28um: Implement kernel side of SECCOMP based process handlingarch/um/os-Linux/skas/mem.c arch/um/os-Linux/skas/process.c arch/um/os-Linux/start_up.c+439 -1600 replies
28/28um: Delay flushing syscalls until the thread is restartedarch/um/include/shared/os.h arch/um/include/shared/skas/skas.h arch/um/kernel/skas/process.c +3 more+75 -420 replies

Reviews trailers per patch

None of the 28 patches has a Reviewed-by or Acked-by.

PatchJohannes Berg
1/28
2/28
3/28
4/28
5/28
6/28
7/28
8/28
9/28
10/28
11/28
12/28
13/28
14/28
15/28
16/28
17/28
18/28
19/28
20/28
21/28
22/28
23/28Co-authored-by
24/28
25/28
26/28
27/28Co-authored-by
28/28

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/28] Implement SECCOMP based userland

From: Benjamin Berg <[email protected]>

Currently UML uses ptrace in order to implement userspace processes. This works really well, however, it requires six context switches per pagefault (get faultinfo, run syscalls, continue process).

By switching to use SECCOMP, the whole process becomes more collaborative as the userspace process can run code, including host syscalls, before jumping into the kernel and after the kernel returns control. This means pagefaults only require two context switches to be processed.

In pagefault heavy scenarios (e.g. fork/exec) the performance increase of doing this can be considerable, with runtimes dropping by 30% or more.

Note that the current syscall filter can easily be abused by a userspace process to execute arbitrary host syscalls. I think it is possible to efficiently detect such attempts and kill the offending processes by (ab)using the rt_sigaction syscall in order to set/get a flag that userspace code cannot tamper with.

v2:
* Fixed FP register store/restore
* Plenty of other fixes and improvements

Benjamin Berg (28):
um: Switch printk calls to adhere to correct coding style
um: Declare fix_range_common as a static function
um: Drop support for hosts without SYSEMU_SINGLESTEP support
um: Drop NULL check from start_userspace
um: Make errors to stop ptraced child fatal during startup
um: Don't use vfprintf() for os_info()
um: Do not use printk in SIGWINCH helper thread
um: Reap winch thread if it fails
um: Do not use printk in userspace trampoline
um: Always inline stub functions
um: Rely on PTRACE_SETREGSET to set FS/GS base registers
um: Remove unused register save/restore functions
um: Mark 32bit syscall helpers as clobbering memory
um: Remove stub-data.h include from common-offsets.h
um: Create signal stack memory assignment in stub_data
um: Add generic stub_syscall6 function
um: Rework syscall handling
um: Store full CSGSFS and SS register from mcontext
um: Pass full mm_id to functions creating helper processes
um: Move faultinfo extraction into userspace routine
um: Use struct uml_pt_regs for copy_context_skas0
um: Add UML_SECCOMP configuration option
um: Add stub side of SECCOMP/futex based process handling
um: Add helper functions to get/set state for SECCOMP
um: Add SECCOMP support detection and initialization
um: Die if a child dies unexpectedly in seccomp mode
um: Implement kernel side of SECCOMP based process handling
um: Delay flushing syscalls until the thread is restarted

 arch/um/Kconfig                         |  19 +
 arch/um/drivers/chan_user.c             |  42 +-
 arch/um/drivers/line.c                  |  13 +-
 arch/um/include/asm/processor-generic.h |   1 -
 arch/um/include/shared/as-layout.h      |   2 +-
 arch/um/include/shared/common-offsets.h |  14 +-
 arch/um/include/shared/kern_util.h      |   3 +-
 arch/um/include/shared/os.h             |  33 +-
 arch/um/include/shared/ptrace_user.h    |  41 --
 arch/um/include/shared/registers.h      |   2 -
 arch/um/include/shared/skas/mm_id.h     |   1 +
 arch/um/include/shared/skas/skas.h      |   7 +
 arch/um/include/shared/skas/stub-data.h |  41 +-
 arch/um/include/shared/user.h           |   8 +
 arch/um/kernel/exec.c                   |  10 +-
 arch/um/kernel/process.c                |  12 +-
 arch/um/kernel/ptrace.c                 |   2 -
 arch/um/kernel/signal.c                 |  12 -
 arch/um/kernel/skas/Makefile            |   4 +-
 arch/um/kernel/skas/clone.c             |  33 +-
 arch/um/kernel/skas/mmu.c               |  16 +-
 arch/um/kernel/skas/process.c           |   8 +
 arch/um/kernel/skas/stub.c              | 101 ++++
 arch/um/kernel/tlb.c                    |  54 +-
 arch/um/os-Linux/process.c              |  40 ++
 arch/um/os-Linux/registers.c            |  24 +-
 arch/um/os-Linux/signal.c               |   7 +
 arch/um/os-Linux/skas/mem.c             | 288 +++++----
 arch/um/os-Linux/skas/process.c         | 749 ++++++++++++++++--------
 arch/um/os-Linux/start_up.c             | 244 +++++---
 arch/um/os-Linux/util.c                 |  19 +-
 arch/x86/um/Makefile                    |   2 +-
 arch/x86/um/asm/elf.h                   |   4 +-
 arch/x86/um/asm/processor_64.h          |   3 -
 arch/x86/um/ldt.c                       |  47 +-
 arch/x86/um/os-Linux/Makefile           |   1 -
 arch/x86/um/os-Linux/mcontext.c         | 153 ++++-
 arch/x86/um/os-Linux/prctl.c            |  12 -
 arch/x86/um/ptrace_32.c                 |  24 -
 arch/x86/um/ptrace_64.c                 |  26 -
 arch/x86/um/shared/sysdep/mcontext.h    |   9 +
 arch/x86/um/shared/sysdep/ptrace_32.h   |   4 -
 arch/x86/um/shared/sysdep/ptrace_user.h |  12 +-
 arch/x86/um/shared/sysdep/stub-data.h   |  12 +
 arch/x86/um/shared/sysdep/stub.h        |   4 +
 arch/x86/um/shared/sysdep/stub_32.h     |  78 ++-
 arch/x86/um/shared/sysdep/stub_64.h     |  57 +-
 arch/x86/um/stub_32.S                   |  56 --
 arch/x86/um/stub_64.S                   |  50 --
 arch/x86/um/syscalls_64.c               |  62 +-
 arch/x86/um/tls_64.c                    |   2 +-
 51 files changed, 1500 insertions(+), 968 deletions(-)
 create mode 100644 arch/um/kernel/skas/stub.c
 delete mode 100644 arch/x86/um/os-Linux/prctl.c
 create mode 100644 arch/x86/um/shared/sysdep/stub-data.h
 delete mode 100644 arch/x86/um/stub_32.S
 delete mode 100644 arch/x86/um/stub_64.S
Signature · 7 lines
2.38.1


_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um