Skip to content

drm/i915/dvo: Further DVO fixes/cleanups

Ville Syrjala intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10drm/i915/dvo/ch7xxx: Fix suspend/resumedrivers/gpu/drm/i915/display/dvo_ch7xxx.c+20 -22 replies
2/10drm/i915/dvo/sil164: Nuke pointless return statementsdrivers/gpu/drm/i915/display/dvo_sil164.c+0 -21 reply
3/10drm/i915/dvo/sil164: Fix suspend/resumedrivers/gpu/drm/i915/display/dvo_sil164.c+11 -01 reply
4/10drm/i915/dvo: Parametrize DVO/DVO_SRCDIM registersdrivers/gpu/drm/i915/display/intel_dvo.c drivers/gpu/drm/i915/display/intel_dvo_dev.h drivers/gpu/drm/i915/i915_reg.h+37 -541 reply
5/10drm/i915/dvo: Define a few more DVO register bitsdrivers/gpu/drm/i915/display/intel_dvo.c drivers/gpu/drm/i915/i915_reg.h+5 -21 reply
6/10drm/i915/dvo: Rename the "active data order" bitsdrivers/gpu/drm/i915/display/intel_dvo.c drivers/gpu/drm/i915/i915_reg.h+6 -61 reply
7/10drm/i915/dvo: Use REG_BIT() & co. for DVO registersdrivers/gpu/drm/i915/display/intel_dvo.c drivers/gpu/drm/i915/i915_reg.h+37 -332 replies
8/10drm/i915/dvo: Use intel_de_rmw() for DVO enable/disabledrivers/gpu/drm/i915/display/intel_dvo.c+5 -61 reply
9/10drm/i915/dvo: Extract intel_dvo_regs.hdrivers/gpu/drm/i915/display/intel_dvo.c drivers/gpu/drm/i915/display/intel_dvo_regs.h drivers/gpu/drm/i915/i915_reg.h+55 -441 reply
10/10drm/i915/dvo: Log about what was detected on which DVO portdrivers/gpu/drm/i915/display/intel_dvo.c+4 -01 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchJani Nikula
1/10A-b
2/10R-b
3/10A-b
4/10R-b
5/10A-b
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Intel-gfx] [PATCH 00/10] drm/i915/dvo: Further DVO fixes/cleanups

From: Ville Syrjälä <[email protected]>

Decided to do a bit more work on the DVO code. Started with just some register definition cleanups/modernization but ended up actually fixing suspend/resume for a two of my ADD cards.

Ville Syrjälä (10):
drm/i915/dvo/ch7xxx: Fix suspend/resume drm/i915/dvo/sil164: Nuke pointless return statements drm/i915/dvo/sil164: Fix suspend/resume drm/i915/dvo: Parametrize DVO/DVO_SRCDIM registers drm/i915/dvo: Define a few more DVO register bits drm/i915/dvo: Rename the "active data order" bits drm/i915/dvo: Use REG_BIT() & co. for DVO registers drm/i915/dvo: Use intel_de_rmw() for DVO enable/disable drm/i915/dvo: Extract intel_dvo_regs.h drm/i915/dvo: Log about what was detected on which DVO port

 drivers/gpu/drm/i915/display/dvo_ch7xxx.c     | 22 ++++-
 drivers/gpu/drm/i915/display/dvo_sil164.c     | 12 ++-
 drivers/gpu/drm/i915/display/intel_dvo.c      | 87 ++++++++-----------
 drivers/gpu/drm/i915/display/intel_dvo_dev.h  |  7 +-
 drivers/gpu/drm/i915/display/intel_dvo_regs.h | 54 ++++++++++++
 drivers/gpu/drm/i915/i915_reg.h               | 40 ---------
 6 files changed, 126 insertions(+), 96 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_dvo_regs.h
Signature · 1 line
2.37.4