Skip to content

usb: gadget: f_hid: fix f_hidg lifetime vs cdev

John Keeping linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3usb: gadget: f_hid: fix f_hidg lifetime vs cdevdrivers/usb/gadget/function/f_hid.c+28 -243 replies
2/3usb: gadget: f_hid: fix refcount leak on error pathdrivers/usb/gadget/function/f_hid.c+1 -02 replies
3/3usb: gadget: f_hid: tidy error handling in hidg_allocdrivers/usb/gadget/function/f_hid.c+11 -101 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchLee JonesAndrzej Pietrasiewicz
SeriesR-b T-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev

This series arises from the recent thread [1] on lifetime issues.

The main point is the first patch, with the second being an unrelated fix for an issue spotted while working on this. Both of these have
Fixes: tags for backporting to stable.

The final patch tidies up some error handling to hopefully avoid patch 2 issues in the future.

[1] https://lore.kernel.org/r/[email protected]

John Keeping (3):
usb: gadget: f_hid: fix f_hidg lifetime vs cdev
usb: gadget: f_hid: fix refcount leak on error path
usb: gadget: f_hid: tidy error handling in hidg_alloc

 drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++-------------
 1 file changed, 33 insertions(+), 27 deletions(-)
Signature · 1 line
2.38.1