Skip to content

lcore telemetry improvements

Robin Jarry dpdk-dev 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest5 patches 1 replyIn review
  2. v9 posting 2/25 patches 2 repliesSuperseded
  3. v9 posting 1/25 patches 6 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v85 patches21 repliesSuperseded
v75 patches3 repliesSuperseded
v65 patches11 repliesSuperseded
v54 patches25 repliesSuperseded
v34 patches4 repliesSuperseded
v24 patches2 repliesSuperseded
v1 RFC4 patches5 repliesSuperseded

Changes in v10 from the cover letter

- Code style fix
- Fixed reset of total_cycles while lcore is running

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5eal: add lcore info in telemetrylib/eal/common/eal_common_lcore.c+108 -180 replies
2/5eal: report applications lcore usagedoc/guides/rel_notes/release_23_03.rst lib/eal/common/eal_common_lcore.c lib/eal/include/rte_lcore.h +1 more+94 -20 replies
3/5app/testpmd: add dump command for lcoresapp/test-pmd/cmdline.c doc/guides/testpmd_app_ug/testpmd_funcs.rst+10 -00 replies
4/5app/testpmd: report lcore usageapp/test-pmd/noisy_vnf.c app/test-pmd/testpmd.c app/test-pmd/testpmd.h+64 -130 replies
5/5eal: add lcore usage telemetry endpointdoc/guides/rel_notes/release_23_03.rst lib/eal/common/eal_common_lcore.c+63 -20 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMorten BrørupKevin LaatzKonstantin Ananyev
1/5A-b R-b
2/5A-b R-b
3/5A-b R-b A-b
4/5A-b R-b A-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v10 thread

Cover letter [PATCH v10 0/5] lcore telemetry improvements

This is a follow up on previous work by Kevin Laatz:

http://patches.dpdk.org/project/dpdk/list/?series=24658&state=*

This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which leaves the cpu cycles accounting completely up to the application.

For reference, I have implemented a draft patch in OvS to use rte_lcore_register_usage_cb() and report the already available busy cycles information.

https://github.com/rjarry/ovs/commit/643e672fe388e348ea7ccbbda6f5a87a066fd919

v10:

- Code style fix
- Fixed reset of total_cycles while lcore is running

v9:

- Fixed changelog & version.map order.
- Updated with 64-bit integer telemetry functions.
- Refined docstrings (added notice about resetting the callback).
- Fixed accounting of total cycles in testpmd.

Robin Jarry (5):
eal: add lcore info in telemetry
eal: report applications lcore usage
app/testpmd: add dump command for lcores
app/testpmd: report lcore usage
eal: add lcore usage telemetry endpoint

 app/test-pmd/cmdline.c                      |   3 +
 app/test-pmd/noisy_vnf.c                    |   8 +-
 app/test-pmd/testpmd.c                      |  44 +++-
 app/test-pmd/testpmd.h                      |  25 ++-
 doc/guides/rel_notes/release_23_03.rst      |   8 +
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   7 +
 lib/eal/common/eal_common_lcore.c           | 222 ++++++++++++++++++--
 lib/eal/include/rte_lcore.h                 |  48 +++++
 lib/eal/version.map                         |   1 +
 9 files changed, 335 insertions(+), 31 deletions(-)
Signature · 1 line
2.39.1