Skip to content

ASoC: wm_adsp: Report when a control write changes the value

Richard Fitzgerald alsa-devel lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2firmware: cs_dsp: cs_dsp_coeff_write_ctrl() should report changeddrivers/firmware/cirrus/cs_dsp.c+12 -50 replies
2/2ASoC: wm_adsp: Return whether changed when writing controlssound/soc/codecs/wm_adsp.c+18 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] ASoC: wm_adsp: Report when a control write changes the value

Writing a firmware control should be returning 1 if the control value changed, so these two patches add that.

Though this is an ALSA requirement it is also useful for non-ALSA clients of cs_dsp to know if the control value changed, so the main handling is implemented in cs_dsp. TLV controls are specifically an ALSA thing so they are handled specially in wm_adsp.

Simon Trimmer (2):
firmware: cs_dsp: cs_dsp_coeff_write_ctrl() should report changed
ASoC: wm_adsp: Return whether changed when writing controls

 drivers/firmware/cirrus/cs_dsp.c | 17 ++++++++++++-----
 sound/soc/codecs/wm_adsp.c       | 27 ++++++++++++++++++---------
 2 files changed, 30 insertions(+), 14 deletions(-)
Signature · 1 line
2.30.2