Skip to content

Extensions: Review xlate callbacks

Phil Sutter netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13extensions: libebt_mark: Fix mark target xlateextensions/libebt_mark.c+1 -10 replies
2/13extensions: libebt_mark: Fix xlate test caseextensions/libebt_mark.txlate extensions/libebt_mark.xlate+11 -110 replies
3/13extensions: libebt_redirect: Fix xlate return codeextensions/libebt_redirect.c+1 -10 replies
4/13extensions: libipt_ttl: Sanitize xlate callbackextensions/libipt_ttl.c+2 -20 replies
5/13extensions: CONNMARK: Fix xlate callbackextensions/libxt_CONNMARK.c extensions/libxt_CONNMARK.txlate+13 -50 replies
6/13extensions: MARK: Sanitize MARK_xlate()extensions/libxt_MARK.c+2 -00 replies
7/13extensions: TCPMSS: Use xlate callback for IPv6, tooextensions/libxt_TCPMSS.c+1 -00 replies
8/13extensions: TOS: Fix v1 xlate callbackextensions/libxt_TOS.c extensions/libxt_TOS.txlate+29 -130 replies
9/13extensions: ecn: Sanitize xlate callbackextensions/libxt_ecn.c+2 -00 replies
10/13extensions: tcp: Translate TCP option matchextensions/libxt_tcp.c extensions/libxt_tcp.txlate+12 -30 replies
11/13extensions: libebt_log: Add comment to clarify xlate callbackextensions/libebt_log.c+2 -00 replies
12/13extensions: frag: Add comment to clarify xlate callbackextensions/libip6t_frag.c+2 -00 replies
13/13extensions: ipcomp: Add comment to clarify xlate callbackextensions/libxt_ipcomp.c extensions/libxt_ipcomp.c.man+2 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [iptables PATCH 00/13] Extensions: Review xlate callbacks

This is a review of all extensions' xlate callbacks focussing on correctness of operation and return code.

Patches 1 and 2 address ebtables mark target.
Patches 3, 4, 6 and 9 add 'return 0' calls in more or less unlikely cases.
Patch 5 fixes multiple problems in CONNMARK target.
Patches 7, 8 and 10 extend some translations.
The last three patches add comments to help future reviewers asserting code correctness.

Phil Sutter (13):
extensions: libebt_mark: Fix mark target xlate
extensions: libebt_mark: Fix xlate test case
extensions: libebt_redirect: Fix xlate return code
extensions: libipt_ttl: Sanitize xlate callback
extensions: CONNMARK: Fix xlate callback
extensions: MARK: Sanitize MARK_xlate()
extensions: TCPMSS: Use xlate callback for IPv6, too
extensions: TOS: Fix v1 xlate callback
extensions: ecn: Sanitize xlate callback
extensions: tcp: Translate TCP option match
extensions: libebt_log: Add comment to clarify xlate callback
extensions: frag: Add comment to clarify xlate callback
extensions: ipcomp: Add comment to clarify xlate callback

 extensions/libebt_log.c          |  2 ++
 extensions/libebt_mark.c         |  2 +-
 extensions/libebt_mark.txlate    | 11 +++++++++++
 extensions/libebt_mark.xlate     | 11 -----------
 extensions/libebt_redirect.c     |  2 +-
 extensions/libip6t_frag.c        |  2 ++
 extensions/libipt_ttl.c          |  4 ++--
 extensions/libxt_CONNMARK.c      | 15 ++++++++++-----
 extensions/libxt_CONNMARK.txlate |  3 +++
 extensions/libxt_MARK.c          |  2 ++
 extensions/libxt_TCPMSS.c        |  1 +
 extensions/libxt_TOS.c           | 33 ++++++++++++++++++++++----------
 extensions/libxt_TOS.txlate      |  9 ++++++---
 extensions/libxt_ecn.c           |  2 ++
 extensions/libxt_ipcomp.c        |  2 ++
 extensions/libxt_ipcomp.c.man    |  3 ---
 extensions/libxt_tcp.c           |  9 ++++++---
 extensions/libxt_tcp.txlate      |  6 ++++++
 18 files changed, 80 insertions(+), 39 deletions(-)
 create mode 100644 extensions/libebt_mark.txlate
 delete mode 100644 extensions/libebt_mark.xlate
Signature · 1 line
2.38.0