Skip to content

Use ACPI_COMPANION macro to obtain acpi_device in cs35l41_hda

Stefan Binding alsa-devel lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2platform/x86: serial-multi-instantiate: Set fwnode for i2cdrivers/platform/x86/serial-multi-instantiate.c+1 -04 replies
2/2ALSA: hda: cs35l41: Use ACPI_COMPANION to read acpi propertiessound/pci/hda/cs35l41_hda.c+21 -292 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/2] Use ACPI_COMPANION macro to obtain acpi_device in cs35l41_hda

Currently, in cs35l41_hda driver, we use acpi_dev_get_first_match_dev to obtain the acpi_device used to obtain the properties and gpios.

It is better to use the ACPI_COMPANION macro to do this, since it guarentees that we get the correct acpi_device for the device.

However, the cs35l41_hda driver uses the serial-multi-instantiate driver to enumerate, and whilst the ACPI_CONPANION macro works with spi, it does not work with i2c. This is fixed by setting the fwnode for i2c.

Stefan Binding (2):
platform/x86: serial-multi-instantiate: Set fwnode for i2c
ALSA: hda: cs35l41: Use ACPI_COMPANION to read acpi properties

 .../platform/x86/serial-multi-instantiate.c   |  1 +
 sound/pci/hda/cs35l41_hda.c                   | 50 ++++++++-----------
 2 files changed, 22 insertions(+), 29 deletions(-)
Signature · 1 line
2.34.1