gpiolib: don't allow user-space to crash the kernel with hot-unplugs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest2 patches 6 repliesIn review
- v72 patches 2 repliesSuperseded
- v62 patches 5 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 2 patches | 4 replies | Superseded | |
| v4 | 2 patches | 3 replies | Superseded | |
| v3 | 2 patches | 3 replies | Superseded | |
| v2 | 2 patches | 4 replies | Superseded | |
| v1 | 1 patch | 7 replies | Superseded |
Changes in v8 from the cover letter
- don't use down_read_trylock(), just go straight for a full lock
Patches in v8 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | gpiolib: cdev: fix NULL-pointer dereferencesdrivers/ | +27 | 0 replies | |
| 2/2 | gpiolib: protect the GPIO device against being dropped while in use by user-spacedrivers/ drivers/ drivers/ | +161 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Andy Shevchenko | Linus Walleij | Nick Hainke | Kent Gibson |
|---|---|---|---|---|
| 1/2 | R-b | R-b | ||
| 2/2 | R-b | R-b | Co-authored-by | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v8 0/2] gpiolib: don't allow user-space to crash the kernel with hot-unplugs
From: Bartosz Golaszewski <[email protected]>
Linus Torvalds pointed out that using trylock here is wrong. This iteration drops it in favor of unconditional locks but keeps all the fixes that came later.
I will also not send it for this release but make it part of the updates PR for v6.2 to give it some time in next.
v7 -> v8:
- don't use down_read_trylock(), just go straight for a full lock
v6 -> v7:
- fix a build issue with CDEV_V1 code disabled (giving credit to Nick Hainke)
- protect the gdev->chip also in gpio_chrdev_open()
v5 -> v6:
- signal an error in poll callbacks instead of returning 0 which would make the user-space assume a timeout occurred (which could lead to user-space spinning a timeout loop forever)
v4 -> v5:
- try to acquire the semaphore for reading and bail out of syscall callbacks immediately in case of lock contention
v3 -> v4:
- use function typedefs to make code cleaner
- add a blank line after down_write()
v2 -> v3:
- drop the helper variable in patch 1/2 as we won't be using it in 2/2
- refactor patch 2/2 to use locking wrappers around the syscall callbacks
v1 -> v2:
- add missing gdev->chip checks in patch 1/2
- add a second patch that protects the structures that can be accessed by user-space calls against concurrent removal
Bartosz Golaszewski (2):
gpiolib: cdev: fix NULL-pointer dereferences
gpiolib: protect the GPIO device against being dropped while in use by
user-space
drivers/gpio/gpiolib-cdev.c | 204 +++++++++++++++++++++++++++++++----- drivers/gpio/gpiolib.c | 4 + drivers/gpio/gpiolib.h | 5 + 3 files changed, 188 insertions(+), 25 deletions(-)
Signature · 1 line
2.37.2