RFC not-self neverallow support
Get series with b4
b4 am [email protected]Versions newest first
- v4 RFC Latest6 patches 13 repliesIn review
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | libsepol: Add not self support for neverallow ruleslibsepol/ libsepol/ libsepol/ | +129 | 2 replies | |
| 2/6 | libsepol/cil: Add notself and minusself support to CILlibsepol/ libsepol/ libsepol/ +4 more | +300 | 3 replies | |
| 3/6 | checkpolicy: add not-self neverallow supportcheckpolicy/ checkpolicy/ | +45 | 2 replies | |
| 4/6 | libsepol/tests: add tests for not self neverallow ruleslibsepol/ libsepol/ | +445 | 2 replies | |
| 5/6 | libsepol/tests: add tests for minus self neverallow ruleslibsepol/ libsepol/ | +443 | 2 replies | |
| 6/6 | libsepol: update CIL generation for trivial not-self ruleslibsepol/ | +26 | 2 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | James Carter |
|---|---|
| 1/6 | A-b |
| 2/6 | |
| 3/6 | A-b |
| 4/6 | A-b |
| 5/6 | A-b |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH v4 0/6] not-self neverallow support
Add support for using negated or complemented self in the target type of neverallow rules.
Some Refpolicy examples:
neverallow * ~self:{ capability cap_userns capability2 cap2_userns } *;
neverallow domain { domain -self -dockerc_t }:dir create;
# no violations
neverallow domain { domain -dockerc_t }:file ~{ append read_file_perms write };
libsepol.report_failure: neverallow on line 584 of policy/modules/kernel/kernel.te (or line 31357 of policy.conf) violated by allow sysadm_t httpd_bugzilla_script_t:file { create setattr relabelfrom relabelto unlink link rename };
libsepol.report_failure: neverallow on line 584 of policy/modules/kernel/kernel.te (or line 31357 of policy.conf) violated by allow spc_t spc_t:file { create };
libsepol.report_failure: neverallow on line 584 of policy/modules/kernel/kernel.te (or line 31357 of policy.conf) violated by allow container_t container_t:file { create };
libsepol.report_failure: neverallow on line 584 of policy/modules/kernel/kernel.te (or line 31357 of policy.conf) violated by allow chromium_t chromium_t:file { create };
libsepol.report_failure: neverallow on line 584 of policy/modules/kernel/kernel.te (or line 31357 of policy.conf) violated by allow spc_user_t spc_user_t:file { create };
libsepol.report_failure: neverallow on line 582 of policy/modules/kernel/kernel.te (or line 31355 of policy.conf) violated by allow sysadm_t httpd_bugzilla_script_t:dir { create };
neverallow domain { domain -self -dockerc_t }:file ~{ append read_file_perms write };
libsepol.report_failure: neverallow on line 583 of policy/modules/kernel/kernel.te (or line 31356 of policy.conf) violated by allow sysadm_t httpd_bugzilla_script_t:file { create setattr relabelfrom relabelto unlink link rename };
libsepol.report_failure: neverallow on line 582 of policy/modules/kernel/kernel.te (or line 31355 of policy.conf) violated by allow sysadm_t httpd_bugzilla_script_t:dir { create };Using negated self in a complement, ~{ domain -self }, is not supported.
Initial CIL support in the form of
(allow TYPE1 notself (CLASS (PERM)))
(allow TYPE1 minusself (CLASS (PERM)))
is included from a patchset by James Carter.
More complex targets are not yet supported in CIL and generating a CIL policy file from modular policies including such rules will fail with an appropriate message.
RFC v3: https://lore.kernel.org/selinux/[email protected]/
Improved rebase and initial CIL work by James Carter: https://lore.kernel.org/selinux/[email protected]/
Christian Göttsche (5):
libsepol: Add not self support for neverallow rules
checkpolicy: add not-self neverallow support libsepol/tests: add tests for not self neverallow rules libsepol/tests: add tests for minus self neverallow rules
libsepol: update CIL generation for trivial not-self rules
James Carter (1):
libsepol/cil: Add notself and minusself support to CIL
checkpolicy/policy_define.c | 46 ++- checkpolicy/test/dismod.c | 6 +- libsepol/cil/src/cil.c | 12 + libsepol/cil/src/cil_binary.c | 91 ++++- libsepol/cil/src/cil_build_ast.c | 10 +- libsepol/cil/src/cil_find.c | 206 ++++++++-- libsepol/cil/src/cil_internal.h | 4 + libsepol/cil/src/cil_resolve_ast.c | 4 + libsepol/cil/src/cil_verify.c | 3 +- libsepol/include/sepol/policydb/policydb.h | 3 +- libsepol/src/assertion.c | 144 +++++-- libsepol/src/module_to_cil.c | 30 +- libsepol/src/policydb_validate.c | 9 + .../test-neverallow/policy_minus_self.conf | 369 +++++++++++++++++ .../test-neverallow/policy_not_self.conf | 370 ++++++++++++++++++ libsepol/tests/test-neverallow.c | 149 +++++++ 16 files changed, 1388 insertions(+), 68 deletions(-) create mode 100644 libsepol/tests/policies/test-neverallow/policy_minus_self.conf create mode 100644 libsepol/tests/policies/test-neverallow/policy_not_self.conf
Signature · 1 line
2.38.1