Fix command line underflows and out-of-bounds write
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | vga_text: Prevent out-of-bounds writes to VGA text buffergrub-core/ | +2 | 0 replies | |
| 2/2 | cmdline: Fix two related integer underflowsgrub-core/ | +6 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Daniel Kiper |
|---|---|
| Series | R-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] Fix command line underflows and out-of-bounds write
Hello everyone,
I was messing around in the GRUB command line and I found two related integer underflows that occur on all platforms. I also found an out-of-bounds write that occurs only on i386 systems using the VGA text terminal. This out-of-bounds write is caused by one of the underflows, but I've included 2 patches so that each bug is fixed.
This is my first patch submission for GRUB, so please let me know if there is anything I should change or fix. I really appreciate feedback!
Thanks to Daniel Kiper for helping me figure out the process of submitting a patch. :)
Ryan Cohen (2):
vga_text: Prevent out-of-bounds writes to VGA text buffer
cmdline: Fix two related integer underflows
grub-core/normal/cmdline.c | 7 ++++++- grub-core/term/i386/pc/vga_text.c | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-)
Signature · 1 line
2.38.1