Skip to content

t1301: various updates

Jiang Xin git 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 0 repliesNew
  2. v23 patches 6 repliesSuperseded
  3. v14 patches 6 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3t1301: fix wrong template dir for git-initt/t1301-shared-repo.sh+2 -10 replies
2/3t1301: use test_when_finished for cleanupt/t1301-shared-repo.sh+5 -30 replies
3/3t1301: do not change $CWD in "shared=all" test caset/t1301-shared-repo.sh+1 -20 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchJunio C HamanoÆvar Arnfjörð Bjarmason
SeriesHelped-by
1/3
2/3Helped-by
3/3Helped-by Helped-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] t1301: various updates

From: Jiang Xin <[email protected]>

Various updates for t1301:

* t1301: fix wrong template dir for git-init
* t1301: use test_when_finished for cleanup
* t1301: do not change $CWD in "shared=all" test case

## range-diff v2...v3

1:  bc68ffb41c = 1:  7a66766a10 t1301: fix wrong template dir for git-init
2:  ae2b2f8afc = 2:  97eefb1e67 t1301: use test_when_finished for cleanup
3:  f1bf255e5a ! 3:  9575f2eb1c t1301: do not change $CWD in "shared=all" test case

@@ Commit message
So it is a safe change for us to run the test case "shared=all" in current repository instead of creating and changing to "sub".

- For the next test case, we no longer run it in the "sub" repository
- which is initialized from an empty template, we should not assume the
- path ".git/info" is missing. So add option "-p" to mkdir.
+ For the next test case, the path ".git/info" is assumed to be missing,
+ but we no longer run the test case in the "sub" repository which is
+ initialized from an empty template. In order for the test case to run
+ properly, we can set "TEST_CREATE_REPO_NO_TEMPLATE=1" to initialize the
+ default repository without a template.

+ Helped-by: Ævar Arnfjörð Bjarmason <[email protected]>

## t/t1301-shared-repo.sh ##
+@@ t/t1301-shared-repo.sh: test_description='Test shared repository initialization'
+ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
+ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
+
++TEST_CREATE_REPO_NO_TEMPLATE=1
+ . ./test-lib.sh
+
+ # Remove a default ACL from the test dir if possible.
@@ t/t1301-shared-repo.sh: do
done

@@ t/t1301-shared-repo.sh: do
git init --template= --shared=all &&
test 2 = $(git config core.sharedrepository)
'
-@@ t/t1301-shared-repo.sh: test_expect_success POSIXPERM 'update-server-info honors core.sharedRepository'
- git add a1 &&
- test_tick &&
- git commit -m a1 &&
-- mkdir .git/info &&
-+ mkdir -p .git/info &&
- umask 0277 &&
- git update-server-info &&
- actual="$(ls -l .git/info/refs)" &&

--

Jiang Xin (3):
t1301: fix wrong template dir for git-init
t1301: use test_when_finished for cleanup
t1301: do not change $CWD in "shared=all" test case

 t/t1301-shared-repo.sh | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
Signature · 1 line
2.39.0.rc0