Skip to content

pci: Move and clean up monitor command code

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12pci: Clean up a few things checkpatch.pl would flag later onhw/pci/pci.c+6 -31 reply
2/12pci: Move QMP commands to new hw/pci/pci-qmp-cmds.chw/pci/meson.build hw/pci/pci-internal.h hw/pci/pci-qmp-cmds.c +1 more+226 -1840 replies
3/12pci: Move HMP commands from monitor/ to new hw/pci/pci-hmp-cmds.chw/pci/meson.build hw/pci/pci-hmp-cmds.c monitor/hmp-cmds.c+127 -1072 replies
4/12pci: Make query-pci stub consistent with the real onehw/pci/pci-hmp-cmds.c hw/pci/pci-stub.c+1 -101 reply
5/12pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCIhw/pci/meson.build hw/pci/pci-stub.c+6 -16 replies
6/12pci: Deduplicate get_class_desc()hw/pci/pci.c+3 -60 replies
7/12pci: Move pcibus_dev_print() to pci-hmp-cmds.chw/pci/pci-hmp-cmds.c hw/pci/pci-internal.h hw/pci/pci.c+39 -381 reply
8/12pci: Fix silent truncation of pcie_aer_inject_error argumenthw/pci/pcie_aer.c+6 -42 replies
9/12pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.chw/pci/pci-hmp-cmds.c hw/pci/pci-internal.h hw/pci/pci-stub.c +3 more+114 -1152 replies
10/12pci: Inline do_pcie_aer_inject_error() into its only callerhw/pci/pci-hmp-cmds.c+6 -351 reply
11/12pci: Rename hmp_pcie_aer_inject_error()'s local variable @errhw/pci/pci-hmp-cmds.c+17 -171 reply
12/12pci: Improve do_pcie_aer_inject_error()'s error messageshw/pci/pci-hmp-cmds.c+15 -151 reply

Reviews trailers per patch

8 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéMichael S. TsirkinDr. David Alan Gilbert
SeriesR-b
1/12R-b
2/12
3/12R-b R-b
4/12R-b
5/12
6/12
7/12R-b
8/12
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/12] pci: Move and clean up monitor command code

This is mainly about splitting off monitor-related code. There's also a few UI fixes to HMP command pcie_aer_inject_error. One UI issue
remains: when the second argument is symbolic (found in table pcie_aer_error_list[]), then any -c is silently ignored. Should it be rejected? Should it override the value from the table?

Markus Armbruster (12):
pci: Clean up a few things checkpatch.pl would flag later on
pci: Move QMP commands to new hw/pci/pci-qmp-cmds.c
pci: Move HMP commands from monitor/ to new hw/pci/pci-hmp-cmds.c
pci: Make query-pci stub consistent with the real one
pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI
pci: Deduplicate get_class_desc()
pci: Move pcibus_dev_print() to pci-hmp-cmds.c
pci: Fix silent truncation of pcie_aer_inject_error argument
pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.c
pci: Inline do_pcie_aer_inject_error() into its only caller
pci: Rename hmp_pcie_aer_inject_error()'s local variable @err
pci: Improve do_pcie_aer_inject_error()'s error messages

 hw/pci/pci-internal.h   |  25 +++++
 include/monitor/hmp.h   |   1 +
 include/sysemu/sysemu.h |   3 -
 hw/pci/pci-hmp-cmds.c   | 234 ++++++++++++++++++++++++++++++++++++++++
 hw/pci/pci-qmp-cmds.c   | 201 ++++++++++++++++++++++++++++++++++
 hw/pci/pci-stub.c       |   9 +-
 hw/pci/pci.c            | 226 +-------------------------------------
 hw/pci/pcie_aer.c       | 113 +------------------
 monitor/hmp-cmds.c      | 107 ------------------
 hw/pci/meson.build      |   2 +
 10 files changed, 476 insertions(+), 445 deletions(-)
 create mode 100644 hw/pci/pci-internal.h
 create mode 100644 hw/pci/pci-hmp-cmds.c
 create mode 100644 hw/pci/pci-qmp-cmds.c
Signature · 1 line
2.37.3