pci: Move and clean up monitor command code
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 21 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | pci: Clean up a few things checkpatch.pl would flag later onhw/ | +6 | 1 reply | |
| 2/12 | pci: Move QMP commands to new hw/pci/pci-qmp-cmds.chw/ hw/ hw/ +1 more | +226 | 0 replies | |
| 3/12 | pci: Move HMP commands from monitor/ to new hw/pci/pci-hmp-cmds.chw/ hw/ monitor/ | +127 | 2 replies | |
| 4/12 | pci: Make query-pci stub consistent with the real onehw/ hw/ | +1 | 1 reply | |
| 5/12 | pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCIhw/ hw/ | +6 | 6 replies | |
| 6/12 | pci: Deduplicate get_class_desc()hw/ | +3 | 0 replies | |
| 7/12 | pci: Move pcibus_dev_print() to pci-hmp-cmds.chw/ hw/ hw/ | +39 | 1 reply | |
| 8/12 | pci: Fix silent truncation of pcie_aer_inject_error argumenthw/ | +6 | 2 replies | |
| 9/12 | pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.chw/ hw/ hw/ +3 more | +114 | 2 replies | |
| 10/12 | pci: Inline do_pcie_aer_inject_error() into its only callerhw/ | +6 | 1 reply | |
| 11/12 | pci: Rename hmp_pcie_aer_inject_error()'s local variable @errhw/ | +17 | 1 reply | |
| 12/12 | pci: Improve do_pcie_aer_inject_error()'s error messageshw/ | +15 | 1 reply |
Reviews trailers per patch
8 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Philippe Mathieu-Daudé | Michael S. Tsirkin | Dr. David Alan Gilbert |
|---|---|---|---|
| Series | R-b | ||
| 1/12 | R-b | ||
| 2/12 | |||
| 3/12 | R-b | R-b | |
| 4/12 | R-b | ||
| 5/12 | |||
| 6/12 | |||
| 7/12 | R-b | ||
| 8/12 | |||
| 9/12 | R-b | ||
| 10/12 | R-b | ||
| 11/12 | R-b | ||
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/12] pci: Move and clean up monitor command code
This is mainly about splitting off monitor-related code. There's also a few UI fixes to HMP command pcie_aer_inject_error. One UI issue
remains: when the second argument is symbolic (found in table pcie_aer_error_list[]), then any -c is silently ignored. Should it be rejected? Should it override the value from the table?
Markus Armbruster (12):
pci: Clean up a few things checkpatch.pl would flag later on
pci: Move QMP commands to new hw/pci/pci-qmp-cmds.c
pci: Move HMP commands from monitor/ to new hw/pci/pci-hmp-cmds.c
pci: Make query-pci stub consistent with the real one
pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI
pci: Deduplicate get_class_desc()
pci: Move pcibus_dev_print() to pci-hmp-cmds.c
pci: Fix silent truncation of pcie_aer_inject_error argument
pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.c
pci: Inline do_pcie_aer_inject_error() into its only caller
pci: Rename hmp_pcie_aer_inject_error()'s local variable @err
pci: Improve do_pcie_aer_inject_error()'s error messages
hw/pci/pci-internal.h | 25 +++++ include/monitor/hmp.h | 1 + include/sysemu/sysemu.h | 3 - hw/pci/pci-hmp-cmds.c | 234 ++++++++++++++++++++++++++++++++++++++++ hw/pci/pci-qmp-cmds.c | 201 ++++++++++++++++++++++++++++++++++ hw/pci/pci-stub.c | 9 +- hw/pci/pci.c | 226 +------------------------------------- hw/pci/pcie_aer.c | 113 +------------------ monitor/hmp-cmds.c | 107 ------------------ hw/pci/meson.build | 2 + 10 files changed, 476 insertions(+), 445 deletions(-) create mode 100644 hw/pci/pci-internal.h create mode 100644 hw/pci/pci-hmp-cmds.c create mode 100644 hw/pci/pci-qmp-cmds.c
Signature · 1 line
2.37.3