Skip to content

selftests/bpf: Remove unnecessary mount/umount dance

Martin KaFai Lau bpf netdev 1 version Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyApplied 7/7

Patches in v1 All 7 applied

#Subject and filesSizeRepliesApplied
1/7selftests/bpf: Use if_nametoindex instead of reading the /sys/net/class/*/ifindextools/testing/selftests/bpf/prog_tests/tc_redirect.c+18 -280 repliesApplied
2/7selftests/bpf: Avoid pinning bpf prog in the tc_redirect_dtime testtools/testing/selftests/bpf/prog_tests/tc_redirect.c+100 -490 repliesApplied
3/7selftests/bpf: Avoid pinning bpf prog in the tc_redirect_peer_l3 testtools/testing/selftests/bpf/prog_tests/tc_redirect.c+12 -200 repliesApplied
4/7selftests/bpf: Avoid pinning bpf prog in the netns_load_bpf() callerstools/testing/selftests/bpf/prog_tests/tc_redirect.c+27 -560 repliesApplied
5/7selftests/bpf: Remove the "/sys" mount and umount dance in {open,close}_netnstools/testing/selftests/bpf/network_helpers.c+5 -460 repliesApplied
6/7selftests/bpf: Remove serial from tests using {open,close}_netnstools/testing/selftests/bpf/prog_tests/empty_skb.c tools/testing/selftests/bpf/prog_tests/tc_redirect.c tools/testing/selftests/bpf/prog_tests/test_tunnel.c +2 more+5 -50 repliesApplied
7/7selftests/bpf: Avoid pinning prog when attaching to tc ingress in btf_skc_cls_ingresstools/testing/selftests/bpf/prog_tests/btf_skc_cls_ingress.c+10 -150 repliesApplied

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStanislav Fomichev
SeriesA-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next 0/7] selftests/bpf: Remove unnecessary mount/umount dance

From: Martin KaFai Lau <[email protected]>

Some of the tests do mount/umount dance when switching netns.
It is error-prone like https://lore.kernel.org/bpf/[email protected]/

Another issue is, there are many left over after running some of the tests:
#> mount | egrep sysfs | wc -l
19

Instead of further debugging this dance, this set is to avoid the needs to do this remounting altogether. It will then allow those tests to be run in parallel again.

Martin KaFai Lau (7):
selftests/bpf: Use if_nametoindex instead of reading the
/sys/net/class/*/ifindex
selftests/bpf: Avoid pinning bpf prog in the tc_redirect_dtime test selftests/bpf: Avoid pinning bpf prog in the tc_redirect_peer_l3 test selftests/bpf: Avoid pinning bpf prog in the netns_load_bpf() callers selftests/bpf: Remove the "/sys" mount and umount dance in
{open,close}_netns
selftests/bpf: Remove serial from tests using {open,close}_netns selftests/bpf: Avoid pinning prog when attaching to tc ingress in
btf_skc_cls_ingress

 tools/testing/selftests/bpf/network_helpers.c |  51 +--
 .../bpf/prog_tests/btf_skc_cls_ingress.c      |  25 +-
 .../selftests/bpf/prog_tests/empty_skb.c      |   2 +-
 .../selftests/bpf/prog_tests/tc_redirect.c    | 314 +++++++++---------
 .../selftests/bpf/prog_tests/test_tunnel.c    |   2 +-
 .../bpf/prog_tests/xdp_do_redirect.c          |   2 +-
 .../selftests/bpf/prog_tests/xdp_synproxy.c   |   2 +-
 7 files changed, 178 insertions(+), 220 deletions(-)
Signature · 1 line
2.30.2