Skip to content

drm/rockchip: vop2: add support for the rgb output block

Michael Riesch dri-devel linux-arm-kernel linux-devicetree linux-rockchip lkml llvm 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 6 repliesApplied
  2. v26 patches 2 repliesSuperseded
  3. v15 patches 5 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/6drm/rockchip: vop2: initialize possible_crtcs properlydrivers/gpu/drm/rockchip/rockchip_drm_vop2.c+4 -32 replies
2/6drm/rockchip: rgb: embed drm_encoder into rockchip_encoderdrivers/gpu/drm/rockchip/rockchip_rgb.c+5 -50 replies
3/6drm/rockchip: rgb: add video_port parameter to init functiondrivers/gpu/drm/rockchip/rockchip_drm_vop.c drivers/gpu/drm/rockchip/rockchip_rgb.c drivers/gpu/drm/rockchip/rockchip_rgb.h+10 -70 replies
4/6drm/rockchip: vop2: use symmetric function pair vop2_{create,destroy}_crtcsdrivers/gpu/drm/rockchip/rockchip_drm_vop2.c+16 -150 replies
5/6drm/rockchip: vop2: add support for the rgb output blockdrivers/gpu/drm/rockchip/rockchip_drm_vop2.c+44 -01 reply
6/6arm64: dts: rockchip: add pinctrls for 16-bit/18-bit rgb interface to rk356xarch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi+94 -00 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSascha Hauer
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/6] drm/rockchip: vop2: add support for the rgb output block

Hi all,

This series adds support for the RGB output block that can be found in the Rockchip Video Output Processor (VOP) 2. Version 2 of this series incorporates the feedback by Dan Carpenter and Sascha Hauer. Version 3 fixes a dumb mistake pointed out by Sascha :-) Thanks for your comments!

Patches 1-4 clean up the code and make it more general.

Patch 5 activates the support for the RGB output block in the VOP2 driver.

Patch 6 adds pinctrls for the 16-bit and 18-bit RGB data lines.

Tested on a custom board featuring the RK3568 SoC with a 18-bit RGB display.

Looking forward to your comments!

Best regards,
Michael

Michael Riesch (6):
drm/rockchip: vop2: initialize possible_crtcs properly drm/rockchip: rgb: embed drm_encoder into rockchip_encoder drm/rockchip: rgb: add video_port parameter to init function drm/rockchip: vop2: use symmetric function pair
vop2_{create,destroy}_crtcs
drm/rockchip: vop2: add support for the rgb output block
arm64: dts: rockchip: add pinctrls for 16-bit/18-bit rgb interface to

    rk356x
 .../boot/dts/rockchip/rk3568-pinctrl.dtsi     | 94 +++++++++++++++++++
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c   |  2 +-
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c  | 80 ++++++++++++----
 drivers/gpu/drm/rockchip/rockchip_rgb.c       | 19 ++--
 drivers/gpu/drm/rockchip/rockchip_rgb.h       |  6 +-
 5 files changed, 172 insertions(+), 29 deletions(-)

base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2

Signature · 1 line
2.30.2