Skip to content

lib: add function to request migration

Nico Boehr kvm 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 3 repliesIn review
  2. v24 patches 2 repliesSuperseded
  3. v14 patches 6 repliesSuperseded

Changes in v3 from the cover letter

---
* s390x: remove unneeded parenthesis (thanks Claudio)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4lib: add function to request migrationlib/migrate.c lib/migrate.h+43 -00 replies
2/4powerpc: use migrate_once() in migration testspowerpc/Makefile.common powerpc/sprs.c+3 -20 replies
3/4s390x: use migrate_once() in migration testss390x/Makefile s390x/migration-cmm.c s390x/migration-sck.c +2 more+19 -371 reply
4/4arm: use migrate_once() in migration testsarm/Makefile.common arm/debug.c arm/gic.c+20 -470 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAndrew JonesThomas HuthClaudio Imbrenda
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [kvm-unit-tests PATCH v3 0/4] lib: add function to request migration

v2->v3:
---
* s390x: remove unneeded parenthesis (thanks Claudio)

v1->v2:
---
* arm: commit message gib->gic (thanks Andrew)
* arm: remove unneeded {} (thanks Andrew)
* s390x: make patch less intrusive (thanks Claudio)

With this series, I pick up a suggestion Claudio has brought up in my CMM-migration series[1].

Migration tests can ask migrate_cmd to migrate them to a new QEMU process. Requesting migration and waiting for completion is hence a common pattern which is repeated all over the code base. Add a function which does all of that to avoid repetition.

Since migrate_cmd currently can only migrate exactly once, this function is called migrate_once() and is a no-op when it has been called before. This can simplify the control flow, especially when tests are skipped.

[1] https://lore.kernel.org/kvm/20221125154646.5974cb52@p-imbrenda/

Nico Boehr (4):
lib: add function to request migration
powerpc: use migrate_once() in migration tests
s390x: use migrate_once() in migration tests
arm: use migrate_once() in migration tests

 arm/Makefile.common     |  1 +
 powerpc/Makefile.common |  1 +
 s390x/Makefile          |  1 +
 lib/migrate.h           |  9 ++++++++
 lib/migrate.c           | 34 ++++++++++++++++++++++++++++
 arm/debug.c             | 17 +++++---------
 arm/gic.c               | 49 ++++++++++++-----------------------------
 powerpc/sprs.c          |  4 ++--
 s390x/migration-cmm.c   | 24 ++++++--------------
 s390x/migration-sck.c   |  4 ++--
 s390x/migration-skey.c  | 20 ++++++-----------
 s390x/migration.c       |  7 ++----
 12 files changed, 85 insertions(+), 86 deletions(-)
 create mode 100644 lib/migrate.h
 create mode 100644 lib/migrate.c
Signature · 1 line
2.36.1