Skip to content

Fix for shell testsuite '-V' option

Phil Sutter netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9tests: shell: Fix valgrind mode for 0008-unprivileged_0iptables/tests/shell/run-tests.sh+2 -10 replies
2/9iptables-restore: Free handle with --test alsoiptables/iptables-restore.c+2 -20 replies
3/9iptables-xml: Free allocated chain stringsiptables/iptables-xml.c+5 -50 replies
4/9nft: Plug memleak in nft_rule_zero_counters()iptables/nft.c+3 -20 replies
5/9iptables: Plug memleaks in print_firewall()iptables/ip6tables.c iptables/iptables.c+12 -00 replies
6/9xtables: Introduce xtables_clear_iptables_command_state()iptables/nft-arp.c iptables/nft-ipv4.c iptables/nft-ipv6.c +6 more+27 -230 replies
7/9iptables: Properly clear iptables_command_state objectiptables/ip6tables.c iptables/iptables.c+2 -40 replies
8/9xshared: Free data after printing helpiptables/xshared.c+3 -00 replies
9/9libiptc: Eliminate garbage accesslibiptc/libiptc.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [iptables PATCH 0/9] Fix for shell testsuite '-V' option

When running the testsuite in "valgrind mode", numerous cases of lost memory and still reachable at program exit are reported. Address them all plus libiptc's access of uninitialized memory.

Phil Sutter (9):
tests: shell: Fix valgrind mode for 0008-unprivileged_0
iptables-restore: Free handle with --test also
iptables-xml: Free allocated chain strings
nft: Plug memleak in nft_rule_zero_counters()
iptables: Plug memleaks in print_firewall()
xtables: Introduce xtables_clear_iptables_command_state()
iptables: Properly clear iptables_command_state object
xshared: Free data after printing help
libiptc: Eliminate garbage access

 iptables/ip6tables.c              |  9 +++++++--
 iptables/iptables-restore.c       |  4 ++--
 iptables/iptables-xml.c           | 10 +++++-----
 iptables/iptables.c               |  9 +++++++--
 iptables/nft-arp.c                |  4 ++--
 iptables/nft-ipv4.c               |  4 ++--
 iptables/nft-ipv6.c               |  4 ++--
 iptables/nft-shared.c             | 14 --------------
 iptables/nft-shared.h             |  1 -
 iptables/nft.c                    |  5 +++--
 iptables/tests/shell/run-tests.sh |  3 ++-
 iptables/xshared.c                | 20 ++++++++++++++++++++
 iptables/xshared.h                |  2 ++
 iptables/xtables-translate.c      |  2 +-
 iptables/xtables.c                |  2 +-
 libiptc/libiptc.c                 |  4 ++--
 16 files changed, 58 insertions(+), 39 deletions(-)
Signature · 1 line
2.38.0