Skip to content

Putting some basic order on isa extension lists

Conor Dooley linux-doc linux-riscv lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3RISC-V: clarify ISA string ordering rules in cpu.carch/riscv/kernel/cpu.c+36 -132 replies
2/3RISC-V: resort all extensions in consistent ordersarch/riscv/include/asm/hwcap.h arch/riscv/kernel/cpu.c arch/riscv/kernel/cpufeature.c+13 -96 replies
3/3Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfoDocumentation/riscv/uabi.rst+42 -06 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchAndrew JonesHeiko Stuebner
1/3R-b
2/3R-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/3] Putting some basic order on isa extension lists

From: Conor Dooley <[email protected]>

I don't know for sure that I have not re-ordered something that is sacrosanct. It seems that all of these are internal use structs, and should be okay, barring the obvious exception of the, intentionally re-ordered, isa_ext_arr.

With that caveat out of the way - all I did here was try to make things consistent so that it'd be easier to point patch submitters at a "do this order please".

I never know which of these can be moved without breaking stuff - but they all seem to be internal use stuff since they're not in uapi?

For v2, I added another path with some uapi docs & switched to Drew's suggested ordering of alphabetically, except in the /proc/cpuinfo array, as per the discussion today in the pw-sync call. I also added a sprinkling of comments around which things should be sorted in which way.

I guess consider this an RFS, with the S being Screaming in the case of me doing something you abhor :)

Thanks,
Conor.

Conor Dooley (3):
RISC-V: clarify ISA string ordering rules in cpu.c
RISC-V: resort all extensions in consistent orders
Documentation: riscv: add a section about ISA string ordering in
/proc/cpuinfo

 Documentation/riscv/uabi.rst   | 42 +++++++++++++++++++++++++++
 arch/riscv/include/asm/hwcap.h | 12 ++++----
 arch/riscv/kernel/cpu.c        | 53 ++++++++++++++++++++++++----------
 arch/riscv/kernel/cpufeature.c |  6 ++--
 4 files changed, 91 insertions(+), 22 deletions(-)
Signature · 1 line
2.38.1