ui: Move and clean up monitor command code
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest17 patches 7 repliesIn review
- v318 patches 19 repliesSuperseded
- v2 posting 2/214 patches 12 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 posting 1/2 | 13 patches | 0 replies | Superseded | |
| v1 | 9 patches | 21 replies | Superseded |
Changes in v4 from the cover letter
* PATCH 02: Use strtoi() [David]
* PATCH 11: Old PATCH 12 squashed in
* PATCH 15+16: Swapped for a simple new PATCH 16
* PATCH 16: Use Error properly in qemu_mouse_set() [Daniel], return bool [Philippe]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | ui: Check numeric part of expire_password argument @time properlymonitor/ | +15 | 0 replies | |
| 2/17 | ui: Fix silent truncation of numeric keys in HMP sendkeymonitor/ | +6 | 1 reply | |
| 3/17 | ui/spice: Require spice-protocol >= 0.14.0meson.build ui/ | +1 | 0 replies | |
| 4/17 | Revert "hmp: info spice: take out webdav"monitor/ | +0 | 0 replies | |
| 5/17 | ui/spice: Require spice-server >= 0.14.0chardev/ hw/ hw/ +3 more | +3 | 0 replies | |
| 6/17 | ui/spice: QXLInterface method set_mm_time() is now dead, drophw/ hw/ include/ +1 more | +0 | 0 replies | |
| 7/17 | ui/spice: Give hmp_info_spice()'s channel_names[] static linkagemonitor/ | +1 | 0 replies | |
| 8/17 | ui: Clean up a few things checkpatch.pl would flag later onmonitor/ monitor/ | +15 | 0 replies | |
| 9/17 | ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.cmonitor/ ui/ ui/ | +137 | 0 replies | |
| 10/17 | ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.cinclude/ monitor/ ui/ | +100 | 0 replies | |
| 11/17 | ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.cinclude/ monitor/ monitor/ +2 more | +425 | 0 replies | |
| 12/17 | ui: Improve "change vnc" error reportingmonitor/ | +4 | 0 replies | |
| 13/17 | ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.cinclude/ monitor/ monitor/ +1 more | +42 | 0 replies | |
| 14/17 | ui: Reduce nesting in hmp_change_vnc() slightlyui/ | +7 | 0 replies | |
| 15/17 | ui: Don't check for mode change after mouse_set errorui/ | +1 | 2 replies | |
| 16/17 | ui: Split hmp_mouse_set() and move the HMP part to ui/include/ include/ monitor/ +2 more | +17 | 2 replies | |
| 17/17 | ui: Simplify control flow in qemu_mouse_set()ui/ | +11 | 2 replies |
Reviews trailers per patch
All 17 patches have a Reviewed-by or Acked-by.
| Patch | Daniel P. Berrangé | Philippe Mathieu-Daudé |
|---|---|---|
| 1/17 | R-b | |
| 2/17 | R-b | R-b |
| 3/17 | R-b | R-b |
| 4/17 | R-b | |
| 5/17 | R-b | R-b |
| 6/17 | R-b | R-b |
| 7/17 | R-b | |
| 8/17 | R-b | R-b |
| 9/17 | R-b | R-b |
| 10/17 | R-b | |
| 11/17 | R-b | R-b |
| 12/17 | R-b | R-b |
| 13/17 | R-b | R-b |
| 14/17 | R-b | R-b |
| 15/17 | R-b | R-b |
| 16/17 | R-b | R-b |
| 17/17 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/17] ui: Move and clean up monitor command code
This is mainly about splitting off monitor-related code. There's also a minimum Spice version bump, and a few UI improvements to HMP commands sendkey, change vnc, and info spice.
v4:
* PATCH 02: Use strtoi() [David]
* PATCH 11: Old PATCH 12 squashed in
* PATCH 15+16: Swapped for a simple new PATCH 16
* PATCH 16: Use Error properly in qemu_mouse_set() [Daniel], return bool [Philippe]
v3:
* Rebased, straighforward conflicts with "qapi: Elide redundant has_FOO in generated C" (merge commit ae2b87341b5)
* PATCH 09: Commit message pasto fixed
* PATCH 11: Comment tweaked
* PATCH 12: New
* PATCH 13: protocol_table[] made const [Philippe], #include tweaked
* PATCH 16-18: New
Markus Armbruster (17):
ui: Check numeric part of expire_password argument @time properly
ui: Fix silent truncation of numeric keys in HMP sendkey ui/spice: Require spice-protocol >= 0.14.0
Revert "hmp: info spice: take out webdav"
ui/spice: Require spice-server >= 0.14.0
ui/spice: QXLInterface method set_mm_time() is now dead, drop ui/spice: Give hmp_info_spice()'s channel_names[] static linkage
ui: Clean up a few things checkpatch.pl would flag later on
ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c
ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c
ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c
ui: Improve "change vnc" error reporting
ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c
ui: Reduce nesting in hmp_change_vnc() slightly
ui: Don't check for mode change after mouse_set error
ui: Split hmp_mouse_set() and move the HMP part to ui/
ui: Simplify control flow in qemu_mouse_set()
meson.build | 4 +- hw/display/qxl.h | 2 - include/monitor/hmp.h | 8 + include/monitor/qmp-helpers.h | 26 ++ include/ui/console.h | 2 +- include/ui/qemu-spice.h | 8 +- include/ui/spice-display.h | 2 - chardev/spice.c | 2 - hw/display/qxl.c | 26 +- monitor/hmp-cmds.c | 368 +-------------------------- monitor/misc.c | 67 ----- monitor/qmp-cmds.c | 176 +++---------- ui/input.c | 32 ++- ui/spice-display.c | 10 - ui/ui-hmp-cmds.c | 460 ++++++++++++++++++++++++++++++++++ ui/ui-qmp-cmds.c | 177 +++++++++++++ ui/vdagent.c | 4 - hw/display/trace-events | 1 - ui/meson.build | 2 + 19 files changed, 727 insertions(+), 650 deletions(-) create mode 100644 include/monitor/qmp-helpers.h create mode 100644 ui/ui-hmp-cmds.c create mode 100644 ui/ui-qmp-cmds.c
Signature · 1 line
2.39.0