soundwire: cadence: Fix oversized FIFO size define
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest3 patches 2 repliesApplied
- v13 patches 4 repliesSuperseded
Changes in v2 from the cover letter
- Rewrite commit message of patch #1
- Only reduce response_buf to 34 (32 + 2)
- Trim RX_FIFO_AVAIL to length of response_buf instead of expected FIFO size
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | soundwire: cadence: Don't overflow the command FIFOsdrivers/ | +2 | 0 replies | |
| 2/3 | soundwire: cadence: Remove wasted space in response_bufdrivers/ drivers/ | +19 | 0 replies | |
| 3/3 | soundwire: cadence: Drain the RX FIFO after an IO timeoutdrivers/ | +27 | 0 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Pierre-Louis Bossart |
|---|---|
| Series | R-b |
| 1/3 | R-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define
As determined by experimentation and asking a hardware person, the FIFO in the Cadence IP is actually only 8 entries long, not 32. This is fixed in patch #1.
As a bonus, patches #2 and #3 fix two other things I noticed while debugging this.
Changes since v1:
- Rewrite commit message of patch #1
- Only reduce response_buf to 34 (32 + 2)
- Trim RX_FIFO_AVAIL to length of response_buf instead of expected FIFO size
Richard Fitzgerald (3):
soundwire: cadence: Don't overflow the command FIFOs
soundwire: cadence: Remove wasted space in response_buf
soundwire: cadence: Drain the RX FIFO after an IO timeout
drivers/soundwire/cadence_master.c | 46 +++++++++++++++++++----------- drivers/soundwire/cadence_master.h | 13 ++++++++- 2 files changed, 41 insertions(+), 18 deletions(-)
Signature · 1 line
2.30.2