Skip to content

soundwire: cadence: Fix oversized FIFO size define

Richard Fitzgerald alsa-devel lkml 2 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesApplied
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Rewrite commit message of patch #1
- Only reduce response_buf to 34 (32 + 2)
- Trim RX_FIFO_AVAIL to length of response_buf instead of expected FIFO size

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3soundwire: cadence: Don't overflow the command FIFOsdrivers/soundwire/cadence_master.c+2 -10 replies
2/3soundwire: cadence: Remove wasted space in response_bufdrivers/soundwire/cadence_master.c drivers/soundwire/cadence_master.h+19 -10 replies
3/3soundwire: cadence: Drain the RX FIFO after an IO timeoutdrivers/soundwire/cadence_master.c+27 -230 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPierre-Louis Bossart
SeriesR-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] soundwire: cadence: Fix oversized FIFO size define

As determined by experimentation and asking a hardware person, the FIFO in the Cadence IP is actually only 8 entries long, not 32. This is fixed in patch #1.

As a bonus, patches #2 and #3 fix two other things I noticed while debugging this.

Changes since v1:
- Rewrite commit message of patch #1
- Only reduce response_buf to 34 (32 + 2)
- Trim RX_FIFO_AVAIL to length of response_buf instead of expected FIFO size

Richard Fitzgerald (3):
soundwire: cadence: Don't overflow the command FIFOs
soundwire: cadence: Remove wasted space in response_buf
soundwire: cadence: Drain the RX FIFO after an IO timeout

 drivers/soundwire/cadence_master.c | 46 +++++++++++++++++++-----------
 drivers/soundwire/cadence_master.h | 13 ++++++++-
 2 files changed, 41 insertions(+), 18 deletions(-)
Signature · 1 line
2.30.2